1 2002-11-19 Bruno Haible <bruno@clisp.org>
3 * mbswidth.h (PARAMS): Remove macro.
4 (mbswidth, mbsnwidth): Use ANSI C function declarations.
5 * mbswidth.c (mbswidth, mbsnwidth): Likewise.
7 * gcd.h (PARAMS): Remove macro.
8 (gcd): Use ANSI C function declarations.
9 * gcd.c (gcd): Likewise.
11 2002-11-15 Bruno Haible <bruno@clisp.org>
13 * strcspn.c: Include <stddef.h>.
14 (strcspn): Use ANSI C function declaration. Change return type to
16 * strpbrk.c: Minimize diffs to glibc. Include <stddef.h>.
18 * strpbrk.h (PARAMS): Remove macro.
19 (strpbrk): Use ANSI C function declaration.
20 * strstr.c: Don't include <sys/types.h>.
21 * strstr.h (PARAMS): Remove macro.
22 (strstr): Use ANSI C function declarations.
24 2002-11-06 Bruno Haible <bruno@clisp.org>
26 * gcd.h (gcd): Change argument type to 'unsigned long'.
27 * gcd.c (gcd): Likewise.
29 2002-11-05 Bruno Haible <bruno@clisp.org>
31 * gcd.h: New file, from gettext-0.11.5.
32 * gcd.c: New file, from gettext-0.11.5.
34 2002-11-05 Bruno Haible <bruno@clisp.org>
36 * error.c [!_LIBC]: Include gettext.h instead of <libintl.h>.
37 * getopt.c [!_LIBC]: Include gettext.h instead of <libintl.h>.
38 * obstack.c [!_LIBC]: Include gettext.h instead of <libintl.h>.
39 * regex.c [!_LIBC]: Include gettext.h instead of <libintl.h>.
41 * argmatch.c: Include gettext.h instead of <locale.h> and <libintl.h>.
42 * makepath.c: Include gettext.h instead of <locale.h> and <libintl.h>.
44 * closeout.c: Include gettext.h instead of <libintl.h>.
45 * human.c: Include gettext.h instead of <libintl.h>.
46 * quotearg.c: Include gettext.h instead of <libintl.h>.
47 * rpmatch.c: Include gettext.h instead of <libintl.h>.
48 * unicodeio.c: Include gettext.h instead of <libintl.h>.
49 * userspec.c: Include gettext.h instead of <libintl.h>.
50 * version-etc.c: Include gettext.h instead of <libintl.h>.
51 * xmalloc.c: Include gettext.h instead of <libintl.h>.
52 (textdomain): Remove definition.
53 * xmemcoll.c: Include gettext.h instead of <libintl.h>.
55 * long-options.c: Remove include of <libintl.h> and definition of _.
56 * same.c: Remove include of <libintl.h> and definition of _.
58 2002-11-04 Bruno Haible <bruno@clisp.org>
60 * stpcpy.h: New file, from GNU gettext-0.11.5.
61 * strcase.h: New file, from GNU gettext-0.11.5.
62 * strpbrk.h: New file, from GNU gettext-0.11.5.
63 * strstr.h: New file, from GNU gettext-0.11.5.
64 * xgetcwd.h: New file, from GNU gettext-0.11.5.
66 2002-05-09 Bruno Haible <bruno@clisp.org>
68 * config.charset: Update for newest glibc. Add canonical names
69 ISO-8859-14, KOI8-T, TCVN5712-1, GEORGIAN-PS.
71 2002-05-09 Bruno Haible <bruno@clisp.org>
73 * localcharset.c (get_charset_aliases): Add more Windows specific
76 2002-05-08 Owen Taylor <otaylor@redhat.com>
78 * config.charset: A few additions for Solaris.
80 2001-12-05 Bruno Haible <bruno@clisp.org>
82 * localcharset.c (locale_charset): Don't return an empty string.
84 2001-10-23 Bruno Haible <haible@clisp.cons.org>
86 * config.charset: msdos in uk_UA uses CP1125.
88 2001-08-05 Bruno Haible <haible@clisp.cons.org>
90 Make it possible to build libcharset with CC=gcc CFLAGS="-x c++".
91 * localcharset.c (locale_charset): Declare as extern "C".
93 2002-02-15 Bruno Haible <bruno@clisp.org>
95 * config.charset [msdosdjgpp]: For Russian, use CP866.
97 2002-02-11 Bruno Haible <bruno@clisp.org>
99 * config.charset: Add support for NetBSD.
101 2002-09-25 <karl@gnu.org>
103 * strdup.c: copy from libc/string (via ../config/srclist*).
104 * getopt*: copy from libc/posix.
105 * gettext.h: copy from gettext.
106 * .cppi-disable: add strdup.c, gettext.h.
108 2002-07-01 Jim Meyering <meyering@lucent.com>
110 * c-stack.c: Include sys/time.h.
111 From Volker Borchert.
113 2002-06-11 Paul Eggert <eggert@twinsun.com>
115 * fnmatch.c, fnmatch_loop.c (WIDE_CHAR_SUPPORT):
116 New macro. Use it uniformly instead of
117 (defined HAVE_WCTYPE_H && defined HAVE_WCHAR_H).
118 It also uses HAVE_BTOWC, to fix a porting bug on Solaris 2.5.1
119 reported by Vin Shelton.
121 2002-06-22 Jim Meyering <meyering@lucent.com>
123 * fnmatch.c (ISASCII, ISPRINT): Undefine, to avoid warning about
124 redefinition due to Solaris5.6's definition in /usr/include/sys/euc.h.
126 2002-06-22 Paul Eggert <eggert@twinsun.com>
128 * c-stack.h (segv_handler, c_stack_action) [! defined SA_SIGINFO]:
129 Do not assume SA_SIGINFO behavior.
130 Bug reported by Jim Meyering on NetBSD 1.5.2.
132 2002-06-22 Jim Meyering <meyering@lucent.com>
134 * c-stack.c, c-stack.h: New files, from diffutils-2.8.2.
136 * exitfail.c, exitfail.h: Likewise.
137 * Makefile.am (libfetish_a_SOURCES): Add exitfail.c and exitfail.h.
139 * Makefile.am (libfetish_a_SOURCES): Add fnmatch_.h in place
141 (EXTRA_DIST): Add fnmatch_loop.c.
142 (libfetish_a_SOURCES): Add c-stack.c and c-stack.h.
144 * fnmatch_loop.c: New file, from diffutils-2.8.2.
145 * fnmatch.c: Update from diffutils-2.8.2.
146 * fnmatch_.h: New file. From diffutils-2.8.2.
147 * fnmatch.h: Remove file.
149 2002-06-18 Paul Eggert <eggert@twinsun.com>
151 * file-type.h: Report an error if neither S_ISREG nor
152 S_IFREG is defined, instead of using a test specific to glibc
153 2.2. This should be safe, since POSIX requires S_ISREG and
154 Unix Version 7 had S_IFREG. We don't need to check for
155 <sys/types.h> since we don't use any symbols that it defines.
157 2002-06-15 Jim Meyering <meyering@lucent.com>
159 * file-type.h (FILE_TYPE_H): Guard entire contents with #ifndef.
160 For GNU libc 2.2 and newer, ensure that <sys/types.h> and <sys/stat.h>
161 have been included before this file.
163 2002-06-13 Richard Dawe <richdawe@bigfoot.com>
165 * Makefile.am (lstat.c, stat.c, .sin.sed): Use t-$@, rather than $@-t,
166 so that each temporary file name is unique and valid in the first
167 8 characters, for operation under DOS.
169 2002-06-15 Jim Meyering <meyering@lucent.com>
171 Work even with DJGPP 2.03, which lacks support for symlinks.
173 * xstat.in (S_ISLNK): Define to 0 if neither S_ISLNK nor S_IFLNK
175 * lchown.c (S_ISLNK): Likewise.
177 2002-06-14 Jim Meyering <meyering@lucent.com>
179 * file-type.h: Use the version from diffutils-2.8.2.
180 * file-type.c: Likewise.
182 2002-05-27 Jim Meyering <meyering@lucent.com>
184 Fix a problem seen only on nonconforming systems whereby ls.c's
185 use of localtime, and then of gettimeofday would cause trouble:
186 the localtime call used to initialize rpl_gettimeofday's save
187 mechanism would clobber ls's current local time information so
188 that in any long listing the first file would always be listed
189 with date 1970-01-01. Analysis by Volker Borchert.
191 * gettimeofday.c (localtime): Undefine.
192 (rpl_localtime): New function.
194 2002-05-22 Jim Meyering <meyering@lucent.com>
196 * Makefile.am (libfetish_a_SOURCES): Add file-type.c and file-type.h.
197 * file-type.h: New file.
198 * file-type.c (file_type): New file/function. Extracted from diffutils.
200 2002-04-29 Paul Eggert <eggert@twinsun.com>
202 * hard-locale.c: Upgrade to version used in GNU Diffutils 2.8.1.
204 2002-04-28 Paul Eggert <eggert@twinsun.com>
206 * sig2str.h (SIGNUM_BOUND): Do not use WTERMSIG, to avoid
207 depending on <sys/wait.h> and WTERMSIG. Default to 64 instead
208 of 127, since 64 is the largest conceivable number for ancient
210 * sig2str.c: Do not include <sys/wait.h>; no longer needed.
212 2002-04-28 Jim Meyering <meyering@lucent.com>
214 * sig2str.c (WTERMSIG): Remove definition (unused).
216 2002-04-28 Paul Eggert <eggert@twinsun.com>
218 * sig2str.h, sig2str.c: New files.
219 * Makefile.am (libfetish_a_SOURCES): Add sig2str.h.
221 2002-04-24 Jim Meyering <meyering@lucent.com>
223 * gettext.h: New file, from Gettext.
224 * Makefile.am (INCLUDES): Remove -I../intl.
225 (libfetish_a_SOURCES): Add gettext.h.
227 2002-04-16 Jim Meyering <meyering@lucent.com>
229 * readutmp.h (UT_TYPE): Remove definition (now in who.c).
230 (HAVE_STRUCT_XTMP_UT_EXIT, HAVE_STRUCT_XTMP_UT_ID): Define.
231 (HAVE_STRUCT_XTMP_UT_PID, HAVE_STRUCT_XTMP_UT_TYPE): Define.
233 2002-04-12 Jim Meyering <meyering@lucent.com>
235 * dirfd.h (dirfd): Elide prototype if dirfd is a macro.
237 2002-03-10 Jim Meyering <meyering@lucent.com>
239 * makepath.c (make_path): Remove a comma from a diagnostic.
240 Suggestion from Santiago Vila.
242 2002-03-08 Jim Meyering <meyering@lucent.com>
244 * rename.c: Mention that this wrapper is needed also on
245 mips-dec-ultrix4.4 systems.
247 2002-03-02 Jim Meyering <meyering@lucent.com>
249 * gettime.c (gettime): Test HAVE_CLOCK_GETTIME,
250 not HAVE_CLOCK_SETTIME.
252 2002-02-27 Paul Eggert <eggert@twinsun.com>
254 * nanosleep.h: Rename to....
255 * timespec.h: New name for nanosleep.h. All uses changed.
257 * gettime.c: New file.
258 * settime.c: New file.
261 * Makefile.am (libfetish_a_SOURCES): Add gettime.c, settime.c,
262 timespec.h. Remove nanosleep.h.
264 2002-02-25 Paul Eggert <eggert@twinsun.com>
266 * acl.c, acl.h: New files.
267 * Makefile.am (libfetish_a_SOURCES): Add acl.h, acl.c.
269 2002-02-24 Jim Meyering <meyering@lucent.com>
271 * strnlen.c (strnlen): Define-away/undef so that an inconsistent
272 prototype in string.h (on at least AIX4.3.2.0 w/gcc-2.95.3) doesn't
273 cause trouble. Reported by Nelson Beebe.
275 2002-02-23 Paul Eggert <eggert@twinsun.com>
277 * path-concat.c (xpath_concat): Reorder code to pacify
278 compilers that don't know that xalloc_die never returns.
280 2002-02-20 Jim Meyering <meyering@lucent.com>
282 * getdate.c: Regenerate using bison-1.33.
284 2002-02-15 Paul Eggert <eggert@twinsun.com>
286 * posixver.c, posixver.h: New files.
287 * Makefile.am (libfetish_a_SOURCES): Add them.
289 2002-02-02 Paul Eggert <eggert@twinsun.com>
290 Bruno Haible <bruno@clisp.org>
292 * unicodeio.h (print_unicode_char): Add exit_on_error argument.
293 (fwrite_success_callback): New declaration.
294 * unicodeio.c (unicode_to_mb): New function, extracted from
295 print_unicode_char. Call failure callback instead of error.
296 (fwrite_success_callback): New function.
297 (exit_failure_callback): New function.
298 (fallback_failure_callback): New function.
299 (print_unicode_char): Call unicode_to_mb.
301 2002-01-26 Jim Meyering <meyering@lucent.com>
303 * Makefile.am (getdate$U.o): Depend on unlocked-io.h.
305 2002-01-22 Jim Meyering <meyering@lucent.com>
307 * Makefile.am (Makefile): Don't depend on $(BUILT_SOURCES).
308 Otherwise, some versions of automake would omit the rule that makes
309 Makefile from Makefile.in.
311 2001-01-21 Paul Eggert <eggert@twinsun.com>
313 * xmemcoll.h, xmemcoll.c: New files.
314 * Makefile.am (libfetish_a_SOURCES): Add them.
315 * memcoll.c: Include errno.h, and declare errno if not defined.
316 (memcoll): Set errno to zero if there is no error.
318 * quotearg.c (quotearg_buffer_restyled):
319 Fix bug with quoting buffers containing NUL when backslashing escapes.
320 This bug was exposed by the other changes in this patch.
321 (quotearg_n_options): New arg ARGSIZE.
323 (quoting_options_from_style): New function.
324 (quotearg_n_style): Use it.
325 (quotearg_n_style_mem): New function.
327 * quotearg.h (quotearg_n_style_mem): New function.
329 2002-01-16 Jim Meyering <meyering@lucent.com>
331 * getdate.y: Add three semicolons, each just before a closing brace.
332 Bison (as of version 1.31) no longer papers over that mistake.
334 2002-02-14 Paul Eggert <eggert@twinsun.com>
336 * backupfile.c (ISDIGIT): Comment fix.
337 * getdate.y (ISDIGIT): Likewise.
338 * posixtm.c (ISDIGIT, year): Likewise.
339 * strverscmp.c (ISDIGIT): Likewise.
340 * userspec.c (ISDIGIT): Likewise.
342 2002-01-05 Jim Meyering <meyering@lucent.com>
344 * version-etc.c (version_etc_copyright): Update copyright year.
346 2001-01-19 Paul Eggert <eggert@twinsun.com>
348 * closeout.c (close_stdout_status): If ferror (stdout), do
349 not silently exit merely because the output buffer happens to
350 have nothing pending.
352 2001-12-18 Paul Eggert <eggert@twinsun.com>
354 See the big note in ../ChangeLog.
355 * human.c (suffixes): Prefer K to k for 1024.
356 (generate_suffix_backwards): New function.
357 (human_readable_inexact): Use it.
358 * xstrtol.c (__xstrtol): If there is no number but there
359 is a valid suffix, assume 1. "MB" now means decimal, "MiB" binary.
360 Accept 'K' as well as 'k'.
362 2001-12-15 Jim Meyering <meyering@lucent.com>
364 * regex.h (__restrict_arr): Update from libc.
366 * mountlist.h (ME_REMOTE): Recognize file systems of type smbfs
367 as `remote' if the name starts with `//'. Suggested by Michael Stone.
370 2001-12-10 Jim Meyering <meyering@lucent.com>
372 * linebuffer.c: Remove explicit declarations of xmalloc and xrealloc,
373 Instead, include "xalloc.h".
374 (initbuffer): Don't cast xmalloc return value to char*.
375 (readline): Reword comment.
376 Don't cast xrealloc return value to char*
379 2001-12-09 Jim Meyering <meyering@lucent.com>
381 * modechange.c (mode_compile): Add cast to avoid pedantic warning about
382 `signed and unsigned type in conditional expression'.
383 * posixtm.c (posix_time_parse): Likewise.
385 * xreadlink.c (xreadlink): Add cast to avoid a pedantic warning.
387 * readtokens.c (readtoken): Declare an index to be of type unsigned
388 to avoid a pedantic warning.
390 * getstr.c: Don't include assert.h.
391 (getstr): Remove warning-evoking assertions.
392 Return -1 if offset parameter is out of bounds.
393 Change the type of a local from int to size_t.
395 * strftime.c (my_strftime_localtime_r): Include this function
396 definition in the `#if ! HAVE_TM_GMTOFF' block.
398 * xgethostname.c: Remove declarations of xmalloc and xrealloc.
399 Include xalloc.h instead.
401 2001-12-02 Jim Meyering <meyering@lucent.com>
403 * tempname.c: Don't declare getenv, thus reverting the change of
404 2001-11-18. It's no longer necessary, now that stdlib.h is always
407 * regex.c [!__BOUNDED_POINTERS__]: Define away __bounded,
408 __unbounded, and __ptrvalue. Reported by Uwe H. Steinfeld.
410 2001-11-30 Akim Demaille <akim@epita.fr>
412 * xstrdup.c: Include xalloc.h, so that xstrdup is declared
413 before being defined.
415 2001-11-27 Paul Eggert <eggert@twinsun.com>
417 * quotearg.h (quotearg_n, quotearg_n_style):
418 First arg is int, not unsigned.
419 * quotearg.c (quotearg_n, quotearg_n_style): Likewise.
420 (SIZE_MAX, UINT_MAX): New macros.
421 (quotearg_n_options): Abort if N is negative.
422 Avoid overflow check on hosts where size_t is 64 bits and int
423 is 32 bits, as overflow is impossible there.
424 Fix off-by-one typo that caused unnecessary reallocation.
426 2001-11-27 Jim Meyering <meyering@lucent.com>
428 * tempname.c: Merge with version from libc.
431 * tempname.c: Include stdlib.h unconditionally. On some old systems
432 for which STDC_HEADERS is 0, it was not included, resulting in a
433 warning about an integer-to-pointer conversion problem with getenv.
434 Reported by Volker Borchert.
436 2001-11-26 Jim Meyering <meyering@lucent.com>
438 * gtod.h: Remove file.
439 * Makefile.am (libfetish_a_SOURCES): Remove gtod.h.
440 * gettimeofday.c: Don't include gtod.h.
441 (GTOD_init): Remove function.
442 (rpl_gettimeofday): Do its job here instead, rather than aborting.
443 Suggestion from Volker Borchert.
445 2001-11-23 Jim Meyering <meyering@lucent.com>
447 * hash.h (struct hash_table): Don't define here. Merely declare it.
448 * hash.c (struct hash_table): Define it here instead.
450 2001-11-22 Jim Meyering <meyering@lucent.com>
452 * hash.h: Bracket contents of file with #ifndef HASH_H_ ... #endif.
454 2001-11-18 Paul Eggert <eggert@twinsun.com>
456 * tempname.c (TMP_MAX): Remove; no longer needed.
457 (TEMPORARIES): New macro.
458 (__gen_tempname): Use TEMPORARIES rather than TMP_MAX. This
459 removes an artificial limitation (e.g. HP-UX 10.20, where
462 2001-11-18 Jim Meyering <meyering@lucent.com>
464 * tempname.c [!HAVE_DECL_GETENV]: Declare getenv to avoid warning
467 * Makefile.am (Makefile): Depend on $(BUILT_SOURCES), so those
468 files will be created before anything else.
470 2001-11-17 Jim Meyering <meyering@lucent.com>
472 * modechange.c (mode_adjust): Fix error introduced on 1999-04-26
473 that made e.g., `chmod a=,o=w,g=o F' cause F to be group readable
474 rather than group writable. Patch by Juan F. Codagnone.
476 * readtokens.c: Remove explicit declarations of xmalloc and xrealloc,
477 Instead, include "xalloc.h".
479 * mountlist.c: Include unlocked-io.h after all system headers.
480 Remove explicit declarations of xmalloc, xrealloc,
481 and xstrdup. Instead, include "xalloc.h".
483 * argmatch.c, closeout.c, error.c, exclude.c: Include unlocked-io.h.
484 * fatal.c, getdate.y, getpass.c, getstr.c, getusershell.c: Likewise.
485 * mountlist.c, posixtm.c, readtokens.c, readutmp.c: Likewise.
487 * regex.c, sha.c, version-etc.c, yesno.c: Likewise.
488 Reported by Padraig Brady.
490 * mkstemp.c: #undef mkstemp.
492 (rpl_mkstemp): Rename from mkstemp.
495 2001-11-16 Jim Meyering <meyering@lucent.com>
497 * physmem.c [HAVE_SYS_PSTAT_H]: Include <sys/pstat.h>.
498 (physmem_total) [HAVE_PSTAT_GETSTATIC]: If sysconf couldn't be used to
499 determine the amount of total physical memory, use pstat_getstatic.
500 HPUX-11 doesn't define _SC_PHYS_PAGES.
501 (physmem_available) [HAVE_PSTAT_GETSTATIC && HAVE_PSTAT_GETDYNAMIC]:
502 If sysconf couldn't be used to determine the amount of available
503 physical memory, use both pstat_getstatic and pstat_getdynamic.
504 Based on a patch from Bob Proulx.
506 2001-11-05 Jim Meyering <meyering@lucent.com>
508 * xstat.in (slash_aware_lstat): Correct a misleading comment.
510 2001-11-03 Jim Meyering <meyering@lucent.com>
512 * argmatch.h (ARGMATCH_TO_ARGUMENT): Remove casts of first two args
513 in argmatch_to_argument call.
515 * dirfd.c (dirfd): Reflect the fact that DIR_TO_FD now takes an
518 * hash.c (hash_clear): Fix a bug that could lead to an infloop or
519 e.g., a fault due to an attempt to free a NULL pointer.
521 2001-11-01 Jim Meyering <meyering@lucent.com>
523 * dirfd.c, dirfd.h: New files.
524 * Makefile.am (libfetish_a_SOURCES): Add dirfd.h.
526 * hash.c (hash_print) [TESTING]: Clean up.
528 2001-10-22 Paul Eggert <eggert@twinsun.com>
530 * hard-locale.c (alloca): Define to __builtin_alloca if __GNUC__,
531 to avoid a warning if -Wall.
533 2001-10-21 Paul Eggert <eggert@twinsun.com>
535 * regex.c (uintptr_t): Remove macro and decl; it's config.h's job.
537 2001-10-21 Jim Meyering <meyering@lucent.com>
539 * obstack.c (_): Honor the setting of ENABLE_NLS. Otherwise,
540 this code would end up calling gettext even in packages built
542 * getopt.c (_): Likewise.
543 * regex.c (_): Likewise.
545 2001-10-20 Paul Eggert <eggert@twinsun.com>
547 * error.c (strerror_r): Do not declare unless !_LIBC.
548 Do not check for HAVE_DECL_STRERROR_R missing unless STRERROR_R_CHAR_P.
549 Use strerror_r that is only a macro, even if it is not a function.
550 (strerror): Check for HAVE_DECL_STRERROR before declaring.
551 (private_strerror): Use prototypes, not old-style function definition.
552 (print_errno_message): New function.
553 Support the POSIX 'int'-flavored strerror_r, as well as the traditional
555 (error_tail, error, error_at_line): Use it.
557 2001-10-11 Jim Meyering <meyering@lucent.com>
559 * argmatch.c (argmatch_invalid): Use quotearg_n_style (0, ...
560 and quote_n (1, ... to avoid clobbering a buffer.
562 2001-10-05 Jim Meyering <meyering@lucent.com>
564 * Makefile.am: (libfetish_a_SOURCES): Add hash-pjw.c and hash-pjw.h.
565 * hash-pjw.c: New file (factored out of fileutils' remove.c).
566 * hash-pjw.h: New file.
568 2001-09-30 Jim Meyering <meyering@lucent.com>
570 * mountlist.c [MOUNTED_GETFSSTAT]:
571 Include <sys/ucred.h>, for Apple Darwin.
572 Include sys/mount.h and sys/fs_types.h only if available.
574 (read_filesystem_list): Use FS_TYPE.
576 2001-09-29 Paul Eggert <eggert@twinsun.com>
578 * exclude.c (excluded_filename): 0 -> false, since it's
581 2001-09-28 Paul Eggert <eggert@twinsun.com>
583 Fix bug reported by Petter Reinholdtsen for HP-UX 10.20, which
584 #defines strtoimax. Also treat the other strto* functions
587 * xstrtol.c (strtol): Do not declare if HAVE_DECL_STRTOL.
588 (strtoul): Do not declare if HAVE_DECL_STRTOUL.
589 (strtoimax, strtoumax): Do not declare if already defined as a macro.
591 2001-09-26 Jim Meyering <meyering@lucent.com>
593 Most macros in unlocked-io.h had the wrong number of arguments.
594 * gen-uio: New script.
595 (USE_UNLOCKED_IO): Define to 1 if not already defined.
596 * unlocked-io.hin: Remove file.
597 * Makefile.am (unlocked-io.h): Rewrite to use a separate script,
598 rather than trying to embed it here.
599 (EXTRA_DIST): Add gen-uio. Remove unlocked-io.hin
600 Reported by Padraig Brady.
602 2001-09-25 Volker Borchert <bt@teknon.de>
604 * gettimeofday.c (rpl_gettimeofday): Declare local variable `result'.
606 2001-09-23 Jim Meyering <meyering@lucent.com>
608 * mountlist.c: Remove useless parentheses in #if directives.
609 (MOUNTED) [!defined MOUNTED]: Define to _PATH_MOUNTED, for when
610 the deprecated MOUNTED symbol is no longer defined in mntent.h.
612 2001-09-22 Jim Meyering <meyering@lucent.com>
614 * localcharset.c: Update from latest gettext.
615 * config.charset: Likewise.
617 2001-09-20 Jim Meyering <meyering@lucent.com>
619 * xstrtol.c (strtoimax): Guard declaration with
620 `#if !HAVE_DECL_STRTOIMAX', rather than just `#ifndef strtoimax'.
621 The latter fails because some systems (at least rs6000-ibm-aix4.3.3.0)
622 have their own, conflicting declaration of strtoimax in sys/inttypes.h.
623 (strtoumax): Likewise, for completeness (it wasn't necessary).
625 2001-09-06 Paul Eggert <eggert@twinsun.com>
627 * strtoimax.c (HAVE_LONG_LONG):
628 Redefine to HAVE_UNSIGNED_LONG_LONG if unsigned.
629 (strtoimax): Use sizeof (long), not sizeof strtol (ptr, endptr, base),
630 to work around bug in IBM C compiler.
632 2001-09-16 Jim Meyering <meyering@lucent.com>
636 2001-09-04 Paul Eggert <eggert@twinsun.com>
638 * xgetcwd.c: Revert some of the previous change; intead,
639 fix the HAVE_GETCWD_NULL code to behave more like the
640 !HAVE_GETCWD_NULL code used to.
643 (xgetcwd): Do not return NULL when memory is exhausted; instead,
646 2001-09-04 Paul Eggert <eggert@twinsun.com>
648 * xreadlink.c (xreadlink): Omit size_t* arg. All uses changed.
649 Use ssize_t, not int, to store result of readlink.
650 Check for ssize_t overflow as well as size_t overflow,
651 as POSIX says the result of readlink is implementation-defined
652 when ssize_t overflows.
653 Remove unnecessary cast to char*.
654 Use free+malloc instead of realloc, as the storage doesn't need
655 to be preserved and it's clearer and can be more efficient that way.
656 (SIZE_MAX, SSIZE_MAX): New macros, if <limits.h> doesn't declare.
657 * xreadlink.h (xreadlink): Update prototype.
659 2001-09-03 Paul Eggert <eggert@twinsun.com>
661 * exclude.c (fnmatch_no_wildcards): Fix confusion between
662 usage of FNM_CASEFOLD and FNM_LEADING_DIR. The bug was
663 spotted by Jim Meyering.
665 2001-09-03 Jim Meyering <meyering@lucent.com>
667 * xreadlink.c (xreadlink): Preserve errno around `free' during failure.
669 2001-09-03 Paul Eggert <eggert@twinsun.com>
671 * xgetcwd.c: Fix the !HAVE_GETCWD_NULL code to behave more
672 like the HAVE_GETCWD_NULL code.
673 Include pathmax.h if not HAVE_GETCWD.
674 Do not include xalloc.h.
675 (INITIAL_BUFFER_SIZE): New symbol.
676 Do not use xmalloc / xrealloc, since the caller is responsible for
677 handling errors. Preserve errno around `free' during failure.
678 Do not overrun buffer when using getwd.
680 2001-09-03 Paul Eggert <eggert@twinsun.com>
682 * xgetcwd.c (xgetcwd): Use HAVE_GETCWD_NULL, not (defined
683 __GLIBC__ && __GLIBC__ >= 2), to decide whether to use getcwd (NULL, 0).
685 2001-09-02 Jim Meyering <meyering@lucent.com>
687 * error.c: Update from GNU libc.
689 2001-09-01 Jim Meyering <meyering@lucent.com>
691 * xreadlink.c: New file.
692 * xreadlink.h: New file.
693 * Makefile.am (libfetish_a_SOURCES): Add xreadlink.c and xreadlink.h.
695 * regex.c (uintptr_t) [!_LIBC]: Define to private_uintptr_t, so it
696 doesn't conflict with sparc-sun-solaris2.7's definition in
697 /usr/include/sys/int_types.h.
699 * exclude.c: Use `""', not `<>' to #include non-system header files.
700 (fnmatch_no_wildcards): Rewrite not to use function names, strcasecmp
701 and strncasecmp as r-values. Unixware didn't have declarations.
703 2001-08-31 Jim Meyering <meyering@lucent.com>
705 * xgetcwd.c (xgetcwd): Reorganize to avoid some duplication.
706 Use an initial, malloc'd, buffer of length 128 rather than
707 a statically allocated one of length 1024.
709 2001-08-30 Paul Eggert <eggert@twinsun.com>
711 * xgetcwd.c: Don't include pathmax.h.
712 Include stdlib.h and unistd.h if available.
714 (xmalloc, xstrdup, free): Remove decls.
715 (xgetcwd): Don't assume sizes fit in unsigned.
716 Check for overflow when computing sizes.
717 Simplify reallocation code.
719 2001-08-28 Paul Eggert <eggert@twinsun.com>
721 * Makefile.am (libfetish_a_SOURCES): Remove strtoxmax.c.
723 * strtoimax.c: Renamed from strtoxmax.c, removing the
726 Also, make the following further changes to make this file's
727 configuration more similar to that of strtol.c:
728 (UNSIGNED): Renamed from STRTOUXMAX_UNSIGNED. All uses changed.
729 (strtoumax, uintmax_t, strtoull, strtol): Remove.
730 (intmax_t, strtoimax, strtol, strtoll): New macros, if UNSIGNED.
731 (strtoimax): Renamed from strtoumax. All uses of unsigned values
732 changed to signed values.
734 And make the following changes as well:
735 Fix copyright notice, as 1999 was missing.
737 (strtoimax): Check sizes at compile-time, not run-time.
738 Prefer strtol to strtoll if both work.
739 (main): Remove; it was not that useful and was a pain to maintain.
741 * strtoumax.c: Include strtoimax.c, not strtouxmax.c.
743 2001-08-30 Paul Eggert <eggert@twinsun.com>
745 * savedir.c (savedir): Remove size parameter, as POSIX says that
746 a directory's st_size can have an arbitrary value, so the old
747 usage could waste an arbitrary amount of memory. All uses
749 * savedir.h: Update prototype.
751 2001-08-30 Paul Eggert <eggert@twinsun.com>
753 * xstrtol.c (strtoimax): New decl.
755 2001-08-28 Paul Eggert <eggert@twinsun.com>
757 * xstrtol.h: Add copyright notice.
758 (_DECLARE_XSTRTOL): Improve quality of diagnostic for
759 LONGINT_INVALID_SUFFIX_CHAR.
761 2001-08-30 Paul Eggert <eggert@twinsun.com>
763 * quotearg.c: BSD/OS 4.1 wchar.h requires FILE and struct
766 2001-08-30 Paul Eggert <eggert@twinsun.com>
768 * hash.c: Remove '2001' from copyright notice.
770 2001-08-30 Paul Eggert <eggert@twinsun.com>
772 * full-write.h: New file.
773 * Makefile.am (libfetish_a_SOURCES): Add full-write.h.
774 * full-write.c: Correct credits, as cccp.c no longer
775 exists and anyway it was so heavily changed from the old cccp
776 code as to be unrecognizable. Include full-write.h.
777 (full_write) Return size_t, with short writes meaning failure.
778 All callers changed. This fixes a bug with large buffers
780 * utime.c: Include full-write.h.
782 2001-08-30 Paul Eggert <eggert@twinsun.com>
784 Merge 'exclude' changes from tar 1.13.22.
785 This fixes one or two unlikely storage allocation overflow bugs,
786 but doesn't change user-visible behavior otherwise.
788 2001-08-30 Paul Eggert <eggert@twinsun.com>
790 * exclude.c (bool): Declare, perhaps by including stdbool.h.
791 (<sys/types.h>): Include only if HAVE_SYS_TYPES_H.
792 (<stdlib.h>, <string.h>, <strings.h>, <inttypes.h>, <stdint.h>):
793 Include if available.
794 (<xalloc.h>): Include
795 (SIZE_MAX): Define if <stdint.h> or <inttypes.h> doesn't.
796 (verify): New macro. Use it to verify that EXCLUDE macros do not
797 collide with FNM macros.
798 (struct patopts): New struct.
799 (struct exclude): Use it, as exclude patterns now come with options.
800 (new_exclude): Support above changes.
801 (new_exclude, add_exclude_file):
802 Initial size must now be a power of two to simplify overflow checking.
803 (free_exclude, fnmatch_no_wildcards): New function.
804 (excluded_filename): No longer requires options arg, as the options
805 are determined by add_exclude. Now returns bool, not int.
806 (excluded_filename, add_exclude):
807 Add support for the fancy new exclusion options.
808 (add_exclude, add_exclude_file): Now takes int options arg.
809 Check for arithmetic overflow when computing sizes.
810 (add_exclude_file): xrealloc might modify errno, so don't
811 realloc until after errno might be used.
813 * exclude.h (EXCLUDE_ANCHORED, EXCLUDE_INCLUDE,EXCLUDE_WILDCARDS):
815 (free_exclude): New decl.
816 (add_exclude, add_exclude_file): Now takes int options arg.
817 (excluded_filename): No longer requires options arg, as the options
818 are determined by add_exclude. Now returns bool, not int.
820 2001-08-30 Paul Eggert <eggert@twinsun.com>
822 * alloca.c (alloca): Arg is of type size_t, not unsigned.
824 2001-08-27 Jim Meyering <meyering@lucent.com>
826 * Makefile.am (libfetish_a_SOURCES): Add strtoxmax.c
828 * version-etc.c (N_): Remove definition.
829 Revert most of last change.
830 Instead, simply don't mark the `Copyright...' string for translation.
831 Based on advice from Paul Eggert.
833 * strtoxmax.c: Tweak comment.
835 2001-08-26 Jim Meyering <meyering@lucent.com>
837 * version-etc.c (version_etc_copyright_fmt): Replace literal year
838 of copyright with `%s' so translators don't get an untranslated
840 (COPYRIGHT_YEAR): Define.
841 (version_etc): Use fprintf rather than fputs.
842 Suggestion from Ulrich Drepper.
844 * Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
846 * strtoll.c: New file, from GNU libc.
847 * xstrtoimax.c: New file.
849 * xstrtol.h: Add xstrtoimax.
850 * strtoumax.c: New file. Simply include "strtoumax.c".
851 * strtoimax.c: New file. Likewise, but first define STRTOUXMAX_SIGNED.
853 * strtoumax.c: Factor to work both for unsigned and signed types, ...
854 * strtoxmax.c: ... then renamed to this.
856 2001-08-13 Paul Eggert <eggert@twinsun.com>
858 * Makefile.am (unlocked-io.h): Do not append "_unlocked" twice.
859 Port to Solaris 8, where 'sed' requires a space after the 'r'
860 command, and where sh dislikes "$/". Clean up the spacing a bit.
861 Redirect output to $tmp just once.
863 2001-08-12 Paul Eggert <eggert@sic.twinsun.com>
865 * addext.c (<errno.h>): Include.
866 (errno): Declare if not defined.
867 (addext): Work correctly when pathconf returns -1 and leaves
868 errno alone because there is no limit. Also, work even if
869 pathconf returns a value greater than SIZE_MAX.
871 2001-08-12 Jim Meyering <meyering@lucent.com>
873 * xgetcwd.c (xgetcwd) [defined __GLIBC__ && __GLIBC__ >= 2]:
874 Simply `return getcwd (NULL, 0);'.
875 [! (defined __GLIBC__ && __GLIBC__ >= 2)]:
876 Use 1300 as initial value for length, not PATH_MAX.
878 * pathmax.h: Clean up cpp syntax.
880 2001-08-12 Jim Meyering <meyering@lucent.com>
882 * gettimeofday.c: New file.
884 * Makefile.am (libfetish_a_SOURCES): Add gtod.h.
886 2001-08-04 Jim Meyering <meyering@lucent.com>
888 * error.h (__attribute__): Remove `|| __STRICT_ANSI__' from #if stmt,
889 to get in sync with glibc.
891 2001-08-03 Paul Eggert <eggert@twinsun.com>
893 The following changes are from gettext 0.10.39 as maintained by
896 * mbswidth.h (MBSW_REJECT_UNPRINTABLE, MBSW_REJECT_INVALID):
897 Renamed from MBSW_ACCEPT_UNPRINTABLE and MBSW_ACCEPT_INVALID
898 with inverted sense. All uses changed.
900 * mbswidth.c: Don't include <limits.h>.
901 Include <stdlib.h> and <string.h> unconditionally.
902 (iswcntrl, mbsinit, ISCNTRL): New macros.
903 (mbsnwidth): Use K&R style function declarations.
904 Don't bother checking for MB_LEN_MAX == 1, since the compiler
905 can optimize it when MB_CUR_MAX == 1.
906 The width of control characters is zero, not 1.
908 2001-07-15 Jim Meyering <meyering@lucent.com>
910 * Makefile.am (EXTRA_DIST): Add unlocked-io.hin.
911 (BUILT_SOURCES): Add unlocked-io.h.
912 (io_functions): Define.
913 (unlocked-io.h): New rule.
914 (DISTCLEANFILES): Add unlocked-io.h.
915 (all-local): Depend on unlocked-io.h, to ensure it is created.
917 * unlocked-io.hin: New file
919 * regex.c: Update from glibc.
921 2001-07-05 Jim Meyering <meyering@lucent.com>
923 * Makefile.am (noinst_HEADERS): Remove definition, per new automake
925 (libfetish_a_SOURCES): Put all .h files here instead.
926 Remove a thus-exposed (better checks in automake) duplicate and
927 two unnecessary .h files.
929 2001-06-11 Jim Meyering <meyering@lucent.com>
931 * regex.c: Update from GNU libc.
933 2001-05-27 Jim Meyering <meyering@lucent.com>
935 * readutmp.h (UT_TYPE): Define.
937 2001-05-24 Jim Meyering <meyering@lucent.com>
939 * argmatch.c: Include "quote.h".
940 (argmatch_invalid): Remove explicit `' quotes. Instead, use the
941 quote function. Reported by Göran Uddeborg.
943 2001-05-20 Alexandre Duret-Lutz <duret_g@epita.fr>
945 * dirname.c (dir_name): Compute append_dot using path, not newpath
946 which is not yet declared.
948 2001-05-11 Paul Eggert <eggert@twinsun.com>
950 * Makefile.am (libfetish_a_SOURCES):
951 Add strftime.c, since we now compile it on all hosts.
953 * strftime.c (my_strftime):
954 Define to nstrftime if emacs, but only if my_strftime is not defined.
955 (extra_args, extra_args_spec, extra_args_spec_iso): Rename from
956 ut_argument, ut_argument_spec, ut_argument_spec_iso, respectively.
957 Add one more extra argument: a nanoseconds value.
960 (my_strftime function): Add %N format.
961 (emacs_strftimeu): Renamed from emacs_strftime,
962 with extra ut argument.
964 2001-05-11 Paul Eggert <eggert@twinsun.com>
966 dirname code cleanup. base_name now behaves more compatibly
967 with POSIX basename when given file names that have trailing
968 slashes, and similarly for dir_name. Add new primitives
969 base_len and dir_len. Put the directory-name-related decls
972 * addext.c (ISSLASH, base_name): Remove; now in dirname.h.
973 * backupfile.c (base_name): Likewise.
974 * basename.c (FILESYSTEM_PREFIX_LEN, PARAMS, ISSLASH): Likewise.
975 * dirname.c (FILESYSTEM_PREFIX_LEN, ISSLASH): Likewise.
976 * makepath.c (strip_trailing_slashes): Likewise.
977 * path-concat.c (DIRECTORY_SEPARATOR, FILESYSTEM_PREFIX_LEN, ISSLASH):
979 * rename.c (strip_trailing_slashes): Likewise.
980 * same.c (base_name): Likewise.
981 * stripslash.c (ISSLASH): Likewise.
983 * addext.c: Include <dirname.h> after size_t is defined.
984 * backupfile.c: Likewise.
986 * addext.c (addext): Use base_len to trim redundant
987 trailing slashes instead of doing it ourselves.
988 But do not trim the last slash if it is not redundant.
990 * backupfile.c (find_backup_file_name,
991 max_backup_version): Use base_len instead of rolling it ourselves.
992 Handle the case of "" and (on DOS) "C:" correctly.
994 * basename.c: Do not include <stdio.h>, <assert.h>; no longer needed.
995 Include <string.h>, <dirname.h>.
996 (base_name): Allow file names ending in slashes, other than names
997 that are all slashes. In this case, return the basename followed
998 by the slashes. This is more general, and can be used in places
999 where the original base_name purposely had an assertion failure.
1000 (base_len): New function.
1002 * dirname.c: Include <string.h> instead of <stdlib.h>.
1003 Do not include <assert.h>; no longer needed.
1005 (memrchr): Remove decl.
1006 (dir_name_r): Remove.
1007 (dir_len): Renamed from dirlen. All callers changed.
1008 Rewrite in terms of base_name, for simplicity and consistency.
1009 (dir_name): Never return NULL. All callers changed.
1010 Do not include <stdlib.h> in test program; no longer needed.
1011 return 0; is fine for test program.
1013 * dirname.h (DIRECTORY_SEPARATOR, ISSLASH, FILESYSTEM_PREFIX_LEN):
1015 (base_name, base_len, dir_len, strip_trailing_slashes): New decls.
1017 * path-concat.c (path_concat): Use base_len to compute
1018 base length, not strlen; this means we cannot rely on memcpy
1021 * same.c (STREQ): Remove.
1022 (same_name): Handle the case where the basename ends in trailing '/'.
1024 * stripslash.c (strip_trailing_slashes): Return nonzero if
1025 a slash was stripped. Do not strip the last slash after a
1028 2001-04-08 Jim Meyering <meyering@lucent.com>
1030 * getdate.y (get_date): Set tm_isdst to -1 to ensure that it is
1031 recomputed; that's necessary when the offset spans a DST transition.
1032 Patch by David J. MacKenzie. Reported by Hon-Yin Kok.
1034 2001-04-02 Jim Meyering <meyering@lucent.com>
1036 * regex.h, regex.c: Update from GNU libc.
1038 2001-03-19 Paul Eggert <eggert@twinsun.com>
1040 * version-etc.c (version_etc_copyright): Update to 2001.
1042 2001-03-16 Paul Eggert <eggert@twinsun.com>
1044 * tempname.c (uint64_t): Define to uintmax_t if
1045 not defined, and if UINT64_MAX is not defined.
1046 Required at least for Vax Ultrix4.3, which doesn't define uint64_t.
1047 Reported by John David Anglin.
1049 2001-03-10 Bruno Haible <haible@clisp.cons.org>
1051 * localcharset.c (locale_charset): Allow wildcard syntax. Also resolve
1052 alias if codeset is empty.
1053 * config.charset (BeOS): Use wildcard syntax.
1055 2001-03-13 Jim Meyering <meyering@lucent.com>
1057 * path-concat.c (path_concat) [FILESYSTEM_ACCEPTS_DRIVE_LETTER_PREFIX]:
1058 Don't insert a backslash when concatenating e.g., `C:' and `foo'.
1061 2001-03-06 Bruno Haible <haible@clisp.cons.org>
1063 * localcharset.c (locale_charset): Don't use setlocale(LC_CTYPE,NULL).
1065 * unicodeio.c (print_unicode_char): Simplify accordingly.
1067 2001-03-06 Bruno Haible <haible@clisp.cons.org>
1069 * config.charset: Update for FreeBSD 4.2 and OSF/1 5.1. Add
1070 support for DOS/DJGPP.
1072 2001-02-28 Paul Eggert <eggert@twinsun.com>
1074 * Makefile.am (libfetish_a_SOURCES):
1075 Add dup-safer.c, fopen-safer.c.
1076 (noinst_HEADERS): Add stdio-safer.h, unistd-safer.h.
1078 * dup-safer.c, fopen-safer.c, stdio-safer.h, unistd-safer.h: New files.
1080 2001-02-25 Paul Eggert <eggert@twinsun.com>
1082 The mkstemp replacement is taken from glibc 2.2.2, with some
1083 portability fixes for use outside glibc, as follows:
1085 * tempname.c (struct_stat64): New macro.
1086 (direxists, __gen_tempname): Use it.
1087 This avoids a portability problem with Solaris 8.
1089 * tempname.c (<config.h>): Include if HAVE_CONFIG_H.
1090 (<stddef.h>, <stdint.h>, <string.h>):
1091 Include only if STDC_HEADERS || _LIBC.
1092 (<fcntl.h>): Include only if HAVE_FCNTL_H || _LIBC.
1093 (<unistd.h>): Include only if HAVE_UNISTD_H || _LIBC.
1094 (<sys/time.h>): Include only if HAVE_SYS_TIME_H || _LIBC.
1095 (__set_errno): Define this macro if <errno.h> doesn't.
1096 (P_tmpdir, TMP_MAX, __GT_FILE, __GT_BIGFILE, __GT_DIR, __GT_NOCREATE):
1097 Define these macros if <stdio.h> doesn't.
1098 (S_ISDIR, S_IRUSR, S_IWUSR, S_IXUSR):
1099 Define these macros if <sys/stat.h>
1100 doesn't. Ignore <sys/stat.h> S_ISDIR if STAT_MACROS_BROKEN.
1101 (stat64, __getpid, __gettimeofday, __mkdir, __open, __open64, lxstat64,
1102 __xstat64): Define if not _LIBC.
1103 (__secure_getenv): Define if ! (HAVE___SECURE_GETENV || _LIBC).
1104 (__gen_tempname): Invoke gettimeofday only if
1105 HAVE_GETTIMEOFDAY || _LIBC;
1106 otherwise, fall back on plain "time".
1107 Use macros like S_IRUSR | S_IWUSR rather than octal values like 0600.
1109 * mkstemp.c (__GT_FILE): Define to zero if not defined.
1111 * mkstemp.c, tempname.c: New files, taken from glibc 2.2.2.
1113 2001-02-17 Jim Meyering <meyering@lucent.com>
1115 * strtoul.c: Sync from GNU libc. Use double quotes, not <...>
1116 around included file name.
1118 * strnlen.c (__strnlen): Merge in a change from GNU libc.
1120 * strftime.c: Update from GNU libc (the only changes were to comments).
1122 2001-02-13 Bruno Haible <haible@clisp.cons.org>
1124 * mbswidth.h (mbswidth): Also define as macro, to avoid prototype clash.
1126 2001-02-17 Paul Eggert <eggert@twinsun.com>
1128 * mbswidth.c, quotearg.c (mbrtowc, mbsinit):
1129 Remove workaround macros for hosts that have mbrtowc but not
1130 mbstate_t, as we now insist on proper declarations for both
1131 before using mbrtowc.
1133 2001-02-17 Jim Meyering <meyering@lucent.com>
1135 * regex.c: Update from libc.
1137 2001-02-16 Paul Eggert <eggert@twinsun.com>
1139 * alloca.c (malloc): Undef before defining, since stdlib.h
1140 may have defined it. Needed for Encore Umax-3.0.9.16b systems.
1141 Reported by Mark Hounschell via Paul Eggert.
1143 2001-01-30 Bruno Haible <haible@clisp.cons.org>
1145 * config.charset: Update for FreeBSD 4.2.
1147 2001-01-26 Jim Meyering <meyering@lucent.com>
1149 * quotearg.c: Include stddef.h.
1150 * quote.c: Include stddef.h.
1151 Reported by Axel Kittenberger.
1153 * xmalloc.c [HAVE_DONE_WORKING_MALLOC_CHECK]: Enclose error-evoking
1154 line in double quotes so that it evokes a better diagnostic.
1155 [HAVE_DONE_WORKING_REALLOC_CHECK]: Likewise.
1156 Reported by Axel Kittenberger.
1158 2001-01-15 Bruno Haible <haible@clisp.cons.org>
1160 * unicodeio.c (print_unicode_char): Cast the second iconv() arg,
1161 to avoid a warning. Add back 'const' to inptr.
1163 2001-01-16 Jim Meyering <meyering@lucent.com>
1165 * basename.c: Include <stdio.h>, needed by assert on SunOS4.
1168 2001-01-14 Jim Meyering <meyering@lucent.com>
1170 * rename.c: New file. From Volker Borchert.
1171 Include stdlib.h, string.h or strings.h, and xalloc.h.
1172 Use strip_trailing_slashes rather than open-coding it.
1174 2001-01-03 Paul Eggert <eggert@twinsun.com>
1176 * strftime.c: Sync with glibc time/strftime.c 1.81.
1178 2001-01-03 Jim Meyering <meyering@lucent.com>
1180 * unicodeio.c (print_unicode_char): Remove `const' from declaration of
1181 local `inptr' to avoid warning with some system declarations of iconv.
1183 2000-12-29 Paul Eggert <eggert@twinsun.com>
1185 * modechange.c: Do not assume that mode_t uses the
1186 traditional octal encoding. E.g. "chmod 1 FOO" should set
1187 the other-execute bit of FOO even if S_IXOTH != 1.
1189 (SUID, SGID, SVTX, RUSR, WUSR, XUSR, RGRP, WGRP, XGRP, ROTH,
1190 WOTH, XOTH, ALLM): New macros.
1191 (S_ISUID, S_ISGID, S_ISVTX, S_IRUSR, S_IWUSR, S_IXUSR,
1192 S_IRGRP, S_IWGRP, S_IXGRP, S_IROTH, S_IWOTH, S_IXOTH):
1194 (S_ISGID): Fix typo; it was defaulting to the same value as S_ISUID.
1195 (S_IRWXU, S_IRWXG, S_IRWXO): Specify defaults in terms of the above.
1197 No need to use uintmax_t; unsigned long is long enough.
1198 Don't bother to get suffix since we don't use it.
1200 2000-12-24 Jim Meyering <meyering@lucent.com>
1202 * hash.c (is_prime): Return explicit boolean values.
1203 (hash_get_first): Return NULL to appease Irix5.6's 89.
1204 Reported by Nelson Beebe.
1206 2000-10-31 Bruno Haible <haible@clisp.cons.org>
1208 * localcharset.c (locale_charset): Add support for Win32.
1210 2000-12-18 Paul Eggert <eggert@twinsun.com>
1212 * physmem.h, physmem.c: New files.
1214 * Makefile.am (libfetish_a_SOURCES): Add physmem.c.
1215 (noinst_HEADERS): Add physmem.h.
1217 * xstrtol.c (__xstrtol): Add undocumented suffixes 'g' and
1218 't' for compatibility with Solaris 8 sort.
1220 2000-12-18 Bruno Haible <haible@clisp.cons.org>
1222 * config.charset: Add support for BeOS.
1224 2000-12-16 Jim Meyering <meyering@lucent.com>
1226 * getusershell.c [!SHELLS_FILE && __DJGPP__]: Define
1227 SHELLS_FILE to a file name that's useful on djgpp systems.
1229 (ADDITIONAL_DEFAULT_SHELLS): Define.
1230 (default_shells): Prepend ADDITIONAL_DEFAULT_SHELLS.
1231 Based mostly on a patch from Prashant TR.
1233 2000-12-16 Jim Meyering <meyering@lucent.com>
1235 This bug had a serious impact on chown: `chown N:M FILE' (for integer
1236 N and M) would have treated it like `chown N:N FILE'.
1238 * userspec.c (parse_user_spec): Fix typo: s/u/g/.
1240 2000-10-31 Bruno Haible <haible@clisp.cons.org>
1242 * config.charset: Add ISO-8859-3, BIG5HKSCS, GB18030, JOHAB, VISCII,
1243 CP874, CP949, CP950, CP1250, CP1253, CP1254, CP1255, CP1256, CP1257
1244 to the list of canonical encodings. Rename EUC-CN to GB2312.
1246 2000-12-08 Andreas Schwab <schwab@suse.de>
1248 * mbswidth.c (mbsnwidth): Don't loop endlessly when called with an
1249 invalid mulitbyte sequence and with the MBSW_ACCEPT_INVALID flag set.
1251 2000-12-07 Jim Meyering <meyering@lucent.com>
1253 * stripslash.c (ISSLASH): Define.
1254 (strip_trailing_slashes): Use ISSLASH rather than comparing against `/'.
1257 * dirname.c (FILESYSTEM_PREFIX_LEN): Define.
1258 (dir_name_r): Declare this function as static.
1259 [BACKSLASH_IS_PATH_SEPARATOR]: Fix a bug that'd
1260 manifest itself on a name containing a mix of slashes and
1262 Make this function work with names starting with a DOS-style
1263 drive letter and colon prefix.
1264 (dir_name): Append `.' if necessary.
1265 Based mostly on patches from Prashant TR and Eli Zaretskii.
1267 * dirname.h (dir_name_r): Remove prototype.
1269 2000-12-05 Jim Meyering <meyering@lucent.com>
1271 * dirname.c (dir_name_r): Add `const' in a few local declarations.
1273 2000-12-04 Jim Meyering <meyering@lucent.com>
1275 * path-concat.c: [!HAVE_DECL_MALLOC]: Declare malloc.
1276 Also include memory.h, stdlib.h, unistd.h if appropriate.
1277 Reported by Andreas Jaeger (conflicting declaration of malloc).
1279 2000-12-02 Jim Meyering <meyering@lucent.com>
1281 * closeout.h: Make idempotent, to avoid some obscure warnings.
1283 2000-12-01 Paul Eggert <eggert@twinsun.com>
1285 * memrchr.c: Include <config.h> before any system include file.
1287 2000-11-29 Paul Eggert <eggert@twinsun.com>
1289 * dirname.c (dir_name_r): Fix typo: int -> size_t.
1291 2000-11-26 Jim Meyering <meyering@lucent.com>
1293 * memcoll.c: Include sys/types.h. From Werner Almesberger.
1295 2000-11-22 Paul Eggert <eggert@twinsun.com>
1297 * strftime.c (my_strftime): Do not invoke mbrlen with a
1298 size of (size_t) -1; it's not portable.
1300 2000-11-17 Akim Demaille <akim@epita.fr>
1302 * obstack.h: Formatting changes.
1303 (obstack_grow, obstack_grow0): Don't cast WHERE at all: that would
1304 prevent type checking.
1305 (obstack_ptr_grow, obstack_ptr_grow_fast): When assigning, don't
1306 cast the value to (void *): assigning a `foo *' to a `void *'
1308 (obstack_int_grow, obstack_int_grow_fast): Don't cast AINT to int.
1310 2000-11-17 Jim Meyering <meyering@lucent.com>
1312 * strstr.c: Update from GNU libc.
1314 2000-11-16 Jim Meyering <meyering@lucent.com>
1316 * strverscmp.c: Incorporate weak-alias-related changes from glibc.
1318 2000-11-11 Jim Meyering <meyering@lucent.com>
1320 * error.c: Add a couple #includes, merging from GNU libc version.
1322 2000-11-10 Jim Meyering <meyering@lucent.com>
1324 * obstack.h: Update from GNU libc.
1325 * obstack.c: Likewise.
1327 2000-11-06 Paul Eggert <eggert@twinsun.com>
1329 * getusershell.c (setusershell): Use rewind rather than
1330 fseek/fseeko, to avoid configuration hassles with fseeko.
1331 Don't bother opening SHELLS_FILE if shellstream is NULL;
1334 2000-11-05 Jim Meyering <meyering@lucent.com>
1336 * makepath.h (make_dir): Declare.
1337 * makepath.c (make_dir): Remove `static' attribute.
1340 2000-11-04 Alexandre Duret-Lutz <duret_g@epita.fr>
1342 * hash.c (hash_get_next): Fix a thinko: when ENTRY is the
1343 last one in a bucket, advance to the next bucket.
1345 2000-11-02 Vesselin Atanasov <vesselin@bgnet.bg>
1347 * fnmatch.c: Do not comment out all the code if we are using
1348 the GNU C library, because in some cases we are replacing buggy
1349 code in the GNU C library itself.
1351 2000-10-30 Paul Eggert <eggert@twinsun.com>
1353 * error.h, getline.h, modechange.h:
1354 Remove "2000" from Copyright line, as the file hasn't been
1355 changed this year other than in the copyright notice.
1357 * xalloc.h: Add "2000" to Copyright line, as this file
1358 was changed this year.
1360 2000-10-30 Paul Eggert <eggert@twinsun.com>
1362 * fnmatch.c (FOLD): Do not assume that characters are unsigned.
1363 (fnmatch): Fix some FNM_FILE_NAME and FNM_LEADING_DIR bugs,
1364 e.g. fnmatch("d*/*1", "d/s/1", FNM_FILE_NAME) incorrectly yielded zero.
1366 2000-10-29 Greg Louis <glouis@dynamicro.on.ca>
1368 * regex.h (__restrict_arr): Move definition out of #ifndef block.
1369 Required because egcs-2.91.66 (aka 1.1.2) defines __restrict, but
1370 doesn't define __restrict_arr.
1372 2000-10-29 Jim Meyering <meyering@lucent.com>
1374 * xstat.in: Fix grammar in comment.
1376 2000-10-28 Jim Meyering <meyering@lucent.com>
1378 * memchr.c: Update from libc.
1379 Adjust for portability:
1380 [HAVE_STDLIB_H]: Include stdlib.h.
1381 [HAVE_BP_SYM_H || _LIBC]: Guard inclusion of bp-sym.h.
1382 Undef __memchr, too.
1383 [!weak_alias]: Define __memchr to memchr.
1385 * regex.c: Update from libc.
1386 * regex.h: Likewise.
1387 * getopt1.c: Likewise.
1388 * memcmp.c: Likewise.
1390 * getusershell.c (setusershell) [HAVE_FSEEKO]: Use fseeko.
1391 Avoid using fseek, when possible -- it's broken by design.
1392 Patch by Ulrich Drepper.
1394 2000-10-26 Jim Meyering <meyering@lucent.com>
1396 * strftime.c: Update from libc.
1398 2000-10-25 Jim Meyering <meyering@lucent.com>
1400 * obstack.c: Update from libc.
1402 2000-10-23 Jim Meyering <meyering@lucent.com>
1404 * hard-locale.c (hard_locale): Revert last change -- it was simply
1405 wrong. That set_locale call must not have any side effects.
1408 2000-10-22 Jim Meyering <meyering@lucent.com>
1410 * md5.c (md5_process_block) [OP]: Use `rol', not CYCLIC.
1411 [CYCLIC]: Remove now-unused definition.
1413 * save-cwd.c (O_DIRECTORY): Define, if needed.
1414 (save_cwd) [HAVE_FCHDIR]: Use O_DIRECTORY when opening ".".
1415 Suggestion from Ulrich Drepper.
1417 2000-10-21 Jim Meyering <meyering@lucent.com>
1419 * dirname.c (dir_name_r): New function, factored out of dir_name.
1420 (dir_name): Use dir_name_r.
1421 * dirname.h (dir_name_r): Declare it.
1423 2000-10-21 Jim Meyering <meyering@lucent.com>
1425 * dirname.c (memrchr): Declare if necessary.
1426 (dir_name): Remove the restriction that there be no
1427 trailing slashes. Now, this code skips past them, effectively
1429 [TEST_DIRNAME] (main): New unit tests.
1431 * memrchr.c: New file from GNU libc.
1432 Undef __memrchr, too.
1433 [!weak_alias]: Define __memrchr to memrchr.
1434 Guard weak_alias use with `#ifdef weak_alias'.
1436 2000-10-17 Jim Meyering <meyering@lucent.com>
1438 * quote.h (PARAMS): Define and use.
1439 Reported by Akim Demaille.
1441 * getopt.c: Update from libc.
1443 2000-10-16 Jim Meyering <meyering@lucent.com>
1445 * hard-locale.c (hard_locale): Use "", not 0 as 2nd arg to setlocale.
1448 2000-09-25 Jim Meyering <meyering@lucent.com>
1450 * md5.h (rol): Define (from GnuPG).
1452 * sha.c: Give credit (GnuPG) where due.
1453 (M): Use rol rather than open-coding it.
1454 Add a FIXME comment.
1456 2000-09-21 Jim Meyering <meyering@lucent.com>
1458 * userspec.c (parse_user_spec): Remove debugging printf I'd added.
1459 Reported by Michael Stone.
1461 2000-09-20 Jim Meyering <meyering@lucent.com>
1463 * Makefile.am (libfetish_a_SOURCES): Add sha.c.
1464 (noinst_HEADERS): Add sha.h.
1465 Based on code from Scott G. Miller and from GnuPG.
1467 2000-09-15 Jim Meyering <meyering@lucent.com>
1469 * regex.c: Update from libc.
1471 2000-09-10 Jim Meyering <meyering@lucent.com>
1473 * getopt.c (_getopt_internal): Update from glibc.
1475 2000-09-09 Jim Meyering <meyering@lucent.com>
1477 * quotearg.c: Rename ISASCII to IN_CTYPE_DOMAIN, so people don't
1478 think it should be used as a general replacement for isascii.
1479 * fnmatch.c: Likewise.
1480 * mbswidth.c: Likewise
1481 * regex.c: Likewise.
1484 * userspec.c: Include sys/param.h and limits.h.
1486 (CHAR_BIT, TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM): Define.
1487 (UID_T_MAX, GID_T_MAX, MAXUID, MAXGID): Define.
1488 (parse_user_spec): Use xstrtoul, not atoi when converting numeric
1489 UID, GID. Check range.
1491 2000-09-06 Jim Meyering <meyering@lucent.com>
1493 * getopt.c (_getopt_internal): Update from glibc.
1495 2000-08-30 Jim Meyering <meyering@lucent.com>
1497 * strftime.c: Merge in changes from GNU libc.
1499 2000-08-26 Jim Meyering <meyering@lucent.com>
1501 * closeout.c: Include "__fpending.h".
1502 (close_stdout_status): Return right away if there's nothing to flush.
1504 * Makefile.am (noinst_HEADERS): Add __fpending.h.
1505 * __fpending.c: New file.
1506 * __fpending.h: New file.
1508 2000-08-07 Paul Eggert <eggert@twinsun.com>
1510 Standardize on "memory exhausted" instead of "Memory exhausted"
1511 or "virtual memory exhausted".
1512 * obstack.c (print_and_abort): Use "memory exhausted", not
1513 "virtual memory exhausted".
1514 * same.c (same_name): Invoke xalloc_die instead of printing
1516 * userspec.c (parse_user_spec): Likewise.
1517 * bumpalloc.h: comment fix
1518 * same.c, userspec.c: Include xalloc.h.
1520 * xalloc.h (xalloc_msg_memory_exhausted): Now char const[],
1521 not char *const and pointing to a constant array.
1522 * xmalloc.c (xalloc_msg_memory_exhausted): Likewise.
1523 (xrealloc): Comment fix.
1525 * userspec.c (parse_user_spec):
1526 Don't translate a message until just before returning,
1527 to avoid unnecessary translation.
1529 2000-08-07 Jim Meyering <meyering@lucent.com>
1531 * addext.c, argmatch.c, argmatch.h, backupfile.h, bumpalloc.h,
1532 chown.c, diacrit.h, dirname.h, dup2.c, exclude.h, fileblocks.c,
1533 fnmatch.c, fnmatch.h, fsusage.c, fsusage.h, getdate.h,
1534 getgroups.c, gethostname.c, getopt.h, group-member.c,
1535 hard-locale.c, hash.h, isdir.c, lchown.c, linebuffer.c,
1536 linebuffer.h, long-options.h, malloc.c, md5.c, md5.h, memchr.c,
1537 memcmp.c, memcoll.c, memset.c, mktime.c, modechange.h, obstack.h,
1538 pathmax.h, realloc.c, rmdir.c, safe-read.c, save-cwd.c, stime.c,
1539 stpcpy.c, strcasecmp.c, strcspn.c, strdup.c, stripslash.c,
1540 strstr.c, strtod.c, strtol.c, strtoul.c, strtoull.c, strtoumax.c,
1541 utime.c, version-etc.h, xalloc.h, xstrdup.c, xstrtoumax.c,
1542 yesno.c: Back out Copyright date changes for each file with no change
1543 this year. This eases coordination with other programs using the same
1544 source code modules. From Paul Eggert.
1546 2000-08-03 Greg McGary <greg@mcgary.org>
1548 * regex.c (SET_HIGH_BOUND, MOVE_BUFFER_POINTER,
1549 ELSE_EXTEND_BUFFER_HIGH_BOUND): New macros.
1550 (EXTEND_BUFFER): Use them.
1552 2000-08-01 Jim Meyering <meyering@lucent.com>
1554 * dirname.c (ISSLASH): Define.
1555 (BACKSLASH_IS_PATH_SEPARATOR): Define.
1556 (dir_name) [BACKSLASH_IS_PATH_SEPARATOR]: Handle the case in which
1557 both `\' and `/' may be use as path separators.
1558 Based on a patch from Prashant TR.
1560 2000-07-31 Paul Eggert <eggert@twinsun.com>
1562 * quotearg.c (quotearg_n_options): Don't make the initial
1563 slot vector a constant, since it might get modified.
1565 2000-07-31 Jim Meyering <meyering@lucent.com>
1567 * xmalloc.c: Use `virtual memory exhausted', not `Memory exhausted'.
1568 * obstack.c (print_and_abort): Likewise.
1570 2000-07-30 Paul Eggert <eggert@twinsun.com>
1572 * quotearg.c (quotearg_n_options): Preallocate a slot 0
1573 buffer, so that the caller can always quote one small
1574 component of a "memory exhausted" message in slot 0.
1575 From a suggestion by Jim Meyering.
1577 2000-07-30 Jim Meyering <meyering@lucent.com>
1579 * makepath.c (make_path): Quote the other instance, too.
1581 * quotearg.c (N_STATIC_SLOTVECS): Define.
1582 (STATIC_BUF_SIZE): Define.
1583 (quotearg_n_options): Use only statically allocated storage when
1584 N < N_STATIC_SLOTVECS and the length of the quoted result is smaller
1585 than STATIC_BUF_SIZE.
1587 2000-07-29 Jim Meyering <meyering@lucent.com>
1589 * diacrit.c (diacrit_diac): Use __MSDOS__ in favor of MSDOS.
1590 * dirname.c (dir_name): Likewise.
1592 * basename.c (base_name): Use ISSLASH rather than comparing against `/'.
1594 * dirname.c (dir_name) [MSDOS]: Declare `lim' to be const.
1595 (dir_name): Assert that there are no trailing slashes.
1597 2000-07-18 Bruno Haible <haible@clisp.cons.org>
1599 * mbswidth.h (mbswidth): Add a flags argument.
1600 (mbswidth): New declaration.
1601 (MBSW_ACCEPT_INVALID, MBSW_ACCEPT_UNPRINTABLE): New macros.
1602 * mbswidth.c (mbswidth): Add a flags argument.
1603 (mbsnwidth): New function.
1605 2000-07-24 Jim Meyering <meyering@lucent.com>
1607 * mbswidth.c: Remove useless #else. From Bruno Haible.
1609 2000-07-23 Paul Eggert <eggert@twinsun.com>
1611 * mbswidth.c (_XOPEN_SOURCE):
1612 Don't define; this causes problems on Solaris 7.
1613 (wcwidth) [!HAVE_DECL_WCWIDTH]: Declare.
1615 2000-07-23 Paul Eggert <eggert@twinsun.com>
1618 Include <wchar.h> even if ! (HAVE_MBRTOWC && 1 < MB_LEN_MAX),
1619 so that mbstate_t is always defined.
1621 Do not inspect MB_LEN_MAX, since it's incorrectly defined to
1622 be 1 in at least one GCC installation, and this configuration
1623 error is likely to be common. Ignoring MB_LEN_MAX hurts
1624 performance on hosts that have mbrtowc but have only unibyte
1625 locales, but I assume these hosts are rare.
1627 2000-07-23 Paul Eggert <eggert@twinsun.com>
1629 * quotearg.c: Streamline by invoking multibyte code only if needed.
1630 <wchar.h>: Include only if HAVE_MBRTOWC && 1 < MB_LEN_MAX.
1631 (MB_CUR_MAX): Redefine to 1 if ! (HAVE_MBRTOWC && 1 < MB_LEN_MAX).
1632 (quotearg_buffer_restyled): If a unibyte locale, don't bother to
1633 invoke multibyte primitives.
1635 2000-07-23 Jim Meyering <meyering@lucent.com>
1637 * basename.c (base_name): Add an assertion.
1639 2000-07-15 Bruno Haible <clisp.cons.org>
1641 * quotearg.c: When the system forces us to redefine mbstate_t,
1642 shadow its mbsinit function.
1644 2000-07-16 Bruno Haible <haible@clisp.cons.org>
1646 * mbswidth.h: New file.
1647 * mbswidth.c: New file.
1648 * Makefile.am (libfetish_a_SOURCES): Add mbswidth.c.
1649 (noinst_HEADERS): Add mbswidth.h.
1651 2000-07-17 Bruno Haible <haible@clisp.cons.org>
1653 * config.charset: Add support for FreeBSD. Improve support for HP-UX
1656 2000-07-15 Jim Meyering <meyering@lucent.com>
1658 * makepath.c: Include quote.h.
1659 (make_path): Convert "`%s'" in format strings to "%s", and wrap each
1660 corresponding argument in a `quote (...)' call.
1661 Give better diagnostics.
1663 * Makefile.am (libfetish_a_SOURCES): Add quote.c.
1664 (noinst_HEADERS): Add quote.h.
1666 * quote.c (quote, quote_n): New file. Two functions taken verbatim
1667 from tar's src/misc.c.
1668 * quote.h: New file. Prototypes for same.
1670 2000-07-10 Paul Eggert <eggert@twinsun.com>
1672 From a suggestion by Bruno Haible.
1673 * quotearg.c (mbrtowc): Do not use HAVE_WCHAR_H in the definition.
1674 Use defined mbstate_t, not HAVE_MBSTATE_T_OBJECT,
1675 to decide whether to define the BeOS workaround macro;
1676 this adjusts to the change to AC_MBSTATE_T.
1678 2000-07-13 Paul Eggert <eggert@twinsun.com>
1680 * quotearg.h (enum quoting style): New enum clocale_quoting_style.
1682 * quotearg.c (quoting_style_args, quoting_style_vals,
1683 quotearg_buffer_restyled): Add support for
1684 clocale_quoting_style. Undo previous change to
1685 locale_quoting_style behavior, and undo the "{LEFT QUOTATION MARK}"
1686 and "{RIGHT QUOTATION MARK}" msgids.
1688 2000-07-05 Paul Eggert <eggert@twinsun.com>
1690 The old behavior of quoting `like this' doesn't look good with
1691 newer, ISO-style fonts. See:
1692 http://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html
1694 Instead, quote "like this" by default. Let the translator
1695 tailor the locale-specific quoting behavior by providing
1696 translations for {LEFT QUOTATION MARK} and {RIGHT QUOTATION MARK}.
1698 * quotearg.c (N_): New macro.
1699 (gettext_default): New function.
1700 (quotearg_buffer_restyled): Use
1701 gettext_default ("{LEFT QUOTATION MARK}", "\"") for left quote, and
1702 gettext_default ("{RIGHT QUOTATION MARK}", "\"") for right quote.
1704 2000-07-09 Jim Meyering <meyering@lucent.com>
1706 * Most files: Update copyright dates to include 2000.
1708 2000-07-08 Jim Meyering <meyering@lucent.com>
1710 * xgethostname.c (ENAMETOOLONG): Define to an unlikely value
1712 (xgethostname): Remove now-unnecessary #ifdef.
1713 Move declaration of `err' into loop where it's used.
1715 2000-07-05 Bruno Haible <haible@clisp.cons.org>
1717 * xgethostname.c (xgethostname): Protect against the SunOS5.5 bug
1718 by allocating a larger buffer. Test the gethostname return value for
1719 being >= 0, not == 0, for BeOS. Don't exhaust memory if gethostname
1720 returns an error and ENAMETOOLONG isn't defined.
1722 2000-07-05 Paul Eggert <eggert@twinsun.com>
1723 and Bruno Haible <haible@clisp.cons.org>
1725 * quotearg.c (mbrtowc): Declare returned type, since BeOS doesn't.
1727 2000-07-05 Bruno Haible <haible@clisp.cons.org>
1729 * quotearg.c (struct quoting_options): Simplify quote_these_too
1732 2000-07-03 Jim Meyering <meyering@lucent.com>
1734 * strndup.c: [!HAVE_DECL_STRNLEN]: Declare strnlen.
1735 Reported by Bruno Haible.
1737 2000-07-04 Jim Meyering <meyering@lucent.com>
1739 * quotearg.c: Make inclusion of <wchar.h> independent of whether
1740 HAVE_MBRTOWC is set. Required at least for irix-5.6, which
1743 2000-07-03 Paul Eggert <eggert@twinsun.com>
1744 and Bruno Haible <haible@clisp.cons.org>
1746 * quotearg.c (mbrtowc):
1747 Assign to *pwc, and return 1 only if result is nonzero.
1748 (iswprint): Use ISPRINT when substituting our own mbrtowc.
1750 2000-07-03 Jim Meyering <meyering@lucent.com>
1752 * readutmp.h: [HAVE_UTMPX_H]: Include <utmp.h> if HAVE_UTMP_H.
1753 This is necessary to get a definition of e.g., UTMP_FILE on HP-UX 10.20.
1756 2000-07-02 Jim Meyering <meyering@lucent.com>
1758 * quotearg.c (mbstate_t): Don't define here.
1760 2000-07-02 Jim Meyering <meyering@lucent.com>
1762 * nanosleep.c (SIGCONT): Define if not already defined.
1764 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1766 * mountlist.c: Use MOUNTED_FS_STAT_DEV instead of MOUNTED_NEXT_DEV,
1767 per change in ../m4/ls-mntd-fs.m4.
1768 (read_filesystem_list): Ignore symbolic links.
1770 2000-06-29 Jim Meyering <meyering@lucent.com>
1772 * same.c: Include <string.h> or <strings.h>, as appropriate,
1773 for declaration of strcmp.
1775 * long-options.c: Include <stdlib.h>, for declaration of exit.
1777 * mountlist.c (fsp_to_string) [HAVE_F_FSTYPENAME_IN_STATFS]:
1778 Avoid warning by casting result to `char *' to remove `const'.
1780 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1782 * Makefile.am (libfetish_a_SOURCES): Remove readutmp.c.
1784 2000-06-26 Paul Eggert <eggert@twinsun.com>
1786 savedir now sets errno on failure and invokes xmalloc to get memory.
1787 Fix a couple of other minor bugs while we're at it.
1789 * savedir.c (<unistd.h>): Do not include; there's no need.
1790 (NAMLEN): Remove macro.
1791 (malloc, realloc): Remove decls.
1793 ("xalloc.h"): Include.
1794 (NAME_SIZE_DEFAULT): New macro.
1795 (savedir): Use xmalloc / xrealloc to allocate memory.
1796 Use NAME_SIZE_DEFAULT if name_size is negative or overflows to zero.
1797 Skip "" directory entries.
1798 Use strlen to calculate directory entry length, since the old method
1799 is rarely used these days and isn't worth supporting.
1800 Don't use a pointer after freeing it.
1801 Check for integer overflow when calculating allocation size.
1802 Use memcpy to copy entries, instead of stpcpy.
1803 Set errno properly when returning NULL.
1804 Check for readdir error.
1806 2000-06-26 Jim Meyering <meyering@lucent.com>
1808 * posixtm.c [HAVE_STDLIB_H]: Include stdlib.h, for decl of abort.
1810 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1812 * getusershell.c (xmalloc, xrealloc): Remove functions.
1814 Don't include <stdlib.h>. Don't declare malloc, realloc.
1816 2000-06-23 Bruno Haible <haible@clisp.cons.org>
1818 * unicodeio.c (print_unicode_char): Work around ansi2knr deficiency.
1820 2000-06-24 Jim Meyering <meyering@lucent.com>
1822 * error.c [!HAVE_DECL_STRERROR_R]: Declare strerror_r.
1824 2000-06-21 Jim Meyering <meyering@lucent.com>
1826 * getpass.c: New file, from Bruno Haible. Required for BeOS.
1828 2000-06-19 Paul Eggert <eggert@twinsun.com>
1830 * quotearg.c: Include <wctype.h> after <wchar.h>, for Solaris 2.5.
1831 (mbrtowc, mbstate_t): Define substitutes if
1832 HAVE_MBRTOWC && HAVE_WCHAR_H && !HAVE_MBSTATE_T_OBJECT.
1833 (iswprint): Define to 1 if !defined iswprint && !HAVE_ISWPRINT,
1834 not if ! (HAVE_MBRTOWC && HAVE_WCHAR_H).
1836 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1838 * xgetcwd.c (xgetcwd): If the required pathname length is smaller
1839 than 1024, return a memory chunk of least possible size, instead
1840 of size PATH_MAX + 2. In the loop, increment the size proportionally.
1841 Use free/xmalloc instead of xrealloc to avoid copying for very long
1844 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1846 * canon-host.c (canon_host): Use malloc and memcpy to copy an
1847 address, not strdup. Include <stdlib.h> and don't declare free().
1849 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1851 * path-concat.c (path_concat): Don't access dir[-1] if dir is
1854 2000-06-21 Jim Meyering <meyering@lucent.com>
1856 * Makefile.am (libfetish_a_SOURCES): Add getstr.c.
1857 (noinst_HEADERS): Add getstr.h.
1859 * getline.c (getstr): Move into a separate file.
1860 * getstr.c (getstr): New file, extracted from getline.c, with
1861 the following changes: new parameter, delim2; both delim[12]
1862 parameters have type `int', not `char'. The latter would lose
1863 with 8-bit delimiters.
1864 * getstr.h: New file.
1866 2000-06-19 Jim Meyering <meyering@lucent.com>
1868 * getloadavg.c [HAVE_NLIST_H] (NLIST_STRUCT): Define.
1870 2000-06-18 Jim Meyering <meyering@lucent.com>
1872 * mkdir.c: Remove file, due mainly to copyright incompatibility.
1873 Besides, these days every porting target provides a mkdir function.
1875 * strnlen.c: Include memory.h, string.h, and/or strings.h as needed.
1876 (this snippet comes from src/system.h).
1878 2000-06-15 Paul Eggert <eggert@twinsun.com>
1880 * human.c (adjust_value): New function.
1881 (human_readable_inexact): Apply rounding style even when
1882 printing approximate values.
1884 2000-06-14 Paul Eggert <eggert@twinsun.com>
1886 * human.c (human_readable_inexact): Allow an input block
1887 size that is not a multiple of the output block size, and vice versa.
1888 Reported by Piergiorgio Sartor.
1890 2000-06-14 Paul Eggert <eggert@twinsun.com>
1892 * getdate.y (get_date): Apply relative times after time
1893 zone indicator, not before. Reported by Todd A. Jacobs.
1895 2000-06-13 Jim Meyering <meyering@lucent.com>
1897 * Makefile.am (all-local): Depend on lstat.c and stat.c.
1899 * xstat.in [!HAVE_DECL_FREE]: Declare free in lstat.c.
1901 2000-06-12 Paul Eggert <eggert@twinsun.com>
1903 * xstat.in: Include <stdlib.h> in lstat, to declare "free".
1905 2000-06-04 Paul Eggert <eggert@twinsun.com>
1907 * strnlen.c: Include <config.h> if HAVE_CONFIG_H.
1909 2000-06-04 Jim Meyering <meyering@lucent.com>
1911 * getugroups.c (getugroups): Cast -1 to gid_t, for systems like
1912 SunOS4.1.4 for which gid_t is an unsigned type.
1914 2000-06-03 Jim Meyering <meyering@lucent.com>
1916 * strnlen.c [!HAVE_DECL_MEMCHR]: Declare memchr.
1918 2000-05-26 Bruno Haible <haible@clisp.cons.org>
1920 * Makefile.am (install-exec-local): On systems with glibc-2.1 or
1921 newer, don't install charset.alias.
1922 * config.charset: Change the Linux/glibc rules so they become empty
1923 on glibc-2.1 or newer.
1925 2000-06-02 Jim Meyering <meyering@lucent.com>
1927 * mountlist.c: Back out last change. Instead, do this...
1928 * mountlist.c (read_filesystem_list) [MOUNTED_VMOUNT]: Set the me_dummy
1929 member using the same `ignore'-testing code.
1930 * mountlist.h (ME_DUMMY): Add `autofs' to the list of ignored
1934 2000-05-29 Jim Meyering <meyering@lucent.com>
1936 * mountlist.c (read_filesystem_list) [MOUNTED_VMOUNT]: Ignore mounts
1937 with the `ignore' attribute. Based on a patch from Mark D. Roth.
1939 2000-05-22 Jim Meyering <meyering@lucent.com>
1941 * makepath.c: Remove old, now-unnecessary `#ifdef __MSDOS__' block.
1943 2000-05-18 Jim Meyering <meyering@lucent.com>
1945 * hash.c (hash_rehash): Fix a nasty bug: copy the free entry list
1946 back, too, since it may have been modified by allocate_entry.
1947 (hash_delete): Rewrite to use neither the assignment operator
1948 nor the comma operator in an if-expression.
1950 2000-05-15 Paul Eggert <eggert@twinsun.com>
1953 <sys/stat.h>, <sys/types.h>, <unistd.h>, (STDOUT_FILENO):
1954 Remove; no longer needed.
1955 "quotearg.h": Add include.
1956 (file_name): Do not bother to explicitly initialize to NULL; it's less
1957 efficient on some hosts.
1958 (close_stdout_status): Remove test as to whether stdout was already
1959 closed; it breaks for the case "echo x | sort >&-".
1960 Quote file name colons.
1961 Do not assume that _("write error") lacks format strings.
1963 2000-05-15 Jim Meyering <meyering@lucent.com>
1965 * version-etc.c (version_etc_copyright): Update the copyright string
1966 used in all --version output.
1968 2000-05-14 Jim Meyering <meyering@lucent.com>
1970 * closeout.c (close_stdout_set_file_name): New function.
1971 (close_stdout_status): Use new file-scoped global.
1972 Return right away if fstat says the stdout file descriptor is invalid.
1973 * closeout.h (close_stdout_set_file_name): Declare.
1975 2000-05-10 Jim Meyering <meyering@lucent.com>
1977 * closeout.c [default_exit_status]: New file-scoped variable.
1978 (close_stdout_set_status): New function.
1979 * closeout.h (close_stdout_set_status): Declare.
1981 2000-05-08 Jim Meyering <meyering@lucent.com>
1983 * long-options.c: Don't include closeout.h.
1984 (parse_long_options): Don't call close_stdout for --version.
1986 2000-05-06 Jim Meyering <meyering@lucent.com>
1988 * strnlen.c: Undefine __strnlen and strnlen.
1989 [!weak_alias]: Define __strnlen to strnlen.
1991 * atexit.c: New file, from libiberty.
1993 2000-05-06 Jim Meyering <meyering@lucent.com>
1995 * closeout.c (close_stdout_status): Also check for errors on the
1998 2000-05-05 Bruno Haible <haible@clisp.cons.org>
2000 * localcharset.c (get_charset_aliases): Use malloc, realloc and memcpy
2001 instead of xmalloc, xrealloc, path_concat.
2002 (locale_charset): Treat empty environment variables as absent.
2003 (DIRECTORY_SEPARATOR, ISSLASH): New macros.
2005 2000-05-04 Jim Meyering <meyering@lucent.com>
2007 * getopt.c: Update from glibc.
2008 * obstack.c: Likewise.
2009 * obstack.h: Likewise.
2010 * regex.c: Likewise. NB: K&R compiler support is dropped for this file
2012 * regex.h: Likewise.
2013 * strndup.c: Likewise.
2014 * strnlen.c: New file, from glibc.
2016 2000-05-01 Jim Meyering <meyering@lucent.com>
2018 * full-write.c (full_write): Remove `FIXME' part of comment.
2020 2000-04-29 Jim Meyering <meyering@lucent.com>
2022 * path-concat.c: Declare strdup only if it's not defined.
2023 * canon-host.c: Likewise.
2025 2000-04-28 Jim Meyering <meyering@lucent.com>
2027 * rpmatch.c [HAVE_LIMITS_H]: Include limits.h before regex.h to avoid
2028 redefinition warning on some systems (HPUX). Otherwise, regex.h is
2029 included first, then limits.h is included by locale.h by libintl.h.
2030 From John David Anglin.
2032 2000-04-25 Jim Meyering <meyering@lucent.com>
2034 * makepath.c (S_IRWXUGO): Define.
2035 (make_path): Always perform explicit chmod if MODE specifies any
2036 of the `special' permission bits. Prompted by a bug report against
2037 install from Mate Wierdl and Joost van Baal.
2039 2000-04-18 Jim Meyering <meyering@lucent.com>
2043 * getpagesize.h [!getpagesize && HAVE_OS_H && B_PAGE_SIZE]: Define
2044 getpagesize. For BeOS. Based on a patch from Bruno Haible.
2046 2000-04-17 Jim Meyering <meyering@lucent.com>
2048 * strftime.c (my_strftime) [strftime]: Declare strftime here, since
2049 the definition of it to rpl_strftime also defined-away the system's
2052 2000-04-15 Jim Meyering <meyering@lucent.com>
2054 Use `C' to denote so-called `contiguous' files, the same way
2056 * filemode.c (S_ISCTG) [!S_ISCTG && S_IFCTG]: Define.
2057 (ftypelet): Use S_ISCTG.
2058 From Michael Deutschmann.
2060 2000-04-14 Jim Meyering <meyering@lucent.com>
2062 * strftime.c (my_strftime) [#ifdef strftime]: Declare strftime.
2064 2000-04-08 Jim Meyering <meyering@lucent.com>
2066 * Makefile.am (charset.alias): Use t-$@, not $@-t so the DOS 8.3
2067 names don't conflict. Reported by Eli Zaretskii.
2069 2000-03-28 Bruno Haible <haible@clisp.cons.org>
2071 * unicodeio.c (print_unicode_char): Avoid triggering Solaris iconv
2072 bug. Deal with the different error behavior of Irix iconv.
2074 2000-04-07 Jim Meyering <meyering@lucent.com>
2076 * putenv.c: Move inclusion of errno.h so it follows that of sys/types.h,
2077 to work around system header problems on AIX 3.2.5. From Bruno Haible.
2079 2000-04-05 Jim Meyering <meyering@lucent.com>
2081 Portability tweaks required for ultrix4.3.
2082 * readutmp.h [HAVE_UTMPX_H && !HAVE_DECL_GETUTENT]: Declare getutent.
2083 * readutmp.c: Include sys/types.h before sys/stat.h.
2084 * canon-host.c: Declare strdup.
2085 * path-concat.c: Likewise.
2086 From John David Anglin.
2088 2000-04-04 Jim Meyering <meyering@lucent.com>
2090 Be more DOS 8.3-friendly.
2091 * ref-add.sin: Renamed from ref-add.sed.in.
2092 * ref-del.sin: Renamed from ref-del.sed.in.
2093 * Makefile.am: Reflect renaming.
2094 Reported by Eli Zaretskii.
2096 Use a temporary file name that won't clash with `charset.alias'
2097 in the DOS 8.3 name space.
2098 * Makefile.am (charset_tmp): Define.
2099 (install-exec-local): Use $(charset_tmp) instead of $(charset_alias)-t.
2100 (uninstall-local): Likewise.
2101 Reported by Eli Zaretskii.
2103 2000-03-29 Paul Eggert <eggert@twinsun.com>
2105 * time/strftime.c (my_strftime): Make sure we call the system
2106 strftime, not ourselves, when invoking the underlying strftime.
2108 2000-03-24 Jim Meyering <meyering@lucent.com>
2110 * Makefile.am (EXTRA_DIST): Add ref-add.sed.in and ref-del.sed.in.
2111 (charset_alias): Define.
2112 (install-exec-local): Factor out common code.
2113 (uninstall-local): Split lines longer than 80.
2114 (ref-add.sed, ref-del.sed): Remove rules... (do the following instead)
2116 (.sed.in.sed): New rule. Don't redirect directly to $@.
2117 (CLEANFILES): Add ref-add.sed and ref-del.sed.
2119 2000-03-19 Bruno Haible <haible@clisp.cons.org>
2121 * config.charset: Output a line containing "Packages using this file".
2122 * ref-add.sed.in, ref-del.sed.in: New files.
2123 * Makefile.am (install-exec-local, uninstall-local, ref-add.sed,
2124 ref-del.sed): New rules.
2126 2000-03-17 Jim Meyering <meyering@lucent.com>
2128 * unicodeio.c (<string.h>): Include only #if HAVE_STRING_H.
2129 Otherwise, include <strings.h>
2131 2000-03-17 Bruno Haible <haible@clisp.cons.org>
2133 * unicodeio.c (utf8_wctomb): New function.
2134 (print_unicode_char): Pass the Unicode character to iconv in UTF-8
2135 format instead of in UCS-4 with platform dependent endianness.
2137 2000-03-07 Paul Eggert <eggert@twinsun.com>
2139 * savedir.c (savedir): Work even if directory size is
2140 negative; this can happen with some screwy NFS configurations.
2142 2000-03-06 Jim Meyering <meyering@lucent.com>
2144 * localcharset.c (get_charset_aliases): Don't try to free file_name
2145 if it's NULL (because we ran out of memory). From Bruno Haible.
2147 2000-03-05 Jim Meyering <meyering@lucent.com>
2149 * localcharset.c ("path-concat.h"): Include.
2150 (get_charset_aliases): Use path_concat instead of ANSI string
2153 * unicodeio.h (PARAMS): Define.
2154 Use it to guard prototype.
2156 2000-03-04 Jim Meyering <meyering@lucent.com>
2158 * Makefile.am (install-exec-local): Create $(libdir) before installing
2160 (uninstall-local): Uncomment this rule so `make distcheck' works
2163 * unicodeio.c (<errno.h>): Include it.
2164 (errno): Declare if not defined.
2166 * localcharset.c: Add Bruno's comment justifying use of volatile.
2168 * config.charset: New version, incorporating remarks from a linux
2169 i18n mailing list. From Bruno Haible.
2171 2000-03-02 Jim Meyering <meyering@lucent.com>
2173 * Makefile.am (EXTRA_DIST): Add config.charset.
2175 2000-03-01 Jim Meyering <meyering@lucent.com>
2177 * localcharset.c: Guard some #includes with `#if HAVE_...'.
2178 * unicodeio.c: Likewise.
2180 2000-02-02 Bruno Haible <haible@clisp.cons.org>
2182 * config.charset: New file.
2183 * localcharset.c: New file.
2184 * unicodeio.h, unicodeio.c: New files.
2185 * Makefile.am (DEFS): Add -DLIBDIR=...
2186 (libfetish_a_SOURCES): Add localcharset.c and unicodeio.c.
2187 (noinst_HEADERS): Add unicodeio.h.
2188 (all-local, install-exec-local, charset.alias): New targets.
2190 2000-02-28 Paul Eggert <eggert@twinsun.com>
2192 * quotearg.c (ALERT_CHAR): New macro.
2193 (quotearg_buffer_restyled): Use it.
2195 2000-02-27 Jim Meyering <meyering@lucent.com>
2197 * strtoumax.c: Fix typo in decl of strtoul: s/long long/long/.
2198 Guard declaration of strtoull also with `&& HAVE_UNSIGNED_LONG_LONG'.
2200 * backupfile.c: Guard inclusion of stdlib.h with `#if HAVE_STDLIB_H',
2201 not `#if STDC_HEADERS'.
2202 Declare malloc if needed.
2204 * backupfile.c: Use `#if !HAVE_DECL...' instead of `#ifndef HAVE_DECL..'
2205 now that autoconf always defines the HAVE_DECL_ symbols.
2206 * human.c: Likewise.
2208 * strtoumax.c: Likewise.
2210 * backupfile.c: Arrange for cpp to fail if the configure-time
2211 declaration check was not run.
2213 * human.c: Likewise.
2215 * strtoumax.c: Likewise.
2217 * userspec.c (parse_user_spec): If there is no `:' but there is a `.',
2218 then first look up the entire `.'-containing string as a login name.
2220 2000-02-18 Paul Eggert <eggert@twinsun.com>
2222 * getdate.y: Handle two-digit years with leading zeros correctly.
2223 (textint): New typedef.
2224 (parser_control): Member year changed from int to textint.
2226 (YYSTYPE): Removed; replaced by %union with int and textint members.
2227 (tDAY, tDAY_UNIT, tDAYZONE, tHOUR_UNIT, tID, tLOCAL_ZONE, tMERIDIAN,
2228 tMINUTE_UNIT, tMONTH, tMONTH_UNIT tSEC_UNIT, tSNUMBER, tUNUMBER,
2229 tYEAR_UNIT, tZONE, o_merid): Now of type <intval>.
2230 (tSNUMBER, tUNUMBER): Now of type <textintval>.
2231 (date, number, to_year): Use width of number in digits, not its value,
2232 to determine whether it's a 2-digit year, or a 2-digit time.
2233 (yylex): Store number of digits of numeric tokens.
2234 Reported by John Kendall.
2236 (parser_control): Changed from struct parser_control to typedef (for
2237 consistency). All uses changed.
2239 (tID): Removed; not used.
2240 (yylex): Return '?' for unknown identifiers, rather than (unused) tID.
2242 2000-02-14 Paul Eggert <eggert@twinsun.com>
2244 * getpagesize.h (getpagesize): Port to VMS for Alpha;
2245 adapted from changes to grep getpagesize.h by Martin P.J. Zinser.
2247 2000-02-12 Jim Meyering <meyering@lucent.com>
2249 * userspec.c (ISDIGIT): Define it.
2250 (isdigit): Remove definition.
2251 (is_number): Use ISDIGIT, not isdigit.
2252 <libintl.h>: Include.
2254 (parse_user_spec): Mark translatable strings.
2256 2000-02-10 Jim Meyering <meyering@lucent.com>
2258 With these changes, nanosleep.[ch] are finally enough like the other
2259 lib/* replacement files to compile on a few more losing systems.
2261 * nanosleep.h: Don't include config.h.
2262 Remove prototype from declaration of nanosleep.
2263 (PARAMS): Remove now-unneeded definition.
2264 * nanosleep.c: #undef nanosleep.
2265 (rpl_nanosleep): Rename from nanosleep.
2267 2000-02-03 Jim Meyering <meyering@lucent.com>
2269 * readutmp.c (read_utmp): Guard with `#ifdef UTMP_NAME_FUNCTION',
2270 rather than with `#if HAVE_UTMPNAME'.
2272 2000-02-01 Jim Meyering <meyering@lucent.com>
2274 * readutmp.h (UT_USER): Add parens. From Andreas Schwab.
2276 2000-01-31 Jim Meyering <meyering@lucent.com>
2278 * nanosleep.h (nanosleep): Guard declaration with
2279 `#if ! HAVE_DECL_NANOSLEEP'.
2280 Without this, OFS gets a redeclaration error for rpl_nanosleep, due to
2281 the declaration in that vendor's sys/timers.h.
2282 Reported by Christian Krackowizer.
2284 * quotearg.c (ISASCII): Add #undef and move definition to follow
2285 inclusion of wctype.h to work around solaris2.6 namespace pollution.
2286 (ISPRINT): Likewise.
2287 Reported by Tom Tromey.
2289 2000-01-30 Jim Meyering <meyering@lucent.com>
2291 * readutmp.c (extract_trimmed_name): Use UT_USER instead of hard-coding
2292 uses of ->ut_name. The latter doesn't work with new Linux header files
2293 where only utmpx.ut_user is declared.
2295 * readutmp.h (UT_USER): Define.
2297 2000-01-23 Jim Meyering <meyering@lucent.com>
2299 * Makefile.am (libfetish_a_SOURCES): Remove explicit mention of
2302 2000-01-22 Jim Meyering <meyering@lucent.com>
2304 * strtoumax.c: [! HAVE_DECL_STRTOUL]: Declare strtoul.
2305 [! HAVE_DECL_STRTOULL]: Declare strtoull.
2306 Required for some AIX systems. Reported by Christian Krackowizer.
2307 [TESTING] (main): New function.
2309 1997-10-17 Eli Zaretskii <eliz@is.elta.co.il>
2310 * dirname.c (dir_name): Support for DOS-style file names with drive
2313 * quotearg.c [HAVE_WCTYPE_H]: Include <wctype.h> for decl of iswprint.
2315 * strverscmp.c (ISDIGIT): Define.
2316 (strverscmp): Use ISDIGIT, not isdigit.
2318 2000-01-17 Paul Eggert <eggert@twinsun.com>
2320 * nanosleep.c (nanosleep):
2321 Don't use SA_INTERRUPT to decide whether to call sigaction, as
2322 POSIX.1 doesn't require SA_INTERRUPT and some systems
2323 (e.g. Solaris 7) don't define it. Use SA_NOCLDSTOP instead;
2324 it's been part of POSIX.1 since day 1 (in 1988).
2326 2000-01-17 Jim Meyering <meyering@lucent.com>
2328 * interlock: Remove unused file. Reported by François Pinard.
2330 2000-01-16 Paul Eggert <eggert@twinsun.com>
2332 * quotearg.c (quotearg_buffer_restyled): Do not quote
2333 alert, backslash, formfeed, and vertical tab unnecessarily in
2334 shell quoting style.
2337 version-control: never