1 2001-09-30 Jim Meyering <meyering@lucent.com>
3 * mountlist.c [MOUNTED_GETFSSTAT]:
4 Include <sys/ucred.h>, for Apple Darwin.
5 Include sys/mount.h and sys/fs_types.h only if available.
7 (read_filesystem_list): Use FS_TYPE.
9 2001-09-29 Paul Eggert <eggert@twinsun.com>
11 * lib/exclude.c (excluded_filename): 0 -> false, since it's
14 2001-09-28 Paul Eggert <eggert@twinsun.com>
16 Fix bug reported by Petter Reinholdtsen for HP-UX 10.20, which
17 #defines strtoimax. Also treat the other strto* functions
20 * xstrtol.c (strtol): Do not declare if HAVE_DECL_STRTOL.
21 (strtoul): Do not declare if HAVE_DECL_STRTOUL.
22 (strtoimax, strtoumax): Do not declare if already defined as a macro.
24 2001-09-26 Jim Meyering <meyering@lucent.com>
26 Most macros in unlocked-io.h had the wrong number of arguments.
27 * gen-uio: New script.
28 (USE_UNLOCKED_IO): Define to 1 if not already defined.
29 * unlocked-io.hin: Remove file.
30 * Makefile.am (unlocked-io.h): Rewrite to use a separate script,
31 rather than trying to embed it here.
32 (EXTRA_DIST): Add gen-uio. Remove unlocked-io.hin
33 Reported by Padraig Brady.
35 2001-09-25 Volker Borchert <bt@teknon.de>
37 * gettimeofday.c (rpl_gettimeofday): Declare local variable `result'.
39 2001-09-23 Jim Meyering <meyering@lucent.com>
41 * mountlist.c: Remove useless parentheses in #if directives.
42 (MOUNTED) [!defined MOUNTED]: Define to _PATH_MOUNTED, for when
43 the deprecated MOUNTED symbol is no longer defined in mntent.h.
45 2001-09-22 Jim Meyering <meyering@lucent.com>
47 * localcharset.c: Update from latest gettext.
48 * config.charset: Likewise.
50 2001-09-20 Jim Meyering <meyering@lucent.com>
52 * xstrtol.c (strtoimax): Guard declaration with
53 `#if !HAVE_DECL_STRTOIMAX', rather than just `#ifndef strtoimax'.
54 The latter fails because some systems (at least rs6000-ibm-aix4.3.3.0)
55 have their own, conflicting declaration of strtoimax in sys/inttypes.h.
56 (strtoumax): Likewise, for completeness (it wasn't necessary).
58 2001-09-06 Paul Eggert <eggert@twinsun.com>
60 * strtoimax.c (HAVE_LONG_LONG):
61 Redefine to HAVE_UNSIGNED_LONG_LONG if unsigned.
62 (strtoimax): Use sizeof (long), not sizeof strtol (ptr, endptr, base),
63 to work around bug in IBM C compiler.
65 2001-09-16 Jim Meyering <meyering@lucent.com>
69 2001-09-04 Paul Eggert <eggert@twinsun.com>
71 * xgetcwd.c: Revert some of the previous change; intead,
72 fix the HAVE_GETCWD_NULL code to behave more like the
73 !HAVE_GETCWD_NULL code used to.
76 (xgetcwd): Do not return NULL when memory is exhausted; instead,
79 2001-09-04 Paul Eggert <eggert@twinsun.com>
81 * xreadlink.c (xreadlink): Omit size_t* arg. All uses changed.
82 Use ssize_t, not int, to store result of readlink.
83 Check for ssize_t overflow as well as size_t overflow,
84 as POSIX says the result of readlink is implementation-defined
85 when ssize_t overflows.
86 Remove unnecessary cast to char*.
87 Use free+malloc instead of realloc, as the storage doesn't need
88 to be preserved and it's clearer and can be more efficient that way.
89 (SIZE_MAX, SSIZE_MAX): New macros, if <limits.h> doesn't declare.
90 * xreadlink.h (xreadlink): Update prototype.
92 2001-09-03 Paul Eggert <eggert@twinsun.com>
94 * exclude.c (fnmatch_no_wildcards): Fix confusion between
95 usage of FNM_CASEFOLD and FNM_LEADING_DIR. The bug was
96 spotted by Jim Meyering.
98 2001-09-03 Jim Meyering <meyering@lucent.com>
100 * xreadlink.c (xreadlink): Preserve errno around `free' during failure.
102 2001-09-03 Paul Eggert <eggert@twinsun.com>
104 * xgetcwd.c: Fix the !HAVE_GETCWD_NULL code to behave more
105 like the HAVE_GETCWD_NULL code.
106 Include pathmax.h if not HAVE_GETCWD.
107 Do not include xalloc.h.
108 (INITIAL_BUFFER_SIZE): New symbol.
109 Do not use xmalloc / xrealloc, since the caller is responsible for
110 handling errors. Preserve errno around `free' during failure.
111 Do not overrun buffer when using getwd.
113 2001-09-03 Paul Eggert <eggert@twinsun.com>
115 * xgetcwd.c (xgetcwd): Use HAVE_GETCWD_NULL, not (defined
116 __GLIBC__ && __GLIBC__ >= 2), to decide whether to use getcwd (NULL, 0).
118 2001-09-02 Jim Meyering <meyering@lucent.com>
120 * error.c: Update from GNU libc.
122 2001-09-01 Jim Meyering <meyering@lucent.com>
124 * xreadlink.c: New file.
125 * xreadlink.h: New file.
126 * Makefile.am (libfetish_a_SOURCES): Add xreadlink.c and xreadlink.h.
128 * regex.c (uintptr_t) [!_LIBC]: Define to private_uintptr_t, so it
129 doesn't conflict with sparc-sun-solaris2.7's definition in
130 /usr/include/sys/int_types.h.
132 * exclude.c: Use `""', not `<>' to #include non-system header files.
133 (fnmatch_no_wildcards): Rewrite not to use function names, strcasecmp
134 and strncasecmp as r-values. Unixware didn't have declarations.
136 2001-08-31 Jim Meyering <meyering@lucent.com>
138 * xgetcwd.c (xgetcwd): Reorganize to avoid some duplication.
139 Use an initial, malloc'd, buffer of length 128 rather than
140 a statically allocated one of length 1024.
142 2001-08-30 Paul Eggert <eggert@twinsun.com>
144 * lib/xgetcwd.c: Don't include pathmax.h.
145 Include stdlib.h and unistd.h if available.
147 (xmalloc, xstrdup, free): Remove decls.
148 (xgetcwd): Don't assume sizes fit in unsigned.
149 Check for overflow when computing sizes.
150 Simplify reallocation code.
152 2001-08-28 Paul Eggert <eggert@twinsun.com>
154 * Makefile.am (libfetish_a_SOURCES): Remove strtoxmax.c.
156 * strtoimax.c: Renamed from strtoxmax.c, removing the
159 Also, make the following further changes to make this file's
160 configuration more similar to that of strtol.c:
161 (UNSIGNED): Renamed from STRTOUXMAX_UNSIGNED. All uses changed.
162 (strtoumax, uintmax_t, strtoull, strtol): Remove.
163 (intmax_t, strtoimax, strtol, strtoll): New macros, if UNSIGNED.
164 (strtoimax): Renamed from strtoumax. All uses of unsigned values
165 changed to signed values.
167 And make the following changes as well:
168 Fix copyright notice, as 1999 was missing.
170 (strtoimax): Check sizes at compile-time, not run-time.
171 Prefer strtol to strtoll if both work.
172 (main): Remove; it was not that useful and was a pain to maintain.
174 * strtoumax.c: Include strtoimax.c, not strtouxmax.c.
176 2001-08-30 Paul Eggert <eggert@twinsun.com>
178 * savedir.c (savedir): Remove size parameter, as POSIX says that
179 a directory's st_size can have an arbitrary value, so the old
180 usage could waste an arbitrary amount of memory. All uses
182 * savedir.h: Update prototype.
184 2001-08-30 Paul Eggert <eggert@twinsun.com>
186 * xstrtol.c (strtoimax): New decl.
188 2001-08-28 Paul Eggert <eggert@twinsun.com>
190 * xstrtol.h: Add copyright notice.
191 (_DECLARE_XSTRTOL): Improve quality of diagnostic for
192 LONGINT_INVALID_SUFFIX_CHAR.
194 2001-08-30 Paul Eggert <eggert@twinsun.com>
196 * quotearg.c: BSD/OS 4.1 wchar.h requires FILE and struct
199 2001-08-30 Paul Eggert <eggert@twinsun.com>
201 * hash.c: Remove '2001' from copyright notice.
203 2001-08-30 Paul Eggert <eggert@twinsun.com>
205 * full-write.h: New file.
206 * Makefile.am (libfetish_a_SOURCES): Add full-write.h.
207 * full-write.c: Correct credits, as cccp.c no longer
208 exists and anyway it was so heavily changed from the old cccp
209 code as to be unrecognizable. Include full-write.h.
210 (full_write) Return size_t, with short writes meaning failure.
211 All callers changed. This fixes a bug with large buffers
213 * utime.c: Include full-write.h.
215 2001-08-30 Paul Eggert <eggert@twinsun.com>
217 Merge 'exclude' changes from tar 1.13.22.
218 This fixes one or two unlikely storage allocation overflow bugs,
219 but doesn't change user-visible behavior otherwise.
221 2001-08-30 Paul Eggert <eggert@twinsun.com>
223 * exclude.c (bool): Declare, perhaps by including stdbool.h.
224 (<sys/types.h>): Include only if HAVE_SYS_TYPES_H.
225 (<stdlib.h>, <string.h>, <strings.h>, <inttypes.h>, <stdint.h>):
226 Include if available.
227 (<xalloc.h>): Include
228 (SIZE_MAX): Define if <stdint.h> or <inttypes.h> doesn't.
229 (verify): New macro. Use it to verify that EXCLUDE macros do not
230 collide with FNM macros.
231 (struct patopts): New struct.
232 (struct exclude): Use it, as exclude patterns now come with options.
233 (new_exclude): Support above changes.
234 (new_exclude, add_exclude_file):
235 Initial size must now be a power of two to simplify overflow checking.
236 (free_exclude, fnmatch_no_wildcards): New function.
237 (excluded_filename): No longer requires options arg, as the options
238 are determined by add_exclude. Now returns bool, not int.
239 (excluded_filename, add_exclude):
240 Add support for the fancy new exclusion options.
241 (add_exclude, add_exclude_file): Now takes int options arg.
242 Check for arithmetic overflow when computing sizes.
243 (add_exclude_file): xrealloc might modify errno, so don't
244 realloc until after errno might be used.
246 * exclude.h (EXCLUDE_ANCHORED, EXCLUDE_INCLUDE,EXCLUDE_WILDCARDS):
248 (free_exclude): New decl.
249 (add_exclude, add_exclude_file): Now takes int options arg.
250 (excluded_filename): No longer requires options arg, as the options
251 are determined by add_exclude. Now returns bool, not int.
253 2001-08-30 Paul Eggert <eggert@twinsun.com>
255 * alloca.c (alloca): Arg is of type size_t, not unsigned.
257 2001-08-27 Jim Meyering <meyering@lucent.com>
259 * Makefile.am (libfetish_a_SOURCES): Add strtoxmax.c
261 * version-etc.c (N_): Remove definition.
262 Revert most of last change.
263 Instead, simply don't mark the `Copyright...' string for translation.
264 Based on advice from Paul Eggert.
266 * strtoxmax.c: Tweak comment.
268 2001-08-26 Jim Meyering <meyering@lucent.com>
270 * version-etc.c (version_etc_copyright_fmt): Replace literal year
271 of copyright with `%s' so translators don't get an untranslated
273 (COPYRIGHT_YEAR): Define.
274 (version_etc): Use fprintf rather than fputs.
275 Suggestion from Ulrich Drepper.
277 * Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
279 * strtoll.c: New file, from GNU libc.
280 * xstrtoimax.c: New file.
282 * xstrtol.h: Add xstrtoimax.
283 * strtoumax.c: New file. Simply include "strtoumax.c".
284 * strtoimax.c: New file. Likewise, but first define STRTOUXMAX_SIGNED.
286 * strtoumax.c: Factor to work both for unsigned and signed types, ...
287 * strtoxmax.c: ... then renamed to this.
289 2001-08-13 Paul Eggert <eggert@twinsun.com>
291 * Makefile.am (unlocked-io.h): Do not append "_unlocked" twice.
292 Port to Solaris 8, where 'sed' requires a space after the 'r'
293 command, and where sh dislikes "$/". Clean up the spacing a bit.
294 Redirect output to $tmp just once.
296 2001-08-12 Paul Eggert <eggert@sic.twinsun.com>
298 * addext.c (<errno.h>): Include.
299 (errno): Declare if not defined.
300 (addext): Work correctly when pathconf returns -1 and leaves
301 errno alone because there is no limit. Also, work even if
302 pathconf returns a value greater than SIZE_MAX.
304 2001-08-12 Jim Meyering <meyering@lucent.com>
306 * xgetcwd.c (xgetcwd) [defined __GLIBC__ && __GLIBC__ >= 2]:
307 Simply `return getcwd (NULL, 0);'.
308 [! (defined __GLIBC__ && __GLIBC__ >= 2)]:
309 Use 1300 as initial value for length, not PATH_MAX.
311 * pathmax.h: Clean up cpp syntax.
313 2001-08-12 Jim Meyering <meyering@lucent.com>
315 * gettimeofday.c: New file.
317 * Makefile.am (libfetish_a_SOURCES): Add gtod.h.
319 2001-08-04 Jim Meyering <meyering@lucent.com>
321 * error.h (__attribute__): Remove `|| __STRICT_ANSI__' from #if stmt,
322 to get in sync with glibc.
324 2001-08-03 Paul Eggert <eggert@twinsun.com>
326 The following changes are from gettext 0.10.39 as maintained by
329 * mbswidth.h (MBSW_REJECT_UNPRINTABLE, MBSW_REJECT_INVALID):
330 Renamed from MBSW_ACCEPT_UNPRINTABLE and MBSW_ACCEPT_INVALID
331 with inverted sense. All uses changed.
333 * mbswidth.c: Don't include <limits.h>.
334 Include <stdlib.h> and <string.h> unconditionally.
335 (iswcntrl, mbsinit, ISCNTRL): New macros.
336 (mbsnwidth): Use K&R style function declarations.
337 Don't bother checking for MB_LEN_MAX == 1, since the compiler
338 can optimize it when MB_CUR_MAX == 1.
339 The width of control characters is zero, not 1.
341 2001-07-15 Jim Meyering <meyering@lucent.com>
343 * Makefile.am (EXTRA_DIST): Add unlocked-io.hin.
344 (BUILT_SOURCES): Add unlocked-io.h.
345 (io_functions): Define.
346 (unlocked-io.h): New rule.
347 (DISTCLEANFILES): Add unlocked-io.h.
348 (all-local): Depend on unlocked-io.h, to ensure it is created.
350 * unlocked-io.hin: New file
352 * regex.c: Update from glibc.
354 2001-07-05 Jim Meyering <meyering@lucent.com>
356 * Makefile.am (noinst_HEADERS): Remove definition, per new automake
358 (libfetish_a_SOURCES): Put all .h files here instead.
359 Remove a thus-exposed (better checks in automake) duplicate and
360 two unnecessary .h files.
362 2001-06-11 Jim Meyering <meyering@lucent.com>
364 * regex.c: Update from GNU libc.
366 2001-05-27 Jim Meyering <meyering@lucent.com>
368 * readutmp.h (UT_TYPE): Define.
370 2001-05-24 Jim Meyering <meyering@lucent.com>
372 * argmatch.c: Include "quote.h".
373 (argmatch_invalid): Remove explicit `' quotes. Instead, use the
374 quote function. Reported by Göran Uddeborg.
376 2001-05-20 Alexandre Duret-Lutz <duret_g@epita.fr>
378 * dirname.c (dir_name): Compute append_dot using path, not newpath
379 which is not yet declared.
381 2001-05-11 Paul Eggert <eggert@twinsun.com>
383 * Makefile.am (libfetish_a_SOURCES):
384 Add strftime.c, since we now compile it on all hosts.
386 * strftime.c (my_strftime):
387 Define to nstrftime if emacs, but only if my_strftime is not defined.
388 (extra_args, extra_args_spec, extra_args_spec_iso): Rename from
389 ut_argument, ut_argument_spec, ut_argument_spec_iso, respectively.
390 Add one more extra argument: a nanoseconds value.
393 (my_strftime function): Add %N format.
394 (emacs_strftimeu): Renamed from emacs_strftime,
395 with extra ut argument.
397 2001-05-11 Paul Eggert <eggert@twinsun.com>
399 dirname code cleanup. base_name now behaves more compatibly
400 with POSIX basename when given file names that have trailing
401 slashes, and similarly for dir_name. Add new primitives
402 base_len and dir_len. Put the directory-name-related decls
405 * addext.c (ISSLASH, base_name): Remove; now in dirname.h.
406 * backupfile.c (base_name): Likewise.
407 * basename.c (FILESYSTEM_PREFIX_LEN, PARAMS, ISSLASH): Likewise.
408 * dirname.c (FILESYSTEM_PREFIX_LEN, ISSLASH): Likewise.
409 * makepath.c (strip_trailing_slashes): Likewise.
410 * path-concat.c (DIRECTORY_SEPARATOR, FILESYSTEM_PREFIX_LEN, ISSLASH):
412 * rename.c (strip_trailing_slashes): Likewise.
413 * same.c (base_name): Likewise.
414 * stripslash.c (ISSLASH): Likewise.
416 * addext.c: Include <dirname.h> after size_t is defined.
417 * backupfile.c: Likewise.
419 * addext.c (addext): Use base_len to trim redundant
420 trailing slashes instead of doing it ourselves.
421 But do not trim the last slash if it is not redundant.
423 * backupfile.c (find_backup_file_name,
424 max_backup_version): Use base_len instead of rolling it ourselves.
425 Handle the case of "" and (on DOS) "C:" correctly.
427 * basename.c: Do not include <stdio.h>, <assert.h>; no longer needed.
428 Include <string.h>, <dirname.h>.
429 (base_name): Allow file names ending in slashes, other than names
430 that are all slashes. In this case, return the basename followed
431 by the slashes. This is more general, and can be used in places
432 where the original base_name purposely had an assertion failure.
433 (base_len): New function.
435 * dirname.c: Include <string.h> instead of <stdlib.h>.
436 Do not include <assert.h>; no longer needed.
438 (memrchr): Remove decl.
439 (dir_name_r): Remove.
440 (dir_len): Renamed from dirlen. All callers changed.
441 Rewrite in terms of base_name, for simplicity and consistency.
442 (dir_name): Never return NULL. All callers changed.
443 Do not include <stdlib.h> in test program; no longer needed.
444 return 0; is fine for test program.
446 * dirname.h (DIRECTORY_SEPARATOR, ISSLASH, FILESYSTEM_PREFIX_LEN):
448 (base_name, base_len, dir_len, strip_trailing_slashes): New decls.
450 * path-concat.c (path_concat): Use base_len to compute
451 base length, not strlen; this means we cannot rely on memcpy
454 * same.c (STREQ): Remove.
455 (same_name): Handle the case where the basename ends in trailing '/'.
457 * stripslash.c (strip_trailing_slashes): Return nonzero if
458 a slash was stripped. Do not strip the last slash after a
461 2001-04-08 Jim Meyering <meyering@lucent.com>
463 * getdate.y (get_date): Set tm_isdst to -1 to ensure that it is
464 recomputed; that's necessary when the offset spans a DST transition.
465 Patch by David J. MacKenzie. Reported by Hon-Yin Kok.
467 2001-04-02 Jim Meyering <meyering@lucent.com>
469 * regex.h, regex.c: Update from GNU libc.
471 2001-03-19 Paul Eggert <eggert@twinsun.com>
473 * version-etc.c (version_etc_copyright): Update to 2001.
475 2001-03-16 Paul Eggert <eggert@twinsun.com>
477 * tempname.c (uint64_t): Define to uintmax_t if
478 not defined, and if UINT64_MAX is not defined.
479 Required at least for Vax Ultrix4.3, which doesn't define uint64_t.
480 Reported by John David Anglin.
482 2001-03-10 Bruno Haible <haible@clisp.cons.org>
484 * localcharset.c (locale_charset): Allow wildcard syntax. Also resolve
485 alias if codeset is empty.
486 * config.charset (BeOS): Use wildcard syntax.
488 2001-03-13 Jim Meyering <meyering@lucent.com>
490 * path-concat.c (path_concat) [FILESYSTEM_ACCEPTS_DRIVE_LETTER_PREFIX]:
491 Don't insert a backslash when concatenating e.g., `C:' and `foo'.
494 2001-03-06 Bruno Haible <haible@clisp.cons.org>
496 * localcharset.c (locale_charset): Don't use setlocale(LC_CTYPE,NULL).
498 * unicodeio.c (print_unicode_char): Simplify accordingly.
500 2001-03-06 Bruno Haible <haible@clisp.cons.org>
502 * config.charset: Update for FreeBSD 4.2 and OSF/1 5.1. Add
503 support for DOS/DJGPP.
505 2001-02-28 Paul Eggert <eggert@twinsun.com>
507 * Makefile.am (libfetish_a_SOURCES):
508 Add dup-safer.c, fopen-safer.c.
509 (noinst_HEADERS): Add stdio-safer.h, unistd-safer.h.
511 * dup-safer.c, fopen-safer.c, stdio-safer.h, unistd-safer.h: New files.
513 2001-02-25 Paul Eggert <eggert@twinsun.com>
515 The mkstemp replacement is taken from glibc 2.2.2, with some
516 portability fixes for use outside glibc, as follows:
518 * tempname.c (struct_stat64): New macro.
519 (direxists, __gen_tempname): Use it.
520 This avoids a portability problem with Solaris 8.
522 * tempname.c (<config.h>): Include if HAVE_CONFIG_H.
523 (<stddef.h>, <stdint.h>, <string.h>):
524 Include only if STDC_HEADERS || _LIBC.
525 (<fcntl.h>): Include only if HAVE_FCNTL_H || _LIBC.
526 (<unistd.h>): Include only if HAVE_UNISTD_H || _LIBC.
527 (<sys/time.h>): Include only if HAVE_SYS_TIME_H || _LIBC.
528 (__set_errno): Define this macro if <errno.h> doesn't.
529 (P_tmpdir, TMP_MAX, __GT_FILE, __GT_BIGFILE, __GT_DIR, __GT_NOCREATE):
530 Define these macros if <stdio.h> doesn't.
531 (S_ISDIR, S_IRUSR, S_IWUSR, S_IXUSR):
532 Define these macros if <sys/stat.h>
533 doesn't. Ignore <sys/stat.h> S_ISDIR if STAT_MACROS_BROKEN.
534 (stat64, __getpid, __gettimeofday, __mkdir, __open, __open64, lxstat64,
535 __xstat64): Define if not _LIBC.
536 (__secure_getenv): Define if ! (HAVE___SECURE_GETENV || _LIBC).
537 (__gen_tempname): Invoke gettimeofday only if
538 HAVE_GETTIMEOFDAY || _LIBC;
539 otherwise, fall back on plain "time".
540 Use macros like S_IRUSR | S_IWUSR rather than octal values like 0600.
542 * mkstemp.c (__GT_FILE): Define to zero if not defined.
544 * mkstemp.c, tempname.c: New files, taken from glibc 2.2.2.
546 2001-02-17 Jim Meyering <meyering@lucent.com>
548 * strtoul.c: Sync from GNU libc. Use double quotes, not <...>
549 around included file name.
551 * strnlen.c (__strnlen): Merge in a change from GNU libc.
553 * strftime.c: Update from GNU libc (the only changes were to comments).
555 2001-02-13 Bruno Haible <haible@clisp.cons.org>
557 * mbswidth.h (mbswidth): Also define as macro, to avoid prototype clash.
559 2001-02-17 Paul Eggert <eggert@twinsun.com>
561 * mbswidth.c, quotearg.c (mbrtowc, mbsinit):
562 Remove workaround macros for hosts that have mbrtowc but not
563 mbstate_t, as we now insist on proper declarations for both
564 before using mbrtowc.
566 2001-02-17 Jim Meyering <meyering@lucent.com>
568 * regex.c: Update from libc.
570 2001-02-16 Paul Eggert <eggert@twinsun.com>
572 * alloca.c (malloc): Undef before defining, since stdlib.h
573 may have defined it. Needed for Encore Umax-3.0.9.16b systems.
574 Reported by Mark Hounschell via Paul Eggert.
576 2001-01-30 Bruno Haible <haible@clisp.cons.org>
578 * config.charset: Update for FreeBSD 4.2.
580 2001-01-26 Jim Meyering <meyering@lucent.com>
582 * quotearg.c: Include stddef.h.
583 * quote.c: Include stddef.h.
584 Reported by Axel Kittenberger.
586 * xmalloc.c [HAVE_DONE_WORKING_MALLOC_CHECK]: Enclose error-evoking
587 line in double quotes so that it evokes a better diagnostic.
588 [HAVE_DONE_WORKING_REALLOC_CHECK]: Likewise.
589 Reported by Axel Kittenberger.
591 2001-01-15 Bruno Haible <haible@clisp.cons.org>
593 * unicodeio.c (print_unicode_char): Cast the second iconv() arg,
594 to avoid a warning. Add back 'const' to inptr.
596 2001-01-16 Jim Meyering <meyering@lucent.com>
598 * basename.c: Include <stdio.h>, needed by assert on SunOS4.
601 2001-01-14 Jim Meyering <meyering@lucent.com>
603 * rename.c: New file. From Volker Borchert.
604 Include stdlib.h, string.h or strings.h, and xalloc.h.
605 Use strip_trailing_slashes rather than open-coding it.
607 2001-01-03 Paul Eggert <eggert@twinsun.com>
609 * strftime.c: Sync with glibc time/strftime.c 1.81.
611 2001-01-03 Jim Meyering <meyering@lucent.com>
613 * unicodeio.c (print_unicode_char): Remove `const' from declaration of
614 local `inptr' to avoid warning with some system declarations of iconv.
616 2000-12-29 Paul Eggert <eggert@twinsun.com>
618 * modechange.c: Do not assume that mode_t uses the
619 traditional octal encoding. E.g. "chmod 1 FOO" should set
620 the other-execute bit of FOO even if S_IXOTH != 1.
622 (SUID, SGID, SVTX, RUSR, WUSR, XUSR, RGRP, WGRP, XGRP, ROTH,
623 WOTH, XOTH, ALLM): New macros.
624 (S_ISUID, S_ISGID, S_ISVTX, S_IRUSR, S_IWUSR, S_IXUSR,
625 S_IRGRP, S_IWGRP, S_IXGRP, S_IROTH, S_IWOTH, S_IXOTH):
627 (S_ISGID): Fix typo; it was defaulting to the same value as S_ISUID.
628 (S_IRWXU, S_IRWXG, S_IRWXO): Specify defaults in terms of the above.
630 No need to use uintmax_t; unsigned long is long enough.
631 Don't bother to get suffix since we don't use it.
633 2000-12-24 Jim Meyering <meyering@lucent.com>
635 * hash.c (is_prime): Return explicit boolean values.
636 (hash_get_first): Return NULL to appease Irix5.6's 89.
637 Reported by Nelson Beebe.
639 2000-10-31 Bruno Haible <haible@clisp.cons.org>
641 * localcharset.c (locale_charset): Add support for Win32.
643 2000-12-18 Paul Eggert <eggert@twinsun.com>
645 * physmem.h, physmem.c: New files.
647 * Makefile.am (libfetish_a_SOURCES): Add physmem.c.
648 (noinst_HEADERS): Add physmem.h.
650 * xstrtol.c (__xstrtol): Add undocumented suffixes 'g' and
651 't' for compatibility with Solaris 8 sort.
653 2000-12-18 Bruno Haible <haible@clisp.cons.org>
655 * config.charset: Add support for BeOS.
657 2000-12-16 Jim Meyering <meyering@lucent.com>
659 * getusershell.c [!SHELLS_FILE && __DJGPP__]: Define
660 SHELLS_FILE to a file name that's useful on djgpp systems.
662 (ADDITIONAL_DEFAULT_SHELLS): Define.
663 (default_shells): Prepend ADDITIONAL_DEFAULT_SHELLS.
664 Based mostly on a patch from Prashant TR.
666 2000-12-16 Jim Meyering <meyering@lucent.com>
668 This bug had a serious impact on chown: `chown N:M FILE' (for integer
669 N and M) would have treated it like `chown N:N FILE'.
671 * userspec.c (parse_user_spec): Fix typo: s/u/g/.
673 2000-10-31 Bruno Haible <haible@clisp.cons.org>
675 * config.charset: Add ISO-8859-3, BIG5HKSCS, GB18030, JOHAB, VISCII,
676 CP874, CP949, CP950, CP1250, CP1253, CP1254, CP1255, CP1256, CP1257
677 to the list of canonical encodings. Rename EUC-CN to GB2312.
679 2000-12-08 Andreas Schwab <schwab@suse.de>
681 * mbswidth.c (mbsnwidth): Don't loop endlessly when called with an
682 invalid mulitbyte sequence and with the MBSW_ACCEPT_INVALID flag set.
684 2000-12-07 Jim Meyering <meyering@lucent.com>
686 * stripslash.c (ISSLASH): Define.
687 (strip_trailing_slashes): Use ISSLASH rather than comparing against `/'.
690 * dirname.c (FILESYSTEM_PREFIX_LEN): Define.
691 (dir_name_r): Declare this function as static.
692 [BACKSLASH_IS_PATH_SEPARATOR]: Fix a bug that'd
693 manifest itself on a name containing a mix of slashes and
695 Make this function work with names starting with a DOS-style
696 drive letter and colon prefix.
697 (dir_name): Append `.' if necessary.
698 Based mostly on patches from Prashant TR and Eli Zaretskii.
700 * dirname.h (dir_name_r): Remove prototype.
702 2000-12-05 Jim Meyering <meyering@lucent.com>
704 * dirname.c (dir_name_r): Add `const' in a few local declarations.
706 2000-12-04 Jim Meyering <meyering@lucent.com>
708 * path-concat.c: [!HAVE_DECL_MALLOC]: Declare malloc.
709 Also include memory.h, stdlib.h, unistd.h if appropriate.
710 Reported by Andreas Jaeger (conflicting declaration of malloc).
712 2000-12-02 Jim Meyering <meyering@lucent.com>
714 * closeout.h: Make idempotent, to avoid some obscure warnings.
716 2000-12-01 Paul Eggert <eggert@twinsun.com>
718 * memrchr.c: Include <config.h> before any system include file.
720 2000-11-29 Paul Eggert <eggert@twinsun.com>
722 * dirname.c (dir_name_r): Fix typo: int -> size_t.
724 2000-11-26 Jim Meyering <meyering@lucent.com>
726 * memcoll.c: Include sys/types.h. From Werner Almesberger.
728 2000-11-22 Paul Eggert <eggert@twinsun.com>
730 * strftime.c (my_strftime): Do not invoke mbrlen with a
731 size of (size_t) -1; it's not portable.
733 2000-11-17 Akim Demaille <akim@epita.fr>
735 * obstack.h: Formatting changes.
736 (obstack_grow, obstack_grow0): Don't cast WHERE at all: that would
737 prevent type checking.
738 (obstack_ptr_grow, obstack_ptr_grow_fast): When assigning, don't
739 cast the value to (void *): assigning a `foo *' to a `void *'
741 (obstack_int_grow, obstack_int_grow_fast): Don't cast AINT to int.
743 2000-11-17 Jim Meyering <meyering@lucent.com>
745 * strstr.c: Update from GNU libc.
747 2000-11-16 Jim Meyering <meyering@lucent.com>
749 * strverscmp.c: Incorporate weak-alias-related changes from glibc.
751 2000-11-11 Jim Meyering <meyering@lucent.com>
753 * error.c: Add a couple #includes, merging from GNU libc version.
755 2000-11-10 Jim Meyering <meyering@lucent.com>
757 * obstack.h: Update from GNU libc.
758 * obstack.c: Likewise.
760 2000-11-06 Paul Eggert <eggert@twinsun.com>
762 * getusershell.c (setusershell): Use rewind rather than
763 fseek/fseeko, to avoid configuration hassles with fseeko.
764 Don't bother opening SHELLS_FILE if shellstream is NULL;
767 2000-11-05 Jim Meyering <meyering@lucent.com>
769 * makepath.h (make_dir): Declare.
770 * makepath.c (make_dir): Remove `static' attribute.
773 2000-11-04 Alexandre Duret-Lutz <duret_g@epita.fr>
775 * hash.c (hash_get_next): Fix a thinko: when ENTRY is the
776 last one in a bucket, advance to the next bucket.
778 2000-11-02 Vesselin Atanasov <vesselin@bgnet.bg>
780 * fnmatch.c: Do not comment out all the code if we are using
781 the GNU C library, because in some cases we are replacing buggy
782 code in the GNU C library itself.
784 2000-10-30 Paul Eggert <eggert@twinsun.com>
786 * error.h, getline.h, modechange.h:
787 Remove "2000" from Copyright line, as the file hasn't been
788 changed this year other than in the copyright notice.
790 * xalloc.h: Add "2000" to Copyright line, as this file
791 was changed this year.
793 2000-10-30 Paul Eggert <eggert@twinsun.com>
795 * fnmatch.c (FOLD): Do not assume that characters are unsigned.
796 (fnmatch): Fix some FNM_FILE_NAME and FNM_LEADING_DIR bugs,
797 e.g. fnmatch("d*/*1", "d/s/1", FNM_FILE_NAME) incorrectly yielded zero.
799 2000-10-29 Greg Louis <glouis@dynamicro.on.ca>
801 * regex.h (__restrict_arr): Move definition out of #ifndef block.
802 Required because egcs-2.91.66 (aka 1.1.2) defines __restrict, but
803 doesn't define __restrict_arr.
805 2000-10-29 Jim Meyering <meyering@lucent.com>
807 * xstat.in: Fix grammar in comment.
809 2000-10-28 Jim Meyering <meyering@lucent.com>
811 * memchr.c: Update from libc.
812 Adjust for portability:
813 [HAVE_STDLIB_H]: Include stdlib.h.
814 [HAVE_BP_SYM_H || _LIBC]: Guard inclusion of bp-sym.h.
816 [!weak_alias]: Define __memchr to memchr.
818 * regex.c: Update from libc.
820 * getopt1.c: Likewise.
821 * memcmp.c: Likewise.
823 * getusershell.c (setusershell) [HAVE_FSEEKO]: Use fseeko.
824 Avoid using fseek, when possible -- it's broken by design.
825 Patch by Ulrich Drepper.
827 2000-10-26 Jim Meyering <meyering@lucent.com>
829 * strftime.c: Update from libc.
831 2000-10-25 Jim Meyering <meyering@lucent.com>
833 * obstack.c: Update from libc.
835 2000-10-23 Jim Meyering <meyering@lucent.com>
837 * hard-locale.c (hard_locale): Revert last change -- it was simply
838 wrong. That set_locale call must not have any side effects.
841 2000-10-22 Jim Meyering <meyering@lucent.com>
843 * md5.c (md5_process_block) [OP]: Use `rol', not CYCLIC.
844 [CYCLIC]: Remove now-unused definition.
846 * save-cwd.c (O_DIRECTORY): Define, if needed.
847 (save_cwd) [HAVE_FCHDIR]: Use O_DIRECTORY when opening ".".
848 Suggestion from Ulrich Drepper.
850 2000-10-21 Jim Meyering <meyering@lucent.com>
852 * dirname.c (dir_name_r): New function, factored out of dir_name.
853 (dir_name): Use dir_name_r.
854 * dirname.h (dir_name_r): Declare it.
856 2000-10-21 Jim Meyering <meyering@lucent.com>
858 * dirname.c (memrchr): Declare if necessary.
859 (dir_name): Remove the restriction that there be no
860 trailing slashes. Now, this code skips past them, effectively
862 [TEST_DIRNAME] (main): New unit tests.
864 * memrchr.c: New file from GNU libc.
865 Undef __memrchr, too.
866 [!weak_alias]: Define __memrchr to memrchr.
867 Guard weak_alias use with `#ifdef weak_alias'.
869 2000-10-17 Jim Meyering <meyering@lucent.com>
871 * quote.h (PARAMS): Define and use.
872 Reported by Akim Demaille.
874 * getopt.c: Update from libc.
876 2000-10-16 Jim Meyering <meyering@lucent.com>
878 * hard-locale.c (hard_locale): Use "", not 0 as 2nd arg to setlocale.
881 2000-09-25 Jim Meyering <meyering@lucent.com>
883 * md5.h (rol): Define (from GnuPG).
885 * sha.c: Give credit (GnuPG) where due.
886 (M): Use rol rather than open-coding it.
889 2000-09-21 Jim Meyering <meyering@lucent.com>
891 * userspec.c (parse_user_spec): Remove debugging printf I'd added.
892 Reported by Michael Stone.
894 2000-09-20 Jim Meyering <meyering@lucent.com>
896 * Makefile.am (libfetish_a_SOURCES): Add sha.c.
897 (noinst_HEADERS): Add sha.h.
898 Based on code from Scott G. Miller and from GnuPG.
900 2000-09-15 Jim Meyering <meyering@lucent.com>
902 * regex.c: Update from libc.
904 2000-09-10 Jim Meyering <meyering@lucent.com>
906 * getopt.c (_getopt_internal): Update from glibc.
908 2000-09-09 Jim Meyering <meyering@lucent.com>
910 * quotearg.c: Rename ISASCII to IN_CTYPE_DOMAIN, so people don't
911 think it should be used as a general replacement for isascii.
912 * fnmatch.c: Likewise.
913 * mbswidth.c: Likewise
917 * userspec.c: Include sys/param.h and limits.h.
919 (CHAR_BIT, TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM): Define.
920 (UID_T_MAX, GID_T_MAX, MAXUID, MAXGID): Define.
921 (parse_user_spec): Use xstrtoul, not atoi when converting numeric
922 UID, GID. Check range.
924 2000-09-06 Jim Meyering <meyering@lucent.com>
926 * getopt.c (_getopt_internal): Update from glibc.
928 2000-08-30 Jim Meyering <meyering@lucent.com>
930 * strftime.c: Merge in changes from GNU libc.
932 2000-08-26 Jim Meyering <meyering@lucent.com>
934 * closeout.c: Include "__fpending.h".
935 (close_stdout_status): Return right away if there's nothing to flush.
937 * Makefile.am (noinst_HEADERS): Add __fpending.h.
938 * __fpending.c: New file.
939 * __fpending.h: New file.
941 2000-08-07 Paul Eggert <eggert@twinsun.com>
943 Standardize on "memory exhausted" instead of "Memory exhausted"
944 or "virtual memory exhausted".
945 * obstack.c (print_and_abort): Use "memory exhausted", not
946 "virtual memory exhausted".
947 * same.c (same_name): Invoke xalloc_die instead of printing
949 * userspec.c (parse_user_spec): Likewise.
950 * bumpalloc.h: comment fix
951 * same.c, userspec.c: Include xalloc.h.
953 * xalloc.h (xalloc_msg_memory_exhausted): Now char const[],
954 not char *const and pointing to a constant array.
955 * xmalloc.c (xalloc_msg_memory_exhausted): Likewise.
956 (xrealloc): Comment fix.
958 * userspec.c (parse_user_spec):
959 Don't translate a message until just before returning,
960 to avoid unnecessary translation.
962 2000-08-07 Jim Meyering <meyering@lucent.com>
964 * addext.c, argmatch.c, argmatch.h, backupfile.h, bumpalloc.h,
965 chown.c, diacrit.h, dirname.h, dup2.c, exclude.h, fileblocks.c,
966 fnmatch.c, fnmatch.h, fsusage.c, fsusage.h, getdate.h,
967 getgroups.c, gethostname.c, getopt.h, group-member.c,
968 hard-locale.c, hash.h, isdir.c, lchown.c, linebuffer.c,
969 linebuffer.h, long-options.h, malloc.c, md5.c, md5.h, memchr.c,
970 memcmp.c, memcoll.c, memset.c, mktime.c, modechange.h, obstack.h,
971 pathmax.h, realloc.c, rmdir.c, safe-read.c, save-cwd.c, stime.c,
972 stpcpy.c, strcasecmp.c, strcspn.c, strdup.c, stripslash.c,
973 strstr.c, strtod.c, strtol.c, strtoul.c, strtoull.c, strtoumax.c,
974 utime.c, version-etc.h, xalloc.h, xstrdup.c, xstrtoumax.c,
975 yesno.c: Back out Copyright date changes for each file with no change
976 this year. This eases coordination with other programs using the same
977 source code modules. From Paul Eggert.
979 2000-08-03 Greg McGary <greg@mcgary.org>
981 * regex.c (SET_HIGH_BOUND, MOVE_BUFFER_POINTER,
982 ELSE_EXTEND_BUFFER_HIGH_BOUND): New macros.
983 (EXTEND_BUFFER): Use them.
985 2000-08-01 Jim Meyering <meyering@lucent.com>
987 * dirname.c (ISSLASH): Define.
988 (BACKSLASH_IS_PATH_SEPARATOR): Define.
989 (dir_name) [BACKSLASH_IS_PATH_SEPARATOR]: Handle the case in which
990 both `\' and `/' may be use as path separators.
991 Based on a patch from Prashant TR.
993 2000-07-31 Paul Eggert <eggert@twinsun.com>
995 * quotearg.c (quotearg_n_options): Don't make the initial
996 slot vector a constant, since it might get modified.
998 2000-07-31 Jim Meyering <meyering@lucent.com>
1000 * xmalloc.c: Use `virtual memory exhausted', not `Memory exhausted'.
1001 * obstack.c (print_and_abort): Likewise.
1003 2000-07-30 Paul Eggert <eggert@twinsun.com>
1005 * quotearg.c (quotearg_n_options): Preallocate a slot 0
1006 buffer, so that the caller can always quote one small
1007 component of a "memory exhausted" message in slot 0.
1008 From a suggestion by Jim Meyering.
1010 2000-07-30 Jim Meyering <meyering@lucent.com>
1012 * makepath.c (make_path): Quote the other instance, too.
1014 * quotearg.c (N_STATIC_SLOTVECS): Define.
1015 (STATIC_BUF_SIZE): Define.
1016 (quotearg_n_options): Use only statically allocated storage when
1017 N < N_STATIC_SLOTVECS and the length of the quoted result is smaller
1018 than STATIC_BUF_SIZE.
1020 2000-07-29 Jim Meyering <meyering@lucent.com>
1022 * diacrit.c (diacrit_diac): Use __MSDOS__ in favor of MSDOS.
1023 * dirname.c (dir_name): Likewise.
1025 * basename.c (base_name): Use ISSLASH rather than comparing against `/'.
1027 * dirname.c (dir_name) [MSDOS]: Declare `lim' to be const.
1028 (dir_name): Assert that there are no trailing slashes.
1030 2000-07-18 Bruno Haible <haible@clisp.cons.org>
1032 * mbswidth.h (mbswidth): Add a flags argument.
1033 (mbswidth): New declaration.
1034 (MBSW_ACCEPT_INVALID, MBSW_ACCEPT_UNPRINTABLE): New macros.
1035 * mbswidth.c (mbswidth): Add a flags argument.
1036 (mbsnwidth): New function.
1038 2000-07-24 Jim Meyering <meyering@lucent.com>
1040 * mbswidth.c: Remove useless #else. From Bruno Haible.
1042 2000-07-23 Paul Eggert <eggert@twinsun.com>
1044 * mbswidth.c (_XOPEN_SOURCE):
1045 Don't define; this causes problems on Solaris 7.
1046 (wcwidth) [!HAVE_DECL_WCWIDTH]: Declare.
1048 2000-07-23 Paul Eggert <eggert@twinsun.com>
1051 Include <wchar.h> even if ! (HAVE_MBRTOWC && 1 < MB_LEN_MAX),
1052 so that mbstate_t is always defined.
1054 Do not inspect MB_LEN_MAX, since it's incorrectly defined to
1055 be 1 in at least one GCC installation, and this configuration
1056 error is likely to be common. Ignoring MB_LEN_MAX hurts
1057 performance on hosts that have mbrtowc but have only unibyte
1058 locales, but I assume these hosts are rare.
1060 2000-07-23 Paul Eggert <eggert@twinsun.com>
1062 * quotearg.c: Streamline by invoking multibyte code only if needed.
1063 <wchar.h>: Include only if HAVE_MBRTOWC && 1 < MB_LEN_MAX.
1064 (MB_CUR_MAX): Redefine to 1 if ! (HAVE_MBRTOWC && 1 < MB_LEN_MAX).
1065 (quotearg_buffer_restyled): If a unibyte locale, don't bother to
1066 invoke multibyte primitives.
1068 2000-07-23 Jim Meyering <meyering@lucent.com>
1070 * basename.c (base_name): Add an assertion.
1072 2000-07-15 Bruno Haible <clisp.cons.org>
1074 * quotearg.c: When the system forces us to redefine mbstate_t,
1075 shadow its mbsinit function.
1077 2000-07-16 Bruno Haible <haible@clisp.cons.org>
1079 * mbswidth.h: New file.
1080 * mbswidth.c: New file.
1081 * Makefile.am (libfetish_a_SOURCES): Add mbswidth.c.
1082 (noinst_HEADERS): Add mbswidth.h.
1084 2000-07-17 Bruno Haible <haible@clisp.cons.org>
1086 * config.charset: Add support for FreeBSD. Improve support for HP-UX
1089 2000-07-15 Jim Meyering <meyering@lucent.com>
1091 * makepath.c: Include quote.h.
1092 (make_path): Convert "`%s'" in format strings to "%s", and wrap each
1093 corresponding argument in a `quote (...)' call.
1094 Give better diagnostics.
1096 * Makefile.am (libfetish_a_SOURCES): Add quote.c.
1097 (noinst_HEADERS): Add quote.h.
1099 * quote.c (quote, quote_n): New file. Two functions taken verbatim
1100 from tar's src/misc.c.
1101 * quote.h: New file. Prototypes for same.
1103 2000-07-10 Paul Eggert <eggert@twinsun.com>
1105 From a suggestion by Bruno Haible.
1106 * quotearg.c (mbrtowc): Do not use HAVE_WCHAR_H in the definition.
1107 Use defined mbstate_t, not HAVE_MBSTATE_T_OBJECT,
1108 to decide whether to define the BeOS workaround macro;
1109 this adjusts to the change to AC_MBSTATE_T.
1111 2000-07-13 Paul Eggert <eggert@twinsun.com>
1113 * quotearg.h (enum quoting style): New enum clocale_quoting_style.
1115 * quotearg.c (quoting_style_args, quoting_style_vals,
1116 quotearg_buffer_restyled): Add support for
1117 clocale_quoting_style. Undo previous change to
1118 locale_quoting_style behavior, and undo the "{LEFT QUOTATION MARK}"
1119 and "{RIGHT QUOTATION MARK}" msgids.
1121 2000-07-05 Paul Eggert <eggert@twinsun.com>
1123 The old behavior of quoting `like this' doesn't look good with
1124 newer, ISO-style fonts. See:
1125 http://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html
1127 Instead, quote "like this" by default. Let the translator
1128 tailor the locale-specific quoting behavior by providing
1129 translations for {LEFT QUOTATION MARK} and {RIGHT QUOTATION MARK}.
1131 * quotearg.c (N_): New macro.
1132 (gettext_default): New function.
1133 (quotearg_buffer_restyled): Use
1134 gettext_default ("{LEFT QUOTATION MARK}", "\"") for left quote, and
1135 gettext_default ("{RIGHT QUOTATION MARK}", "\"") for right quote.
1137 2000-07-09 Jim Meyering <meyering@lucent.com>
1139 * Most files: Update copyright dates to include 2000.
1141 2000-07-08 Jim Meyering <meyering@lucent.com>
1143 * xgethostname.c (ENAMETOOLONG): Define to an unlikely value
1145 (xgethostname): Remove now-unnecessary #ifdef.
1146 Move declaration of `err' into loop where it's used.
1148 2000-07-05 Bruno Haible <haible@clisp.cons.org>
1150 * xgethostname.c (xgethostname): Protect against the SunOS5.5 bug
1151 by allocating a larger buffer. Test the gethostname return value for
1152 being >= 0, not == 0, for BeOS. Don't exhaust memory if gethostname
1153 returns an error and ENAMETOOLONG isn't defined.
1155 2000-07-05 Paul Eggert <eggert@twinsun.com>
1156 and Bruno Haible <haible@clisp.cons.org>
1158 * quotearg.c (mbrtowc): Declare returned type, since BeOS doesn't.
1160 2000-07-05 Bruno Haible <haible@clisp.cons.org>
1162 * quotearg.c (struct quoting_options): Simplify quote_these_too
1165 2000-07-03 Jim Meyering <meyering@lucent.com>
1167 * strndup.c: [!HAVE_DECL_STRNLEN]: Declare strnlen.
1168 Reported by Bruno Haible.
1170 2000-07-04 Jim Meyering <meyering@lucent.com>
1172 * quotearg.c: Make inclusion of <wchar.h> independent of whether
1173 HAVE_MBRTOWC is set. Required at least for irix-5.6, which
1176 2000-07-03 Paul Eggert <eggert@twinsun.com>
1177 and Bruno Haible <haible@clisp.cons.org>
1179 * quotearg.c (mbrtowc):
1180 Assign to *pwc, and return 1 only if result is nonzero.
1181 (iswprint): Use ISPRINT when substituting our own mbrtowc.
1183 2000-07-03 Jim Meyering <meyering@lucent.com>
1185 * readutmp.h: [HAVE_UTMPX_H]: Include <utmp.h> if HAVE_UTMP_H.
1186 This is necessary to get a definition of e.g., UTMP_FILE on HP-UX 10.20.
1189 2000-07-02 Jim Meyering <meyering@lucent.com>
1191 * quotearg.c (mbstate_t): Don't define here.
1193 2000-07-02 Jim Meyering <meyering@lucent.com>
1195 * nanosleep.c (SIGCONT): Define if not already defined.
1197 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1199 * mountlist.c: Use MOUNTED_FS_STAT_DEV instead of MOUNTED_NEXT_DEV,
1200 per change in ../m4/ls-mntd-fs.m4.
1201 (read_filesystem_list): Ignore symbolic links.
1203 2000-06-29 Jim Meyering <meyering@lucent.com>
1205 * same.c: Include <string.h> or <strings.h>, as appropriate,
1206 for declaration of strcmp.
1208 * long-options.c: Include <stdlib.h>, for declaration of exit.
1210 * mountlist.c (fsp_to_string) [HAVE_F_FSTYPENAME_IN_STATFS]:
1211 Avoid warning by casting result to `char *' to remove `const'.
1213 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1215 * Makefile.am (libfetish_a_SOURCES): Remove readutmp.c.
1217 2000-06-26 Paul Eggert <eggert@twinsun.com>
1219 savedir now sets errno on failure and invokes xmalloc to get memory.
1220 Fix a couple of other minor bugs while we're at it.
1222 * savedir.c (<unistd.h>): Do not include; there's no need.
1223 (NAMLEN): Remove macro.
1224 (malloc, realloc): Remove decls.
1226 ("xalloc.h"): Include.
1227 (NAME_SIZE_DEFAULT): New macro.
1228 (savedir): Use xmalloc / xrealloc to allocate memory.
1229 Use NAME_SIZE_DEFAULT if name_size is negative or overflows to zero.
1230 Skip "" directory entries.
1231 Use strlen to calculate directory entry length, since the old method
1232 is rarely used these days and isn't worth supporting.
1233 Don't use a pointer after freeing it.
1234 Check for integer overflow when calculating allocation size.
1235 Use memcpy to copy entries, instead of stpcpy.
1236 Set errno properly when returning NULL.
1237 Check for readdir error.
1239 2000-06-26 Jim Meyering <meyering@lucent.com>
1241 * posixtm.c [HAVE_STDLIB_H]: Include stdlib.h, for decl of abort.
1243 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1245 * getusershell.c (xmalloc, xrealloc): Remove functions.
1247 Don't include <stdlib.h>. Don't declare malloc, realloc.
1249 2000-06-23 Bruno Haible <haible@clisp.cons.org>
1251 * unicodeio.c (print_unicode_char): Work around ansi2knr deficiency.
1253 2000-06-24 Jim Meyering <meyering@lucent.com>
1255 * error.c [!HAVE_DECL_STRERROR_R]: Declare strerror_r.
1257 2000-06-21 Jim Meyering <meyering@lucent.com>
1259 * getpass.c: New file, from Bruno Haible. Required for BeOS.
1261 2000-06-19 Paul Eggert <eggert@twinsun.com>
1263 * quotearg.c: Include <wctype.h> after <wchar.h>, for Solaris 2.5.
1264 (mbrtowc, mbstate_t): Define substitutes if
1265 HAVE_MBRTOWC && HAVE_WCHAR_H && !HAVE_MBSTATE_T_OBJECT.
1266 (iswprint): Define to 1 if !defined iswprint && !HAVE_ISWPRINT,
1267 not if ! (HAVE_MBRTOWC && HAVE_WCHAR_H).
1269 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1271 * xgetcwd.c (xgetcwd): If the required pathname length is smaller
1272 than 1024, return a memory chunk of least possible size, instead
1273 of size PATH_MAX + 2. In the loop, increment the size proportionally.
1274 Use free/xmalloc instead of xrealloc to avoid copying for very long
1277 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1279 * canon-host.c (canon_host): Use malloc and memcpy to copy an
1280 address, not strdup. Include <stdlib.h> and don't declare free().
1282 2000-06-17 Bruno Haible <haible@clisp.cons.org>
1284 * path-concat.c (path_concat): Don't access dir[-1] if dir is
1287 2000-06-21 Jim Meyering <meyering@lucent.com>
1289 * Makefile.am (libfetish_a_SOURCES): Add getstr.c.
1290 (noinst_HEADERS): Add getstr.h.
1292 * getline.c (getstr): Move into a separate file.
1293 * getstr.c (getstr): New file, extracted from getline.c, with
1294 the following changes: new parameter, delim2; both delim[12]
1295 parameters have type `int', not `char'. The latter would lose
1296 with 8-bit delimiters.
1297 * getstr.h: New file.
1299 2000-06-19 Jim Meyering <meyering@lucent.com>
1301 * getloadavg.c [HAVE_NLIST_H] (NLIST_STRUCT): Define.
1303 2000-06-18 Jim Meyering <meyering@lucent.com>
1305 * mkdir.c: Remove file, due mainly to copyright incompatibility.
1306 Besides, these days every porting target provides a mkdir function.
1308 * strnlen.c: Include memory.h, string.h, and/or strings.h as needed.
1309 (this snippet comes from src/system.h).
1311 2000-06-15 Paul Eggert <eggert@twinsun.com>
1313 * human.c (adjust_value): New function.
1314 (human_readable_inexact): Apply rounding style even when
1315 printing approximate values.
1317 2000-06-14 Paul Eggert <eggert@twinsun.com>
1319 * human.c (human_readable_inexact): Allow an input block
1320 size that is not a multiple of the output block size, and vice versa.
1321 Reported by Piergiorgio Sartor.
1323 2000-06-14 Paul Eggert <eggert@twinsun.com>
1325 * getdate.y (get_date): Apply relative times after time
1326 zone indicator, not before. Reported by Todd A. Jacobs.
1328 2000-06-13 Jim Meyering <meyering@lucent.com>
1330 * Makefile.am (all-local): Depend on lstat.c and stat.c.
1332 * xstat.in [!HAVE_DECL_FREE]: Declare free in lstat.c.
1334 2000-06-12 Paul Eggert <eggert@twinsun.com>
1336 * xstat.in: Include <stdlib.h> in lstat, to declare "free".
1338 2000-06-04 Paul Eggert <eggert@twinsun.com>
1340 * strnlen.c: Include <config.h> if HAVE_CONFIG_H.
1342 2000-06-04 Jim Meyering <meyering@lucent.com>
1344 * getugroups.c (getugroups): Cast -1 to gid_t, for systems like
1345 SunOS4.1.4 for which gid_t is an unsigned type.
1347 2000-06-03 Jim Meyering <meyering@lucent.com>
1349 * strnlen.c [!HAVE_DECL_MEMCHR]: Declare memchr.
1351 2000-05-26 Bruno Haible <haible@clisp.cons.org>
1353 * Makefile.am (install-exec-local): On systems with glibc-2.1 or
1354 newer, don't install charset.alias.
1355 * config.charset: Change the Linux/glibc rules so they become empty
1356 on glibc-2.1 or newer.
1358 2000-06-02 Jim Meyering <meyering@lucent.com>
1360 * mountlist.c: Back out last change. Instead, do this...
1361 * mountlist.c (read_filesystem_list) [MOUNTED_VMOUNT]: Set the me_dummy
1362 member using the same `ignore'-testing code.
1363 * mountlist.h (ME_DUMMY): Add `autofs' to the list of ignored
1367 2000-05-29 Jim Meyering <meyering@lucent.com>
1369 * mountlist.c (read_filesystem_list) [MOUNTED_VMOUNT]: Ignore mounts
1370 with the `ignore' attribute. Based on a patch from Mark D. Roth.
1372 2000-05-22 Jim Meyering <meyering@lucent.com>
1374 * makepath.c: Remove old, now-unnecessary `#ifdef __MSDOS__' block.
1376 2000-05-18 Jim Meyering <meyering@lucent.com>
1378 * hash.c (hash_rehash): Fix a nasty bug: copy the free entry list
1379 back, too, since it may have been modified by allocate_entry.
1380 (hash_delete): Rewrite to use neither the assignment operator
1381 nor the comma operator in an if-expression.
1383 2000-05-15 Paul Eggert <eggert@twinsun.com>
1386 <sys/stat.h>, <sys/types.h>, <unistd.h>, (STDOUT_FILENO):
1387 Remove; no longer needed.
1388 "quotearg.h": Add include.
1389 (file_name): Do not bother to explicitly initialize to NULL; it's less
1390 efficient on some hosts.
1391 (close_stdout_status): Remove test as to whether stdout was already
1392 closed; it breaks for the case "echo x | sort >&-".
1393 Quote file name colons.
1394 Do not assume that _("write error") lacks format strings.
1396 2000-05-15 Jim Meyering <meyering@lucent.com>
1398 * version-etc.c (version_etc_copyright): Update the copyright string
1399 used in all --version output.
1401 2000-05-14 Jim Meyering <meyering@lucent.com>
1403 * closeout.c (close_stdout_set_file_name): New function.
1404 (close_stdout_status): Use new file-scoped global.
1405 Return right away if fstat says the stdout file descriptor is invalid.
1406 * closeout.h (close_stdout_set_file_name): Declare.
1408 2000-05-10 Jim Meyering <meyering@lucent.com>
1410 * closeout.c [default_exit_status]: New file-scoped variable.
1411 (close_stdout_set_status): New function.
1412 * closeout.h (close_stdout_set_status): Declare.
1414 2000-05-08 Jim Meyering <meyering@lucent.com>
1416 * long-options.c: Don't include closeout.h.
1417 (parse_long_options): Don't call close_stdout for --version.
1419 2000-05-06 Jim Meyering <meyering@lucent.com>
1421 * strnlen.c: Undefine __strnlen and strnlen.
1422 [!weak_alias]: Define __strnlen to strnlen.
1424 * atexit.c: New file, from libiberty.
1426 2000-05-06 Jim Meyering <meyering@lucent.com>
1428 * closeout.c (close_stdout_status): Also check for errors on the
1431 2000-05-05 Bruno Haible <haible@clisp.cons.org>
1433 * localcharset.c (get_charset_aliases): Use malloc, realloc and memcpy
1434 instead of xmalloc, xrealloc, path_concat.
1435 (locale_charset): Treat empty environment variables as absent.
1436 (DIRECTORY_SEPARATOR, ISSLASH): New macros.
1438 2000-05-04 Jim Meyering <meyering@lucent.com>
1440 * getopt.c: Update from glibc.
1441 * obstack.c: Likewise.
1442 * obstack.h: Likewise.
1443 * regex.c: Likewise. NB: K&R compiler support is dropped for this file
1445 * regex.h: Likewise.
1446 * strndup.c: Likewise.
1447 * strnlen.c: New file, from glibc.
1449 2000-05-01 Jim Meyering <meyering@lucent.com>
1451 * full-write.c (full_write): Remove `FIXME' part of comment.
1453 2000-04-29 Jim Meyering <meyering@lucent.com>
1455 * path-concat.c: Declare strdup only if it's not defined.
1456 * canon-host.c: Likewise.
1458 2000-04-28 Jim Meyering <meyering@lucent.com>
1460 * rpmatch.c [HAVE_LIMITS_H]: Include limits.h before regex.h to avoid
1461 redefinition warning on some systems (HPUX). Otherwise, regex.h is
1462 included first, then limits.h is included by locale.h by libintl.h.
1463 From John David Anglin.
1465 2000-04-25 Jim Meyering <meyering@lucent.com>
1467 * makepath.c (S_IRWXUGO): Define.
1468 (make_path): Always perform explicit chmod if MODE specifies any
1469 of the `special' permission bits. Prompted by a bug report against
1470 install from Mate Wierdl and Joost van Baal.
1472 2000-04-18 Jim Meyering <meyering@lucent.com>
1476 * getpagesize.h [!getpagesize && HAVE_OS_H && B_PAGE_SIZE]: Define
1477 getpagesize. For BeOS. Based on a patch from Bruno Haible.
1479 2000-04-17 Jim Meyering <meyering@lucent.com>
1481 * strftime.c (my_strftime) [strftime]: Declare strftime here, since
1482 the definition of it to rpl_strftime also defined-away the system's
1485 2000-04-15 Jim Meyering <meyering@lucent.com>
1487 Use `C' to denote so-called `contiguous' files, the same way
1489 * filemode.c (S_ISCTG) [!S_ISCTG && S_IFCTG]: Define.
1490 (ftypelet): Use S_ISCTG.
1491 From Michael Deutschmann.
1493 2000-04-14 Jim Meyering <meyering@lucent.com>
1495 * strftime.c (my_strftime) [#ifdef strftime]: Declare strftime.
1497 2000-04-08 Jim Meyering <meyering@lucent.com>
1499 * Makefile.am (charset.alias): Use t-$@, not $@-t so the DOS 8.3
1500 names don't conflict. Reported by Eli Zaretskii.
1502 2000-03-28 Bruno Haible <haible@clisp.cons.org>
1504 * unicodeio.c (print_unicode_char): Avoid triggering Solaris iconv
1505 bug. Deal with the different error behavior of Irix iconv.
1507 2000-04-07 Jim Meyering <meyering@lucent.com>
1509 * putenv.c: Move inclusion of errno.h so it follows that of sys/types.h,
1510 to work around system header problems on AIX 3.2.5. From Bruno Haible.
1512 2000-04-05 Jim Meyering <meyering@lucent.com>
1514 Portability tweaks required for ultrix4.3.
1515 * readutmp.h [HAVE_UTMPX_H && !HAVE_DECL_GETUTENT]: Declare getutent.
1516 * readutmp.c: Include sys/types.h before sys/stat.h.
1517 * canon-host.c: Declare strdup.
1518 * path-concat.c: Likewise.
1519 From John David Anglin.
1521 2000-04-04 Jim Meyering <meyering@lucent.com>
1523 Be more DOS 8.3-friendly.
1524 * ref-add.sin: Renamed from ref-add.sed.in.
1525 * ref-del.sin: Renamed from ref-del.sed.in.
1526 * Makefile.am: Reflect renaming.
1527 Reported by Eli Zaretskii.
1529 Use a temporary file name that won't clash with `charset.alias'
1530 in the DOS 8.3 name space.
1531 * Makefile.am (charset_tmp): Define.
1532 (install-exec-local): Use $(charset_tmp) instead of $(charset_alias)-t.
1533 (uninstall-local): Likewise.
1534 Reported by Eli Zaretskii.
1536 2000-03-29 Paul Eggert <eggert@twinsun.com>
1538 * time/strftime.c (my_strftime): Make sure we call the system
1539 strftime, not ourselves, when invoking the underlying strftime.
1541 2000-03-24 Jim Meyering <meyering@lucent.com>
1543 * Makefile.am (EXTRA_DIST): Add ref-add.sed.in and ref-del.sed.in.
1544 (charset_alias): Define.
1545 (install-exec-local): Factor out common code.
1546 (uninstall-local): Split lines longer than 80.
1547 (ref-add.sed, ref-del.sed): Remove rules... (do the following instead)
1549 (.sed.in.sed): New rule. Don't redirect directly to $@.
1550 (CLEANFILES): Add ref-add.sed and ref-del.sed.
1552 2000-03-19 Bruno Haible <haible@clisp.cons.org>
1554 * config.charset: Output a line containing "Packages using this file".
1555 * ref-add.sed.in, ref-del.sed.in: New files.
1556 * Makefile.am (install-exec-local, uninstall-local, ref-add.sed,
1557 ref-del.sed): New rules.
1559 2000-03-17 Jim Meyering <meyering@lucent.com>
1561 * unicodeio.c (<string.h>): Include only #if HAVE_STRING_H.
1562 Otherwise, include <strings.h>
1564 2000-03-17 Bruno Haible <haible@clisp.cons.org>
1566 * unicodeio.c (utf8_wctomb): New function.
1567 (print_unicode_char): Pass the Unicode character to iconv in UTF-8
1568 format instead of in UCS-4 with platform dependent endianness.
1570 2000-03-07 Paul Eggert <eggert@twinsun.com>
1572 * savedir.c (savedir): Work even if directory size is
1573 negative; this can happen with some screwy NFS configurations.
1575 2000-03-06 Jim Meyering <meyering@lucent.com>
1577 * localcharset.c (get_charset_aliases): Don't try to free file_name
1578 if it's NULL (because we ran out of memory). From Bruno Haible.
1580 2000-03-05 Jim Meyering <meyering@lucent.com>
1582 * localcharset.c ("path-concat.h"): Include.
1583 (get_charset_aliases): Use path_concat instead of ANSI string
1586 * unicodeio.h (PARAMS): Define.
1587 Use it to guard prototype.
1589 2000-03-04 Jim Meyering <meyering@lucent.com>
1591 * Makefile.am (install-exec-local): Create $(libdir) before installing
1593 (uninstall-local): Uncomment this rule so `make distcheck' works
1596 * unicodeio.c (<errno.h>): Include it.
1597 (errno): Declare if not defined.
1599 * localcharset.c: Add Bruno's comment justifying use of volatile.
1601 * config.charset: New version, incorporating remarks from a linux
1602 i18n mailing list. From Bruno Haible.
1604 2000-03-02 Jim Meyering <meyering@lucent.com>
1606 * Makefile.am (EXTRA_DIST): Add config.charset.
1608 2000-03-01 Jim Meyering <meyering@lucent.com>
1610 * localcharset.c: Guard some #includes with `#if HAVE_...'.
1611 * unicodeio.c: Likewise.
1613 2000-02-02 Bruno Haible <haible@clisp.cons.org>
1615 * config.charset: New file.
1616 * localcharset.c: New file.
1617 * unicodeio.h, unicodeio.c: New files.
1618 * Makefile.am (DEFS): Add -DLIBDIR=...
1619 (libfetish_a_SOURCES): Add localcharset.c and unicodeio.c.
1620 (noinst_HEADERS): Add unicodeio.h.
1621 (all-local, install-exec-local, charset.alias): New targets.
1623 2000-02-28 Paul Eggert <eggert@twinsun.com>
1625 * quotearg.c (ALERT_CHAR): New macro.
1626 (quotearg_buffer_restyled): Use it.
1628 2000-02-27 Jim Meyering <meyering@lucent.com>
1630 * strtoumax.c: Fix typo in decl of strtoul: s/long long/long/.
1631 Guard declaration of strtoull also with `&& HAVE_UNSIGNED_LONG_LONG'.
1633 * backupfile.c: Guard inclusion of stdlib.h with `#if HAVE_STDLIB_H',
1634 not `#if STDC_HEADERS'.
1635 Declare malloc if needed.
1637 * backupfile.c: Use `#if !HAVE_DECL...' instead of `#ifndef HAVE_DECL..'
1638 now that autoconf always defines the HAVE_DECL_ symbols.
1639 * human.c: Likewise.
1641 * strtoumax.c: Likewise.
1643 * backupfile.c: Arrange for cpp to fail if the configure-time
1644 declaration check was not run.
1646 * human.c: Likewise.
1648 * strtoumax.c: Likewise.
1650 * userspec.c (parse_user_spec): If there is no `:' but there is a `.',
1651 then first look up the entire `.'-containing string as a login name.
1653 2000-02-18 Paul Eggert <eggert@twinsun.com>
1655 * getdate.y: Handle two-digit years with leading zeros correctly.
1656 (textint): New typedef.
1657 (parser_control): Member year changed from int to textint.
1659 (YYSTYPE): Removed; replaced by %union with int and textint members.
1660 (tDAY, tDAY_UNIT, tDAYZONE, tHOUR_UNIT, tID, tLOCAL_ZONE, tMERIDIAN,
1661 tMINUTE_UNIT, tMONTH, tMONTH_UNIT tSEC_UNIT, tSNUMBER, tUNUMBER,
1662 tYEAR_UNIT, tZONE, o_merid): Now of type <intval>.
1663 (tSNUMBER, tUNUMBER): Now of type <textintval>.
1664 (date, number, to_year): Use width of number in digits, not its value,
1665 to determine whether it's a 2-digit year, or a 2-digit time.
1666 (yylex): Store number of digits of numeric tokens.
1667 Reported by John Kendall.
1669 (parser_control): Changed from struct parser_control to typedef (for
1670 consistency). All uses changed.
1672 (tID): Removed; not used.
1673 (yylex): Return '?' for unknown identifiers, rather than (unused) tID.
1675 2000-02-14 Paul Eggert <eggert@twinsun.com>
1677 * getpagesize.h (getpagesize): Port to VMS for Alpha;
1678 adapted from changes to grep getpagesize.h by Martin P.J. Zinser.
1680 2000-02-12 Jim Meyering <meyering@lucent.com>
1682 * userspec.c (ISDIGIT): Define it.
1683 (isdigit): Remove definition.
1684 (is_number): Use ISDIGIT, not isdigit.
1685 <libintl.h>: Include.
1687 (parse_user_spec): Mark translatable strings.
1689 2000-02-10 Jim Meyering <meyering@lucent.com>
1691 With these changes, nanosleep.[ch] are finally enough like the other
1692 lib/* replacement files to compile on a few more losing systems.
1694 * nanosleep.h: Don't include config.h.
1695 Remove prototype from declaration of nanosleep.
1696 (PARAMS): Remove now-unneeded definition.
1697 * nanosleep.c: #undef nanosleep.
1698 (rpl_nanosleep): Rename from nanosleep.
1700 2000-02-03 Jim Meyering <meyering@lucent.com>
1702 * readutmp.c (read_utmp): Guard with `#ifdef UTMP_NAME_FUNCTION',
1703 rather than with `#if HAVE_UTMPNAME'.
1705 2000-02-01 Jim Meyering <meyering@lucent.com>
1707 * readutmp.h (UT_USER): Add parens. From Andreas Schwab.
1709 2000-01-31 Jim Meyering <meyering@lucent.com>
1711 * nanosleep.h (nanosleep): Guard declaration with
1712 `#if ! HAVE_DECL_NANOSLEEP'.
1713 Without this, OFS gets a redeclaration error for rpl_nanosleep, due to
1714 the declaration in that vendor's sys/timers.h.
1715 Reported by Christian Krackowizer.
1717 * quotearg.c (ISASCII): Add #undef and move definition to follow
1718 inclusion of wctype.h to work around solaris2.6 namespace pollution.
1719 (ISPRINT): Likewise.
1720 Reported by Tom Tromey.
1722 2000-01-30 Jim Meyering <meyering@lucent.com>
1724 * readutmp.c (extract_trimmed_name): Use UT_USER instead of hard-coding
1725 uses of ->ut_name. The latter doesn't work with new Linux header files
1726 where only utmpx.ut_user is declared.
1728 * readutmp.h (UT_USER): Define.
1730 2000-01-23 Jim Meyering <meyering@lucent.com>
1732 * Makefile.am (libfetish_a_SOURCES): Remove explicit mention of
1735 2000-01-22 Jim Meyering <meyering@lucent.com>
1737 * strtoumax.c: [! HAVE_DECL_STRTOUL]: Declare strtoul.
1738 [! HAVE_DECL_STRTOULL]: Declare strtoull.
1739 Required for some AIX systems. Reported by Christian Krackowizer.
1740 [TESTING] (main): New function.
1742 1997-10-17 Eli Zaretskii <eliz@is.elta.co.il>
1743 * dirname.c (dir_name): Support for DOS-style file names with drive
1746 * quotearg.c [HAVE_WCTYPE_H]: Include <wctype.h> for decl of iswprint.
1748 * strverscmp.c (ISDIGIT): Define.
1749 (strverscmp): Use ISDIGIT, not isdigit.
1751 2000-01-17 Paul Eggert <eggert@twinsun.com>
1753 * nanosleep.c (nanosleep):
1754 Don't use SA_INTERRUPT to decide whether to call sigaction, as
1755 POSIX.1 doesn't require SA_INTERRUPT and some systems
1756 (e.g. Solaris 7) don't define it. Use SA_NOCLDSTOP instead;
1757 it's been part of POSIX.1 since day 1 (in 1988).
1759 2000-01-17 Jim Meyering <meyering@lucent.com>
1761 * interlock: Remove unused file. Reported by François Pinard.
1763 2000-01-16 Paul Eggert <eggert@twinsun.com>
1765 * quotearg.c (quotearg_buffer_restyled): Do not quote
1766 alert, backslash, formfeed, and vertical tab unnecessarily in
1767 shell quoting style.
1770 version-control: never