projects
/
gnulib.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix several address-calculation bugs in the hash modules,
[gnulib.git]
/
lib
/
hash-pjw.c
diff --git
a/lib/hash-pjw.c
b/lib/hash-pjw.c
index
0a14b3e
..
3328467
100644
(file)
--- a/
lib/hash-pjw.c
+++ b/
lib/hash-pjw.c
@@
-1,5
+1,5
@@
/* hash-pjw.c -- compute a hash value from a NUL-terminated string.
/* hash-pjw.c -- compute a hash value from a NUL-terminated string.
- Copyright 2001, 2003 Free Software Foundation, Inc.
+ Copyright
(C)
2001, 2003 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@
-21,25
+21,22
@@
#include "hash-pjw.h"
#include "hash-pjw.h"
+#include <limits.h>
+
+#define SIZE_BITS (sizeof (size_t) * CHAR_BIT)
+
/* A hash function for NUL-terminated char* strings using
/* A hash function for NUL-terminated char* strings using
- the method described in Aho, Sethi, & Ullman, p 436.
- Note that this hash function produces a lot of collisions when used
- with short strings with very varied bit patterns.
+ the method described by Bruno Haible.
See http://www.haible.de/bruno/hashfunc.html. */
See http://www.haible.de/bruno/hashfunc.html. */
-
unsigned in
t
-hash_pjw (const void *x,
unsigned in
t tablesize)
+
size_
t
+hash_pjw (const void *x,
size_
t tablesize)
{
{
- const char *s = x;
- unsigned int h = 0;
- unsigned int g;
-
- while (*s != 0)
- {
- h = (h << 4) + *s++;
- if ((g = h & (unsigned int) 0xf0000000) != 0)
- h = (h ^ (g >> 24)) ^ g;
- }
-
- return (h % tablesize);
+ const char *s;
+ size_t h = 0;
+
+ for (s = x; *s; s++)
+ h = *s + ((h << 9) | (h >> (SIZE_BITS - 9)));
+
+ return h % tablesize;
}
}