test-sys_socket: mark variables as used more readably

[gnulib.git] / ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 5b037a4..7b6394d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,61 @@
 2010-06-11  Jim Meyering  <meyering@redhat.com>
 
+       test-sys_socket: mark variables as used more readably
+       * tests/test-sys_socket.c (main): Mark otherwise unused variables
+       as "used" explicitly via (void) statement casts.  This is more
+       readable than using them in an artificial return expression.
+       Suggestion from Bruno Haible.
+
+2010-06-11  Bruno Haible  <bruno@clisp.org>
+
+       Avoid some more warnings from "gcc -Wwrite-strings".
+       * tests/test-argp.c (test_optional): Change 5th and 6th argument type
+       to 'const char *'.
+       * tests/test-c-strstr.c (main): Add 'const' to variable declaration.
+       * tests/test-c-strcasestr.c (main): Likewise.
+       * tests/test-mbscasestr1.c (main): Likewise.
+       * tests/test-mbscasestr2.c (main): Likewise.
+       * tests/test-memmem.c (main): Likewise.
+       * tests/test-strstr.c (main): Likewise.
+       * tests/test-strcasestr.c (main): Likewise.
+
+2010-06-11  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
+
+       init.sh: change framework_failure_ to fail with status 99, not 1
+       * tests/init.sh (framework_failure_): Exit 99, not 1.  This informs
+       automake's parallel-tests rule that this is an unexpected failure,
+       even if the test is listed in XFAIL_TESTS.
+
+2010-06-11  Jim Meyering  <meyering@redhat.com>
+
+       test-inttostr: avoid warnings about 4-6KB literal strings
+       * tests/test-inttostr.c: Don't use <assert.h>.  Instead, ...
+       Include "macros.h", for its definition of ASSERT.
+       (CK): s/assert/ASSERT/
+       * modules/inttostr-tests (Files): Add macros.h.
+
+       init.sh: don't use $ME_ or skip_ before they are defined
+       * tests/init.sh: Hoist definitions of $ME_ and skip_ to precede
+       their first uses.  Also hoist their companions: warn_, fail_,
+       framework_failure_, $stderr_fileno.  Prompted by a patch from
+       Stefano Lattarini.
+
+       test-sys_socket: avoid set-but-not-used warnings from gcc
+       * tests/test-sys_socket.c (main): Use "i" and "x", in order to
+       avoid warning about set-but-not-used variables.
+
+       test-xvasprintf: avoid 'const' discard warnings
+       * tests/test-xvasprintf.c (test_xvasprintf, test_xasprintf): Use
+       "const" when assigning from literal strings.
+       (test_xasprintf): Add "void" in function argument list to placate
+       -Wstrict-prototypes and to be consistent with test_xvasprintf above.
+
+       tests: avoid compilation warnings in argmatch and exclude tests...
+       in packages that define ARGMATCH_DIE_DECL, like coreutils.
+       * tests/test-exclude.c [ARGMATCH_DIE_DECL]: Also declare the function.
+       Since it always exits, declare with the "noreturn" attribute.
+       * tests/test-argmatch.c: Likewise.
+
        tests: avoid 'const' discard warnings in mbsstr tests
        * tests/test-mbsstr1.c (main): Add "const" to avoid trivial warning.
        * tests/test-mbsstr2.c (main): Likewise.