+2011-02-12 Paul Eggert <eggert@cs.ucla.edu>
+
+ stdlib: support non-GCC __attribute__
+
+ Fix a serious and tricky problem encountered when attempting to
+ add the getloadavg module to Emacs. Emacs worked fine on RHEL
+ 5.5, but it crashed due to memory corruption on Solaris 10 with
+ Sun C 5.11. Emacs normally ORs 3-bit tags into their low-order
+ bits that are otherwise zero. This tagging is optional inside
+ Emacs but is preferred and is used when __attribute__ ((__aligned
+ (8))) works, as it does with both recent-enough GCC and with Sun C
+ 5.11. However, Sun C 5.11 is not GCC and does not #define
+ __GNUC__ and __GNUC_MINOR__.
+
+ When I added the getloadavg module to Emacs, it brought in
+ stdlib.in.h, which contained this fragment:
+
+ #ifndef __attribute__
+ # if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 8)
+ # define __attribute__(Spec) /* empty */
+ # endif
+ #endif
+
+ When files that include <stdlib.h> were compiled with Sun C 5.11,
+ the above code disabled __attribute__ ((__aligned (8))), which
+ caused variables to not be properly aligned, which eventually led
+ to the pointer corruption mentioned above. (This was a bit hard
+ to diagnose, unfortunately.)
+
+ Several "#define __attribute__(X) /* empty */" code snippets need
+ to be eradicated from Gnulib to work with non-GCC compilers that
+ support __attribute__. The Autoconf way to do this is to test for
+ each kind of attribute that we want support for, and selectively
+ enable that in source code.
+
+ Fix this problem just for stdlib.h, by adding a test for the
+ __noreturn__ attribute, and change stdlib.in.h to use that test
+ when needed. This technique can be easily generalized to the
+ other *.in.h files and attributes, and a similar technique can be
+ used for *.h and *.c files. This patch is enough to solve the
+ problem for Emacs + getloadavg, and I thought I'd publish it for
+ feedback before undertaking further, similar fixes in other
+ modules.
+
+ This patch does not arrange to #define HAVE_ATTRIBUTE_NORETURN
+ because it's not needed for stdlib.h. It merely substitutes the
+ value directly into stdlib.h. We may well need to #define it, or
+ similar symbols, for other modules, but it's nice to also have an
+ option to not #define it for applications like Emacs that do not
+ need it.
+
+ * lib/stdlib.in.h (__attribute__): Do not #define.
+ (_GL_ATTRIBUTE_NORETURN): New macro, which in stdlib.h needs to
+ be defined only if the _Exit module is also used.
+ * m4/_Exit.m4 (gl_FUNC__EXIT): Require gl_ATTRIBUTE_NORETURN.
+ * m4/stdlib_h.m4 (gl_STDLIB_H_DEFAULTS): Subst
+ HAVE_ATTRIBUTE_NORETURN and default it to 1, its value on GNU
+ platforms.
+ * modules/_Exit (Files): Add m4/attribute.m4.
+ * modules/stdlib (Makefile.am): Substitute HAVE_ATTRIBUTE_NORETURN.
+ * m4/attribute.m4: New file.
+
+2011-02-12 Bruno Haible <bruno@clisp.org>
+
+ wcsrtombs: Work around bug on native Windows.
+ * m4/wcsrtombs.m4 (gl_WCSRTOMBS_NULL): Test against mingw bug.
+ * lib/wcsrtombs.c (rpl_wcsrtombs): When dest is NULL, pass SIZE_MAX
+ instead of len.
+ * doc/posix-functions/wcsrtombs.texi: Document mingw bug.
+
+2011-02-12 Bruno Haible <bruno@clisp.org>
+
+ mbsrtowcs: Work around bug on native Windows.
+ * m4/mbsrtowcs.m4 (gl_MBSRTOWCS_WORKS): Require gt_LOCALE_FR. Test
+ against mingw bug.
+ * doc/posix-functions/mbsrtowcs.texi: Document mingw bug.
+
+2011-02-11 Thien-Thi Nguyen <ttn@gnuvola.org>
+
+ doc: update users.txt
+ * users.txt: Add rcs.
+
+2011-02-10 John W. Eaton <jwe@gnu.org>
+
+ doc: update users.txt
+ * users.txt: Add octave.
+
+2011-02-10 Jim Meyering <meyering@redhat.com>
+
+ doc: update users.txt
+ * users.txt: Add iwhd.
+
+2011-02-09 Bruno Haible <bruno@clisp.org>
+
+ gnulib-tool: Make copyright notice adjustment more robust.
+ * gnulib-tool (func_import): In sed_transform_main_lib_file,
+ sed_transform_build_aux_file, sed_transform_testsrelated_lib_file,
+ allow a line break to occur after "GNU" in "GNU [Lesser] General Public
+ License".
+ Reported by Glenn Morris <rgm@gnu.org> via Paul Eggert.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ New module 'towctrans'.
+ * modules/towctrans: New file.
+ * lib/wctype.in.h (towctrans): New declaration.
+ * lib/towctrans.c: New file.
+ * lib/towctrans-impl.h: New file.
+ * m4/towctrans.m4: New file.
+ * m4/wctype_h.m4 (gl_WCTYPE_H): Test whether towctrans is declared.
+ (gl_WCTYPE_H_DEFAULTS): Initialize GNULIB_TOWCTRANS.
+ * modules/wctype-h (Makefile.am): Substitute GNULIB_TOWCTRANS.
+ * tests/test-wctype-h-c++.cc: Test the declaration of towctrans.
+ * doc/posix-functions/towctrans.texi: Mention the new module.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ New module 'wctrans'.
+ * modules/wctrans: New file.
+ * lib/wctype.in.h (wctrans): New declaration.
+ * lib/wctrans.c: New file.
+ * lib/wctrans-impl.h: New file.
+ * m4/wctrans.m4: New file.
+ * m4/wctype_h.m4 (gl_WCTYPE_H): Test whether wctrans is declared.
+ (gl_WCTYPE_H_DEFAULTS): Initialize GNULIB_WCTRANS.
+ * modules/wctype-h (Makefile.am): Substitute GNULIB_WCTRANS.
+ * tests/test-wctype-h-c++.cc: Test the declaration of wctrans.
+ * doc/posix-functions/wctrans.texi: Mention the new module.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ New module 'iswctype'.
+ * modules/iswctype: New file.
+ * lib/wctype.in.h (iswctype): New declaration.
+ * lib/iswctype.c: New file.
+ * lib/iswctype-impl.h: New file.
+ * m4/iswctype.m4: New file.
+ * m4/wctype_h.m4 (gl_WCTYPE_H): Test whether iswctype is declared.
+ (gl_WCTYPE_H_DEFAULTS): Initialize GNULIB_ISWCTYPE.
+ * modules/wctype-h (Makefile.am): Substitute GNULIB_ISWCTYPE.
+ * tests/test-wctype-h-c++.cc: Test the declaration of iswctype.
+ * doc/posix-functions/iswctype.texi: Mention the new module and the
+ HP-UX 11.00 problem.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ New module 'wctype'.
+ * modules/wctype: Change to represent the wctype() substitute.
+ * lib/wctype.in.h (wctype): New declaration.
+ * lib/wctype.c: New file.
+ * lib/wctype-impl.h: New file.
+ * m4/wctype.m4: New file.
+ * m4/wctype_h.m4 (gl_WCTYPE_H): Test whether wctype is declared.
+ (gl_WCTYPE_H_DEFAULTS): Initialize GNULIB_WCTYPE.
+ * modules/wctype-h (Makefile.am): Substitute GNULIB_WCTYPE.
+ * tests/test-wctype-h-c++.cc: Test the declaration of wctype.
+ * doc/posix-functions/wctype.texi: Mention the new module and the
+ HP-UX 11.00 problem.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ wctype-h: Ensure wctype_t and wctrans_t are defined.
+ * lib/wctype.in.h (wctype_t, wctrans_t): New type declarations.
+ * m4/wctype_h.m4 (gl_WCTYPE_H): Determine HAVE_WCTYPE_T, HAVE_WCTRANS_T.
+ (gl_WCTYPE_H_DEFAULTS): Initialize HAVE_WCTYPE_T, HAVE_WCTRANS_T.
+ * modules/wctype-h (Makefile.am): Substitute HAVE_WCTYPE_T,
+ HAVE_WCTRANS_T.
+ * tests/test-wctype-h.c: Check that wctype_t and wctrans_t are defined.
+
+2011-02-09 Paul Eggert <eggert@cs.ucla.edu>
+
+ flock: fix license typo
+
+ * lib/flock.c: Fix typo in license. One of the "Lesser"s was
+ omitted.
+
+2011-02-08 Bruno Haible <bruno@clisp.org>
+
+ Split large sed scripts, for HP-UX sed.
+ * modules/math (Makefile.am): Split sed scripts around 50 sed commands,
+ to avoid HP-UX limit of 99 commands, in the near future.
+ * modules/stdlib (Makefile.am): Likewise.
+ * modules/unistd (Makefile.am): Likewise.
+ * modules/wchar (Makefile.am): Likewise.
+ Reported by Albert Chin <bug-gnulib@mlists.thewrittenword.com>.
+ Suggestion by Ralf Wildenhues <Ralf.Wildenhues@gmx.de> in
+ <http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00216.html>.
+
+2011-02-08 Paul Eggert <eggert@cs.ucla.edu>
+ Bruno Haible <bruno@clisp.org>
+
+ stdlib: improve random_r modularization
+ * lib/stdlib.in.h: Encapsulate all the stuff having to do with
+ random_r inside "#if @GNULIB_RANDOM_R@", so that it's clearer that
+ you also need the random_r module to get this material right.
+ * m4/random_r.m4 (gl_FUNC_RANDOM_R): Move check for random.h here ...
+ * m4/stdlib_h.m4 (gl_STDLIB_H): ... from here.
+ (gl_STDLIB_H_DEFAULTS): Default HAVE_RANDOM_H to 1, and AC_SUBST it.
+
+2011-02-08 Paul Eggert <eggert@cs.ucla.edu>
+
+ stdlib: don't depend on stdint
+ * lib/stdlib.in.h: Don't include <stdint.h> merely because
+ GNULIB_POSIXCHECK is defined. GNULIB_POSIXCHECK seems to
+ be independent of whether stdint.h is needed.
+ * m4/random_r.m4 (gl_FUNC_RANDOM_R): Check for struct random_data
+ here, instead of ...
+ * m4/stdlib_h.m4 (gl_STDLIB_H): ... here. Applications that need
+ struct random_data should be using the random_r module, not just
+ the stdlib module (which wouldn't make sense: what package needs
+ just struct random_data without also needing random_r?).
+ * modules/stdlib (Depends-on): Remove stdint.
+
+ getloadavg: don't depend on c-strtod, cloexec, fcntl-safer
+ See the thread rooted at
+ <http://lists.gnu.org/archive/html/bug-gnulib/2011-02/msg00090.html>.
+ * lib/getloadavg.c: Do not include c-strtod.h, cloexec.h, or fcntl--.h.
+ Include <fcntl.h> only if (defined __linux__ || defined __CYGWIN__
+ || defined SUNOS_5 || (defined LOAD_AVE_TYPE && ! defined
+ __VMS)); previously it was always included (via fcntl--.h).
+ (getloadavg): Do not use c_strtod. Instead, approximate it by
+ hand; this is good enough for load averages. Also, do not use
+ set_cloexec_flag; instead, use the O_CLOEXEC and F_DUPFD_CLOEXEC
+ flags directly if available and don't bother otherwise. (Packages
+ that need the extra reliability should use the modules that define
+ these flags on older platforms that lack them.)
+ * modules/getloadavg (Depends-on): Remove c-strtod, cloexec,
+ fcntl-safer.
+
+2011-02-08 Jim Meyering <meyering@redhat.com>
+
+ di-set.h, ino-map.h: add multiple-inclusion guard
+ Technically, the guard is required only for ino-map.h, due to its
+ INO_MAP_INSERT_FAILURE definition, but do both for consistency.
+ * lib/di-set.h: Add file-spanning #ifndef _GL_DI_SET_H.
+ * lib/ino-map.h: Likewise.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ iswblank: Ensure declaration on glibc systems.
+ * m4/iswblank.m4 (gl_FUNC_ISWBLANK): Require gl_USE_SYSTEM_EXTENSIONS.
+ * modules/iswblank (Dependencies): Add 'extensions'.
+ * doc/posix-functions/iswblank.texi: Document the glibc problem.
+
+2011-02-06 Bruno Haible <bruno@clisp.org>
+
+ New module 'iswblank'.
+ * lib/wctype.in.h (iswblank): Don't declare if GNULIB_ISWBLANK is 0.
+ * modules/iswblank: New file.
+ * modules/wctype-h (Files): Remove lib/iswblank.c.
+ (Makefile.am): Substitute GNULIB_ISWBLANK.
+ * m4/iswblank.m4: New file, partially extracted from m4/wctype_h.m4.
+ * m4/wctype_h.m4 (gl_WCTYPE_MODULE_INDICATOR): New macro.
+ (gl_WCTYPE_H_DEFAULTS): New macro.
+ (gl_WCTYPE_H): Require it. Remove iswblank related code.
+ * modules/iswblank-tests: New file.
+ * tests/test-iswblank.c: New file, extraced from tests/test-wctype-h.c.
+ * tests/test-wctype-h.c (main): Remove iswblank tests.
+ * tests/test-wctype-h-c++.cc: Guard the signature test of iswblank.
+ * doc/posix-functions/iswblank.texi: Mention module 'iswblank' instead
+ of 'wctype-h'.
+ * NEWS: Mention the change.
+ * modules/mbchar (Depends-on): Add iswblank.
+
+2011-02-08 Bruno Haible <bruno@clisp.org>
+
+ di-set tests: Refactor.
+ * tests/test-di-set.c: Include di-set.h early. Include macros.h. Drop
+ unnecessary includes.
+ (ASSERT): Remove macro.
+ (main): Make C90 compliant by avoiding variable declaration after
+ statement.
+ * modules/di-set-tests (Files): Add tests/macros.h.
+
+2011-02-08 Bruno Haible <bruno@clisp.org>
+
+ ino-map tests: Refactor.
+ * tests/test-ino-map.c: Include ino-map.h early. Include macros.h. Drop
+ unnecessary includes.
+ (ASSERT): Remove macro.
+ (main): Make C90 compliant by avoiding variable declaration after
+ statement.
+ * modules/ino-map-tests (Files): Add tests/macros.h.
+
+2011-02-08 Jim Meyering <meyering@redhat.com>
+
+ di-set: add "const" to a cast
+ * lib/di-set.c (di_set_insert): Cast hash_insert0 argument to
+ "(void const *)", not "(void *)". Spotted by Bruno Haible.
+
2011-02-06 Bruno Haible <bruno@clisp.org>
Rename module 'wctype' to 'wctype-h'.
projects / gnulib.git / blobdiff