bugfixes mainly...

[mir.git] / source / mircoders / storage / DatabaseImages.java

diff --git a/source/mircoders/storage/DatabaseImages.java b/source/mircoders/storage/DatabaseImages.java
index f181f3d..e61ff38 100755 (executable)
--- a/source/mircoders/storage/DatabaseImages.java
+++ b/source/mircoders/storage/DatabaseImages.java
@@ -22,7 +22,11 @@ public class DatabaseImages extends Database implements StorageObject{
        private static DatabaseImages instance;
        private static SimpleList publisherPopupData;
 
-       public static DatabaseImages getInstance() throws StorageObjectException
+  // the following *has* to be sychronized cause this static method
+  // could get preemted and we could end up with 2 instances of DatabaseFoo..
+  // see the "Singletons with needles and thread" article at JavaWorld -mh
+       public synchronized static DatabaseImages getInstance()
+    throws StorageObjectException
        {
                if (instance == null) {
                        instance = new DatabaseImages();
@@ -43,7 +47,7 @@ public class DatabaseImages extends Database implements StorageObject{
                catch (Exception e) { throw new StorageObjectException(e.toString());   }
        }
 
-       public SimpleList getPopupData() {
+       public SimpleList getPopupData() throws StorageObjectException {
                return getPopupData("title",true);
        }