ftell: do not assume wraparound signed arithmetic

[gnulib.git] / tests / test-parse-duration.sh

diff --git a/tests/test-parse-duration.sh b/tests/test-parse-duration.sh
index e6ebf90..5398c3b 100755 (executable)
--- a/tests/test-parse-duration.sh
+++ b/tests/test-parse-duration.sh
@@ -46,26 +46,23 @@ die ()
 }
 
 func_tmpdir
-trap "rm -rf ${tmp}" EXIT
-tmpf=${tmp}/tests.txt
+trap 'rm -rf "${tmp}"' EXIT
+tmpf="${tmp}/tests.txt"
 
-cat > ${tmpf} <<- _EOF_
-       1 Y 2 M 3 W 4 d 5 h 6 m 7 s
-       P 00010225 T 05:06:07
-       P 1Y2M3W4D T 5H6M7S
-       1 Y 2 M 25 D 5:6:7
-       1 Y 2 M 25 d 5h 6:7
-       1 Y 2 M 25 d 5h 6m 7
-       P 1-2-25 T 5:6:7
-       _EOF_
+cat > "${tmpf}" <<- _EOF_
+  1 Y 2 M 3 W 4 d 5 h 6 m 7 s
+  P 00010225 T 05:06:07
+  P 1Y2M3W4D T 5H6M7S
+  1 Y 2 M 25 D 5:6:7
+  1 Y 2 M 25 d 5h 6:7
+  1 Y 2 M 25 d 5h 6m 7
+  P 1-2-25 T 5:6:7
+  _EOF_
 
-ls -l $tmpf
-
-exec 3< ${tmpf}
-while read -u3 line
+exec 3< "${tmpf}"
+while read line <&3
 do
-    v=`${exe} "${line}"` || die "Failed: ${exe} '${line}'"
+    v=`${exe} "${line}"` || { ls -l "${tmpf}"; die "Failed: ${exe} '${line}'"; }
     test $v -eq 38898367 || die $v is not 38898367
-    echo OK: ${line}
 done
 exec 3>&-