X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;ds=inline;f=tests%2Ftest-pread.c;h=22043986a30538bfc424af76d89c29bb1e6a57dc;hb=b294b2f93843df25c7e369c65b4f39eab971e45c;hp=fd5db8e8a159406e11ac51648314749e1b69a796;hpb=78d218ff8a7c36feaa55c58abdcec8270654e6f1;p=gnulib.git

diff --git a/tests/test-pread.c b/tests/test-pread.c
index fd5db8e8a..22043986a 100644
--- a/tests/test-pread.c
+++ b/tests/test-pread.c
@@ -1,5 +1,5 @@
 /* Test the pread function.
-   Copyright (C) 2009 Free Software Foundation, Inc.
+   Copyright (C) 2009-2014 Free Software Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -20,23 +20,14 @@
 
 #include <unistd.h>
 
-#include <stdio.h>
-#include <stdlib.h>
+#include "signature.h"
+SIGNATURE_CHECK (pread, ssize_t, (int, void *, size_t, off_t));
+
 #include <sys/types.h>
 #include <fcntl.h>
 #include <errno.h>
 
-#define ASSERT(expr) \
-  do                                                                         \
-    {                                                                        \
-      if (!(expr))                                                           \
-        {                                                                    \
-          fprintf (stderr, "%s:%d: assertion failed\n", __FILE__, __LINE__); \
-          fflush (stderr);                                                   \
-          abort ();                                                          \
-        }                                                                    \
-    }                                                                        \
-  while (0)
+#include "macros.h"
 
 #define N (sizeof buf - 1)
 
@@ -65,19 +56,21 @@ main (void)
       ASSERT (init_pos == pos);
 
       for (i = 0; i < N; i++)
-	{
-	  char byte_buf;
-	  ASSERT (pread (fd, &byte_buf, 1, i) == 1);
-	  ASSERT (byte_buf == buf[i]);
-	  ASSERT (lseek (fd, 0, SEEK_CUR) == init_pos);
-	}
+        {
+          char byte_buf;
+          ASSERT (pread (fd, &byte_buf, 1, i) == 1);
+          ASSERT (byte_buf == buf[i]);
+          ASSERT (lseek (fd, 0, SEEK_CUR) == init_pos);
+        }
     }
 
   {
     /* Invalid offset must evoke failure with EINVAL.  */
     char byte;
     ASSERT (pread (fd, &byte, 1, (off_t) -1) == -1);
-    ASSERT (errno == EINVAL);
+    ASSERT (errno == EINVAL
+            || errno == EFBIG /* seen on OpenBSD 4.9 */
+           );
   }
 
   ASSERT (close (fd) == 0);
@@ -90,5 +83,20 @@ main (void)
     ASSERT (errno == ESPIPE);
   }
 
+  /* Test behaviour for invalid file descriptors.  */
+  {
+    char byte;
+    errno = 0;
+    ASSERT (pread (-1, &byte, 1, 0) == -1);
+    ASSERT (errno == EBADF);
+  }
+  {
+    char byte;
+    close (99);
+    errno = 0;
+    ASSERT (pread (99, &byte, 1, 0) == -1);
+    ASSERT (errno == EBADF);
+  }
+
   return 0;
 }