X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;ds=sidebyside;f=lib%2Fxreadlink.c;h=8d61b633a779c3f5b991ff6ed3c45d402fdba2ef;hb=85fc15b1bf5d976584d8f174682a0d677692f0ea;hp=b58330a1d019e35007558569aa064b2c2529baee;hpb=b6f4a765056b52c30e9b44ca0990f536dd0cb9de;p=gnulib.git diff --git a/lib/xreadlink.c b/lib/xreadlink.c index b58330a1d..8d61b633a 100644 --- a/lib/xreadlink.c +++ b/lib/xreadlink.c @@ -1,6 +1,7 @@ -/* exclude.c -- exclude file names +/* xreadlink.c -- readlink wrapper to return the link name in malloc'd storage - Copyright 2001 Free Software Foundation, Inc. + Copyright (C) 2001, 2003, 2004, 2005, 2006 Free Software + Foundation, Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -15,32 +16,20 @@ You should have received a copy of the GNU General Public License along with this program; see the file COPYING. If not, write to the Free Software Foundation, - 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ /* Written by Jim Meyering */ -#if HAVE_CONFIG_H -# include -#endif +#include + +#include "xreadlink.h" #include #include -#ifndef errno -extern int errno; -#endif - -#if HAVE_LIMITS_H -# include -#endif -#if HAVE_SYS_TYPES_H -# include -#endif -#if HAVE_STDLIB_H -# include -#endif -#if HAVE_UNISTD_H -# include -#endif +#include +#include +#include +#include #ifndef SIZE_MAX # define SIZE_MAX ((size_t) -1) @@ -49,28 +38,34 @@ extern int errno; # define SSIZE_MAX ((ssize_t) (SIZE_MAX / 2)) #endif +#define MAXSIZE (SIZE_MAX < SSIZE_MAX ? SIZE_MAX : SSIZE_MAX) + #include "xalloc.h" -#include "xreadlink.h" -/* Call readlink to get the symbolic link value of FILENAME. +/* Call readlink to get the symbolic link value of FILE. + SIZE is a hint as to how long the link is expected to be; + typically it is taken from st_size. It need not be correct. Return a pointer to that NUL-terminated string in malloc'd storage. If readlink fails, return NULL (caller may use errno to diagnose). - If realloc fails, or if the link value is longer than SIZE_MAX :-), + If malloc fails, or if the link value is longer than SSIZE_MAX :-), give a diagnostic and exit. */ char * -xreadlink (char const *filename) +xreadlink (char const *file, size_t size) { /* The initial buffer size for the link value. A power of 2 detects arithmetic overflow earlier, but is not required. */ - size_t buf_size = 128; + size_t buf_size = size < MAXSIZE ? size + 1 : MAXSIZE; while (1) { char *buffer = xmalloc (buf_size); - ssize_t link_length = readlink (filename, buffer, buf_size); + ssize_t r = readlink (file, buffer, buf_size); + size_t link_length = r; - if (link_length < 0) + /* On AIX 5L v5.3 and HP-UX 11i v2 04/09, readlink returns -1 + with errno == ERANGE if the buffer is too small. */ + if (r < 0 && errno != ERANGE) { int saved_errno = errno; free (buffer); @@ -85,8 +80,11 @@ xreadlink (char const *filename) } free (buffer); - buf_size *= 2; - if (SSIZE_MAX < buf_size || (SIZE_MAX / 2 < SSIZE_MAX && buf_size == 0)) + if (buf_size <= MAXSIZE / 2) + buf_size *= 2; + else if (buf_size < MAXSIZE) + buf_size = MAXSIZE; + else xalloc_die (); } }