X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=Makefile;h=4035a0eebced4780692edfed9de5a2137ea75290;hb=46f5f314f34a08c9305758482d7d2fdb0e999d09;hp=4722647ec359975d865c413dc5e821a4385177d3;hpb=29757e0e9014e2b1ed26fac4228e849c3728bc32;p=gnulib.git diff --git a/Makefile b/Makefile index 4722647ec..4035a0eeb 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ # GNU Makefile for gnulib central. -# Copyright (C) 2006, 2009-2011 Free Software Foundation, Inc. +# Copyright (C) 2006, 2009-2014 Free Software Foundation, Inc. # # Copying and distribution of this file, with or without modification, # in any medium, are permitted without royalty provided the copyright @@ -18,7 +18,7 @@ all: info html dvi pdf: cd doc && $(MAKE) $@ && $(MAKE) mostlyclean -# Collect the names of rules starting with `sc_'. +# Collect the names of rules starting with 'sc_'. syntax-check-rules := $(sort $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p'\ Makefile)) @@ -26,30 +26,48 @@ syntax-check-rules := $(sort $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p'\ check: $(syntax-check-rules) sc_prefer_ac_check_funcs_once: - if test -d .git; then \ + @if test -d .git; then \ git grep -w -l AC_CHECK_FUNCS modules \ && { echo use AC_CHECK_FUNCS_ONCE, not AC_CHECK_FUNCS \ in modules/ 1>&2; exit 1; } || : \ else :; fi sc_prohibit_leading_TABs: - if test -d .git; then \ - url=FIXME; \ + @if test -d .git; then \ git grep -l '^ * ' lib m4 tests \ - | grep -Ev '^m4/po\.m4|^lib/reg|Makefile|test-update-copyright' \ - | grep . \ + | grep -Ev '^lib/reg|Makefile|test-update-copyright' \ + | grep . \ && { printf '*** %s\n' 'indent with spaces, not TABs;' \ 1>&2; exit 1; } || : \ else :; fi sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT: - if test -d .git; then \ + @if test -d .git; then \ url=http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/22874; \ git grep '^[ ]*TESTS_ENVIRONMENT += PATH=' modules \ && { printf '%s\n' 'Do not augment PATH via TESTS_ENVIRONMENT;' \ " see <$$url>" 1>&2; exit 1; } || : \ else :; fi +# It's easy to forget the noise-suppressing "@" at the beginning +# of each sc_ rule. Check for it both in maint.mk and in this file. +sc_prohibit_sc_omitted_at: + @if test -d .git; then \ + git grep -n -A1 '^sc_[[:alnum:]_-]*:' top/maint.mk Makefile \ + | grep -vE ':sc_|[0-9][-] @|--$$' \ + | sed 's/-\([0-9][0-9]*\)-/:\1:/' \ + | grep . \ + && { printf '*** %s\n' 'oops; missing "@"' \ + 1>&2; exit 1; } || : \ + else :; fi + +# Run all maint.mk syntax-check tests on gnulib's sources. +sc_maint: + @rm -f maint.mk; ln -s top/maint.mk maint.mk + $(MAKE) -s srcdir=. gnulib_dir=. _build-aux=build-aux \ + -f cfg.mk -f maint.mk syntax-check + rm -f maint.mk + # Files in m4/ that (exceptionally) may use AC_LIBOBJ. # Do not include their ".m4" suffix. allow_AC_LIBOBJ = \ @@ -77,7 +95,7 @@ allow_AC_LIBOBJ = \ allow_AC_LIBOBJ_or := $(shell echo $(allow_AC_LIBOBJ) | tr -s ' ' '|') sc_prohibit_AC_LIBOBJ_in_m4: - url=http://article.gmane.org/gmane.comp.lib.gnulib.bugs/26995; \ + @url=http://article.gmane.org/gmane.comp.lib.gnulib.bugs/26995; \ if test -d .git; then \ git ls-files m4 \ | grep -Ev '^m4/($(allow_AC_LIBOBJ_or))\.m4$$' \ @@ -87,7 +105,7 @@ sc_prohibit_AC_LIBOBJ_in_m4: else :; fi sc_pragma_columns: - if test -d .git; then \ + @if test -d .git; then \ git ls-files|grep '\.in\.h$$' \ | xargs grep -l '^@PRAGMA_SYSTEM_HEADER@' \ | xargs grep -L '^@PRAGMA_COLUMNS@' \ @@ -101,22 +119,27 @@ sc_pragma_columns: # Verify that certain (for now, only Jim Meyering and Eric Blake's) # *.c files are consistently cpp indented. sc_cpp_indent_check: - ./gnulib-tool --extract-filelist \ - $$(cd ./modules; grep -ilrE '(meyering|blake)' .) \ - | sort -u \ - | grep '\.c$$' \ - | grep -vE '/(stdio-(read|write)|getloadavg)\.c$$' \ - | xargs cppi -c + @./gnulib-tool --extract-filelist \ + $$(cd ./modules; grep -ilrE '(meyering|blake)' .) \ + | sort -u \ + | grep '\.c$$' \ + | grep -vE '/(stdio-(read|write)|getloadavg)\.c$$' \ + | xargs cppi -c # Ensure that the list of symbols checked for by the # sc_prohibit_intprops_without_use rule match those in the actual file. # Extract the symbols from the .h file and compare with the list of # symbols extracted from the rule in maint.mk. sc_check_sym_list: - i=lib/intprops.h; \ + @i=lib/intprops.h; \ diff -u <(perl -lne '/^# *define ([A-Z]\w+)\(/ and print $$1' $$i|fmt) \ <(sed -n /^_intprops_name/,/^_intprops_syms_re/p top/maint.mk \ - |sed '/^_/d;s/^ //;s/ *\\$$//') + |sed '/^_/d;s/^ //;s/ *\\$$//') + +# Ensure that the copyright statements in files and in the module descriptions +# are consistent. +sc_check_copyright: + @./check-copyright # Regenerate some files that are stored in the repository. regen: MODULES.html