X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=lib%2FID3FS%2FPath.pm;h=4cf5fc29575d980319f68fbf6c1455b94a6e4cbf;hb=9f0b226ddd9f9644c0a64d0b408aa8f50370f8ed;hp=7909a97b34f18a537e5ca09319dad4675e74102f;hpb=db517cc1ff37f50a636a89f6adaba51552bbccb1;p=id3fs.git

diff --git a/lib/ID3FS/Path.pm b/lib/ID3FS/Path.pm
index 7909a97..4cf5fc2 100644
--- a/lib/ID3FS/Path.pm
+++ b/lib/ID3FS/Path.pm
@@ -10,9 +10,11 @@ our ($STATE_INVALID, $STATE_ROOT, $STATE_TAG, $STATE_TAGVAL,
 
 our %priorities=( "OR" => 0, "AND" => 1, "NOT" => 2 );
 
-our $PATH_ALLTRACKS="TRACKS";
-our $PATH_NOARTIST="NOARTIST";
-our $PATH_NOALBUM="NOALBUM";
+our $PATH_ALLTRACKS= "TRACKS";
+our $PATH_NOARTIST = "NOARTIST";
+our $PATH_NOALBUM  = "NOALBUM";
+
+our $ENABLE_FILTER = 1;
 
 sub new
 {
@@ -92,7 +94,9 @@ sub dirents
 	    {
 		@dents=qw(AND OR);
 	    }
-	    push(@dents, $self->filter($PATH_ALLTRACKS, $PATH_NOARTIST));
+	    push(@dents, ($ENABLE_FILTER ?
+			  $self->filter($PATH_ALLTRACKS, $PATH_NOARTIST) :
+			  ($PATH_ALLTRACKS, $PATH_NOARTIST)));
 	    push(@dents, $self->artists());
 	}
     }
@@ -500,45 +504,23 @@ sub tags
 #    print "THASVALS: $hasvals\n";
 #    print "TPARENT: ", (defined($parent)? $parent : "NO"), "\n";
     my @ids=();
-    my $sql=("SELECT tags.name FROM (\n" .
-	     $self->tags_subselect() .
-	     ") AS subselect\n" .
-	     "INNER JOIN files_x_tags ON subselect.files_id=files_x_tags.files_id\n" .
-	     "INNER JOIN tags ON files_x_tags.tags_id=tags.id\n");
-    my @allused=$self->used_tags();
-    my @used=grep { ref($_) ne "ARRAY"; } @allused;
-    my @used_with_vals=grep { ref($_) eq "ARRAY"; } @allused;
-#    print "tags(): USED: ", join(", ", @used), "\n";
-#    print "tags(): USED_WITH_VALS: ", join(", ", map { "[".$_->[0]. ", ".$_->[1]."]";} @used_with_vals), "\n";
-    my @orclauses=();
-    my @andclauses=();
-    my $id=$self->trailing_tag_id();
-    if($hasvals)
+    my $sql="SELECT tags.name FROM ";
+    if($self->in_or())
     {
-#	print "HAS_VALUES\n";
-	my @values=map { "'".$_->[1]."'"; } grep { $_->[0] == $id; } @used_with_vals;
-	my $clause="(tags.parents_id='$id'";
-	if(@values)
-	{
-	    $clause .= " AND tags.id NOT IN (" . join(', ', @values) . ")";
-	}
-	$clause .= ")";
-	push(@andclauses, $clause);
+	$sql .= "files_x_tags\n";
     }
     else
     {
-#	print "HASNT VALUES\n";;
-	if(@used)
-	{
-	    push(@andclauses, "(NOT (tags.parents_id='' AND tags.id IN (" . join(', ', @used) . ")))");
-	}
-	for my $pair (@used_with_vals)
-	{
-	    push(@andclauses, "(NOT (tags.parents_id='" . $pair->[0] . "' AND tags.id='" . $pair->[1] . "'))");
-	}
+	$sql .= ("(\n" .
+		 $self->tags_subselect() .
+		 ") AS subselect\n" .
+		 "INNER JOIN files_x_tags ON subselect.files_id=files_x_tags.files_id\n");
     }
+    $sql .= "INNER JOIN tags ON files_x_tags.tags_id=tags.id\n";
+    my @andclauses=();
+    my $id=$self->trailing_tag_id();
 
-    my $parentclause= "(tags.parents_id='";
+    my $parentclause= "tags.parents_id='";
     if($hasvals)
     {
 	$parentclause .= $id;
@@ -547,17 +529,19 @@ sub tags
     {
 	$parentclause .= $parent;
     }
-    $parentclause .= "')";
+    $parentclause .= "'";
     push(@andclauses, $parentclause);
 
-    if(@orclauses)
+    my @used=$self->used_tags();
+    if(@used)
     {
-	push(@andclauses, '( ' . join(' OR ', @orclauses) . ' )');
+	push(@andclauses, "tags.id NOT IN (" . join(', ', @used) . ")");
     }
     if(@andclauses)
     {
 	$sql .= "WHERE " . join(' AND ', @andclauses) . "\n";
     }
+
     $sql .= "GROUP BY tags.name;";
     print "SQL(TAGS): $sql\n" if($self->{verbose});
     my @tagnames=$self->{db}->cmd_firstcol($sql);
@@ -703,9 +687,12 @@ sub tags_subselect
     my $hasvals=$self->expecting_values();
     if($self->{in_all})
     {
+	# FIXME: is this used?
+	die "IN_ALL CALLED!!\n";
 	return "\tSELECT id FROM files AS files_id\n";
     }
     my $tree=$self->{tagtree};
+    # FIXME
     print "UNDEF!!\n" unless($self->{tagtree});
     my $parent=$self->trailing_tag_parent();
 
@@ -719,7 +706,7 @@ sub tags_subselect
     }
     my ($sqlclause, @joins)=(undef, ());
     ($sqlclause, @joins) = $tree->to_sql($hasvals) if($tree);
-#    print "SQL(" . scalar(@joins) .": $sqlclause\n";
+#    print "SQL(" . scalar(@joins) ."): $sqlclause\n";
     my $sql="\tSELECT fxt1.files_id FROM tags t1";
     my @crosses=();
     my @inners=();
@@ -766,7 +753,7 @@ sub sql_start
     return $sql;
 }
 
-
+# FIXME: remove
 sub constraints_tag_list
 {
     my($self, @constraints)=@_;
@@ -837,4 +824,20 @@ sub empty
     return 1;
 }
 
+# if path is .../OR/ or .../OR/NOT
+sub in_or
+{
+    my($self)=@_;
+    my $tail=$self->tail();
+    return 0 unless($tail);
+    return 0 unless($tail->type() eq "boolean");
+    return 1 if($tail->name() eq "OR");
+    return 0 unless($tail->name() eq "NOT");
+    my $parent=$self->tail_parent();
+    return 0 unless($parent);
+    return 0 unless($parent->type() eq "boolean");
+    return 1 if($parent->name() eq "OR");
+    return 0;
+}
+
 1;