X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=lib%2Fcloseout.c;h=a551d1ae8be6521e7215efeb87b7996297cd11d9;hb=fdae5d9f72a0596fc7b5933509a9cd03cbebf6eb;hp=ed02a7df1861b74e57eb4503970c84e4e1e45f8c;hpb=97a560dd264cb35d71a0fd60d8852323392e32b1;p=gnulib.git diff --git a/lib/closeout.c b/lib/closeout.c index ed02a7df1..a551d1ae8 100644 --- a/lib/closeout.c +++ b/lib/closeout.c @@ -1,5 +1,5 @@ /* closeout.c - close standard output - Copyright (C) 1998, 1999, 2000 Free Software Foundation, Inc. + Copyright (C) 1998, 1999, 2000, 2001, 2002 Free Software Foundation, Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -19,41 +19,35 @@ # include #endif -#if ENABLE_NLS -# include -# define _(Text) gettext (Text) -#else -# define _(Text) Text -#endif +#include "closeout.h" -#if HAVE_STDLIB_H -# include -#endif -#ifndef EXIT_FAILURE -# define EXIT_FAILURE 1 -#endif +#include #include #ifndef errno extern int errno; #endif -#include -#include "closeout.h" +#include "gettext.h" +#define _(msgid) gettext (msgid) + #include "error.h" +#include "exitfail.h" +#include "quotearg.h" +#include "unlocked-io.h" +#include "__fpending.h" -static int default_exit_status = EXIT_FAILURE; +static const char *file_name; -/* Set the value to be used for the exit status when close_stdout is called. - This is useful when it is not convenient to call close_stdout_status, - e.g., when close_stdout is called via atexit. */ +/* Set the file name to be reported in the event an error is detected + by close_stdout. */ void -close_stdout_set_status (int status) +close_stdout_set_file_name (const char *file) { - default_exit_status = status; + file_name = file; } -/* Close standard output, exiting with status STATUS on failure. +/* Close standard output, exiting with status 'exit_failure' on failure. If a program writes *anything* to stdout, that program should `fflush' stdout and make sure that it succeeds before exiting. Otherwise, suppose that you go to the extreme of checking the return status @@ -75,18 +69,27 @@ close_stdout_set_status (int status) It's important to detect such failures and exit nonzero because many tools (most notably `make' and other build-management systems) depend on being able to detect failure in other tools via their exit status. */ -void -close_stdout_status (int status) -{ - if (ferror (stdout)) - error (status, 0, _("write error")); - if (fclose (stdout) != 0) - error (status, errno, _("write error")); -} -/* Close standard output, exiting with status EXIT_FAILURE on failure. */ void close_stdout (void) { - close_stdout_status (default_exit_status); + int e = ferror (stdout) ? 0 : -1; + + /* If the stream's error bit is clear and there is nothing to flush, + then return right away. */ + if (e && __fpending (stdout) == 0) + return; + + if (fclose (stdout) != 0) + e = errno; + + if (0 <= e) + { + char const *write_error = _("write error"); + if (file_name) + error (exit_failure, e, "%s: %s", quotearg_colon (file_name), + write_error); + else + error (exit_failure, e, "%s", write_error); + } }