X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=lib%2Fgetaddrinfo.c;h=aa07903445683ad40d73f87741e33cd1c393f314;hb=dd6ceef65e424d30db8706273f88c20b015012ce;hp=51cc0335a248eff653d0f288a4194a8f328e7ff3;hpb=df36afa2e69d1d32dc69a41c07abca593a33ef5f;p=gnulib.git

diff --git a/lib/getaddrinfo.c b/lib/getaddrinfo.c
index 51cc0335a..aa0790344 100644
--- a/lib/getaddrinfo.c
+++ b/lib/getaddrinfo.c
@@ -1,5 +1,6 @@
 /* Get address information (partial implementation).
-   Copyright (C) 1997, 2001, 2002, 2004, 2005, 2006 Free Software Foundation, Inc.
+   Copyright (C) 1997, 2001, 2002, 2004, 2005, 2006, 2007 Free Software
+   Foundation, Inc.
    Contributed by Simon Josefsson <simon@josefsson.org>.
 
    This program is free software; you can redistribute it and/or modify
@@ -16,9 +17,7 @@
    along with this program; if not, write to the Free Software Foundation,
    Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
 
-#ifdef HAVE_CONFIG_H
-# include <config.h>
-#endif
+#include <config.h>
 
 #include "getaddrinfo.h"
 
@@ -29,9 +28,12 @@
 /* Get calloc. */
 #include <stdlib.h>
 
-/* Get memcpy. */
+/* Get memcpy, strdup. */
 #include <string.h>
 
+/* Get snprintf. */
+#include <stdio.h>
+
 #include <stdbool.h>
 
 #include "gettext.h"
@@ -39,8 +41,6 @@
 #define N_(String) String
 
 #include "inet_ntop.h"
-#include "intprops.h"
-#include "strdup.h"
 
 /* BeOS has AF_INET, but not PF_INET.  */
 #ifndef PF_INET
@@ -179,7 +179,7 @@ getaddrinfo (const char *restrict nodename,
       const char *proto =
 	(hints && hints->ai_socktype == SOCK_DGRAM) ? "udp" : "tcp";
 
-      if (!(hints->ai_flags & AI_NUMERICSERV))
+      if (hints == NULL || !(hints->ai_flags & AI_NUMERICSERV))
 	/* FIXME: Use getservbyname_r if available. */
 	se = getservbyname (servname, proto);
 
@@ -408,11 +408,8 @@ int getnameinfo(const struct sockaddr *restrict sa, socklen_t salen,
 	{
 	  unsigned short int port
 	    = ntohs (((const struct sockaddr_in *) sa)->sin_port);
-	  char buf[INT_BUFSIZE_BOUND (port)];
-	  char const *s = uinttostr (port, buf);
-	  if (strlen (s) + 1 > servicelen)
+	  if (servicelen <= snprintf (service, servicelen, "%u", port))
 	    return EAI_OVERFLOW;
-	  memcpy (service, s, strlen (s) + 1);
 	}
 	break;
       }