X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=lib%2Frmdir.c;h=ec7a586f70224762866aa43e41041b2fa6cace62;hb=7ef6c64e210ac0979d7e8ac69bc5b5208c2405ab;hp=a8c1f49eb0807d617291ab6e688d44cedfcb13ca;hpb=bdb3a90e0a3a8091e92c7496ebf419a0501500d0;p=gnulib.git diff --git a/lib/rmdir.c b/lib/rmdir.c index a8c1f49eb..ec7a586f7 100644 --- a/lib/rmdir.c +++ b/lib/rmdir.c @@ -1,10 +1,12 @@ -/* rmdir.c -- BSD compatible remove directory function for System V - Copyright (C) 1988, 1990 Free Software Foundation, Inc. +/* Work around rmdir bugs. - This program is free software; you can redistribute it and/or modify + Copyright (C) 1988, 1990, 1999, 2003-2006, 2009-2014 Free Software + Foundation, Inc. + + This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2, or (at your option) - any later version. + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of @@ -12,77 +14,40 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ + along with this program. If not, see . */ -#ifdef HAVE_CONFIG_H #include -#endif -#include -#include +#include #include -#ifndef errno -extern int errno; -#endif - -#ifdef STAT_MACROS_BROKEN -#undef S_ISDIR -#endif +#include -#if !defined(S_ISDIR) && defined(S_IFDIR) -#define S_ISDIR(m) (((m) & S_IFMT) == S_IFDIR) -#endif +#include "dosname.h" -#include "safe-stat.h" +#undef rmdir -/* rmdir adapted from GNU tar. */ - -/* Remove directory DPATH. +/* Remove directory DIR. Return 0 if successful, -1 if not. */ int -rmdir (dpath) - char *dpath; +rpl_rmdir (char const *dir) { - int cpid, status; - struct stat statbuf; - - if (stat (dpath, &statbuf) != 0) - return -1; /* errno already set */ - - if (!S_ISDIR (statbuf.st_mode)) + /* Work around cygwin 1.5.x bug where rmdir("dir/./") succeeds. */ + size_t len = strlen (dir); + int result; + while (len && ISSLASH (dir[len - 1])) + len--; + if (len && dir[len - 1] == '.' && (1 == len || ISSLASH (dir[len - 2]))) { - errno = ENOTDIR; + errno = EINVAL; return -1; } - - cpid = fork (); - switch (cpid) - { - case -1: /* cannot fork */ - return -1; /* errno already set */ - - case 0: /* child process */ - execl ("/bin/rmdir", "rmdir", dpath, (char *) 0); - _exit (1); - - default: /* parent process */ - - /* Wait for kid to finish. */ - - while (wait (&status) != cpid) - /* Do nothing. */ ; - - if (status & 0xFFFF) - { - - /* /bin/rmdir failed. */ - - errno = EIO; - return -1; - } - return 0; - } + result = rmdir (dir); + /* Work around mingw bug, where rmdir("file/") fails with EINVAL + instead of ENOTDIR. We've already filtered out trailing ., the + only reason allowed by POSIX for EINVAL. */ + if (result == -1 && errno == EINVAL) + errno = ENOTDIR; + return result; }