X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=lib%2Fxstrtol.c;h=29dc0773f833c5f12833d3e2bebed8c03001c370;hb=12cc8b970806cca3260e499c74d2f001df705a60;hp=4d57d94318217a4e47eebc9daa5dca04bc76ca28;hpb=3af47ca3f672f6c43bc63843a91ecfac278d846f;p=gnulib.git

diff --git a/lib/xstrtol.c b/lib/xstrtol.c
index 4d57d9431..29dc0773f 100644
--- a/lib/xstrtol.c
+++ b/lib/xstrtol.c
@@ -1,15 +1,41 @@
-#ifdef HAVE_CONFIG_H
-#include <config.h>
+/* A more useful interface to strtol.
+   Copyright (C) 1995, 1996, 1998 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2, or (at your option)
+   any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software Foundation,
+   Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
+
+/* Written by Jim Meyering. */
+
+#if HAVE_CONFIG_H
+# include <config.h>
 #endif
 
-#ifdef STDC_HEADERS
-#include <stdlib.h>
+#if STDC_HEADERS
+# include <stdlib.h>
+#endif
+
+#if HAVE_STRING_H
+# include <string.h>
 #else
-long int __strtol (const char *, char **, int base);
+# include <strings.h>
+# ifndef strchr
+#  define strchr index
+# endif
 #endif
 
+#define NDEBUG
 #include <assert.h>
-/* FIXME: define NDEBUG before release.  */
 
 #include <errno.h>
 #ifndef errno
@@ -17,30 +43,51 @@ extern int errno;
 #endif
 
 #if HAVE_LIMITS_H
-#include <limits.h>
+# include <limits.h>
 #endif
 
+#ifndef CHAR_BIT
+# define CHAR_BIT 8
+#endif
+
+/* The extra casts work around common compiler bugs.  */
+#define TYPE_SIGNED(t) (! ((t) 0 < (t) -1))
+/* The outer cast is needed to work around a bug in Cray C 5.0.3.0.
+   It is necessary at least when t == time_t.  */
+#define TYPE_MINIMUM(t) ((t) (TYPE_SIGNED (t) \
+			      ? ~ (t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0))
+#define TYPE_MAXIMUM(t) (~ (t) 0 - TYPE_MINIMUM (t))
+
 #ifndef ULONG_MAX
-#define ULONG_MAX ((unsigned long) ~(unsigned long) 0)
+# define ULONG_MAX TYPE_MAXIMUM (unsigned long int)
 #endif
 
 #ifndef LONG_MAX
-#define LONG_MAX ((long int) (ULONG_MAX >> 1))
+# define LONG_MAX TYPE_MAXIMUM (long int)
 #endif
 
 #include "xstrtol.h"
 
+#define BKM_SCALE(x, scale_factor, error_return)			\
+      do								\
+	{								\
+	  if ((x) > (double) __ZLONG_MAX / (scale_factor))		\
+	    return (error_return);					\
+	  (x) *= (scale_factor);					\
+	}								\
+      while (0)
+
 __unsigned long int __strtol ();
 
 /* FIXME: comment.  */
 
 strtol_error
-__xstrtol (s, ptr, base, val, allow_bkm_suffix)
+__xstrtol (s, ptr, base, val, valid_suffixes)
      const char *s;
      char **ptr;
      int base;
      __unsigned long int *val;
-     int allow_bkm_suffix;
+     const char *valid_suffixes;
 {
   char *t_ptr;
   char **p;
@@ -56,49 +103,52 @@ __xstrtol (s, ptr, base, val, allow_bkm_suffix)
     return LONGINT_OVERFLOW;
   if (*p == s)
     return LONGINT_INVALID;
-  if (!allow_bkm_suffix)
+
+  /* Let valid_suffixes == NULL mean `allow any suffix'.  */
+  /* FIXME: update all callers except the one in tail.c changing
+     last parameter NULL to `""'.  */
+  if (!valid_suffixes)
     {
-      if (**p == '\0')
-	{
-	  *val = tmp;
-	  return LONGINT_OK;
-	}
-      else
-	return LONGINT_INVALID_SUFFIX_CHAR;
+      *val = tmp;
+      return LONGINT_OK;
     }
 
-  switch (**p)
+  if (**p != '\0')
     {
-    case '\0':
-      break;
-
-#define BKM_SCALE(x, scale_factor, error_return)			\
-      do								\
-	{								\
-	  if ((x) > (double) __ZLONG_MAX / (scale_factor))		\
-	    return (error_return);					\
-	  (x) *= (scale_factor);					\
-	}								\
-      while (0)
-
-    case 'b':
-      BKM_SCALE (tmp, 512, LONGINT_OVERFLOW);
-      ++(*p);
-      break;
-
-    case 'k':
-      BKM_SCALE (tmp, 1024, LONGINT_OVERFLOW);
-      ++(*p);
-      break;
-
-    case 'm':
-      BKM_SCALE (tmp, 1024 * 1024, LONGINT_OVERFLOW);
-      ++(*p);
-      break;
+      if (!strchr (valid_suffixes, **p))
+	return LONGINT_INVALID_SUFFIX_CHAR;
 
-    default:
-      return LONGINT_INVALID_SUFFIX_CHAR;
-      break;
+      switch (**p)
+	{
+	case 'b':
+	  BKM_SCALE (tmp, 512, LONGINT_OVERFLOW);
+	  ++(*p);
+	  break;
+
+	case 'c':
+	  ++(*p);
+	  break;
+
+	case 'B':
+	case 'k':
+	  BKM_SCALE (tmp, 1024, LONGINT_OVERFLOW);
+	  ++(*p);
+	  break;
+
+	case 'm':
+	  BKM_SCALE (tmp, 1024 * 1024, LONGINT_OVERFLOW);
+	  ++(*p);
+	  break;
+
+	case 'w':
+	  BKM_SCALE (tmp, 2, LONGINT_OVERFLOW);
+	  ++(*p);
+	  break;
+
+	default:
+	  return LONGINT_INVALID_SUFFIX_CHAR;
+	  break;
+	}
     }
 
   *val = tmp;
@@ -107,8 +157,8 @@ __xstrtol (s, ptr, base, val, allow_bkm_suffix)
 
 #ifdef TESTING_XSTRTO
 
-#include <stdio.h>
-#include "error.h"
+# include <stdio.h>
+# include "error.h"
 
 char *program_name;
 
@@ -124,7 +174,7 @@ main (int argc, char** argv)
       char *p;
       __unsigned long int val;
 
-      s_err = __xstrtol (argv[i], &p, 0, &val, 1);
+      s_err = __xstrtol (argv[i], &p, 0, &val, "bckmw");
       if (s_err == LONGINT_OK)
 	{
 	  printf ("%s->%lu (%s)\n", argv[i], val, p);
@@ -136,4 +186,5 @@ main (int argc, char** argv)
     }
   exit (0);
 }
+
 #endif /* TESTING_XSTRTO */