X-Git-Url: http://erislabs.net/gitweb/?a=blobdiff_plain;f=m4%2Fmktime.m4;h=10e02db55a857b64a419ce9d0651384af015fcc1;hb=a4b08c6402dda3bf4e19761c7df21d30bd638bd9;hp=9a9cc2ff4e0439619e9d9f42c093af486bf51f6d;hpb=79f0c0b0e322150b2ce6e67b0becc9b9a4abaa5b;p=gnulib.git diff --git a/m4/mktime.m4 b/m4/mktime.m4 index 9a9cc2ff4..10e02db55 100644 --- a/m4/mktime.m4 +++ b/m4/mktime.m4 @@ -1,14 +1,12 @@ -#serial 103 -dnl FIXME: when this goes back into automake, reset this to a small number +#serial 1001 -dnl From Jim Meyering. -dnl FIXME: this should migrate into libit. - -dnl FIXME: when this goes back into automake, remove all jm_ prefixes +dnl Just like mktime.m4 from automake-1.3b, but with an additional test. +dnl Renamed to have jm_ prefix and to use jm_ prefix on cache variable names. AC_DEFUN(jm_AM_FUNC_MKTIME, [AC_REQUIRE([AC_HEADER_TIME])dnl - AC_CHECK_HEADERS(sys/time.h) + AC_CHECK_HEADERS(sys/time.h unistd.h) + AC_CHECK_FUNCS(alarm) AC_CACHE_CHECK([for working mktime], jm_am_cv_func_working_mktime, [AC_TRY_RUN( changequote(<<, >>)dnl @@ -25,22 +23,59 @@ changequote(<<, >>)dnl # endif #endif +#if HAVE_UNISTD_H +# include +#endif + +#if !HAVE_ALARM +# define alarm(X) /* empty */ +#endif + +/* Work around redefinition to rpl_putenv by other config tests. */ +#undef putenv + static time_t time_t_max; /* Values we'll use to set the TZ environment variable. */ static const char *const tz_strings[] = { - NULL, "GMT0", "JST-9", "EST+3EDT+2,M10.1.0/00:00:00,M2.3.0/00:00:00" + (const char *) 0, "TZ=GMT0", "TZ=JST-9", + "TZ=EST+3EDT+2,M10.1.0/00:00:00,M2.3.0/00:00:00" }; #define N_STRINGS (sizeof (tz_strings) / sizeof (tz_strings[0])) +/* Fail if mktime fails to convert a date in the spring-forward gap. + Based on a problem report from Andreas Jaeger. */ +static void +spring_forward_gap () +{ + /* glibc (up to about 1998-10-07) failed this test) */ + struct tm tm; + + /* Use the portable POSIX.1 specification "TZ=PST8PDT,M4.1.0,M10.5.0" + instead of "TZ=America/Vancouver" in order to detect the bug even + on systems that don't support the Olson extension, or don't have the + full zoneinfo tables installed. */ + putenv ("TZ=PST8PDT,M4.1.0,M10.5.0"); + tm.tm_year = 98; + tm.tm_mon = 3; + tm.tm_mday = 5; + tm.tm_hour = 2; + tm.tm_min = 0; + tm.tm_sec = 0; + tm.tm_isdst = -1; + if (mktime (&tm) == (time_t)-1) + exit (1); +} + static void mktime_test (now) time_t now; { - if (mktime (localtime (&now)) != now) + struct tm *lt; + if ((lt = localtime (&now)) && mktime (lt) != now) exit (1); now = time_t_max - now; - if (mktime (localtime (&now)) != now) + if ((lt = localtime (&now)) && mktime (lt) != now) exit (1); } @@ -61,12 +96,43 @@ irix_6_4_bug () exit (1); } +static void +bigtime_test (j) + int j; +{ + struct tm tm; + time_t now; + tm.tm_year = tm.tm_mon = tm.tm_mday = tm.tm_hour = tm.tm_min = tm.tm_sec = j; + /* This test makes some buggy mktime implementations loop. + Give up after 10 seconds. */ + alarm (10); + now = mktime (&tm); + alarm (0); + if (now != (time_t) -1) + { + struct tm *lt = localtime (&now); + if (! (lt + && lt->tm_year == tm.tm_year + && lt->tm_mon == tm.tm_mon + && lt->tm_mday == tm.tm_mday + && lt->tm_hour == tm.tm_hour + && lt->tm_min == tm.tm_min + && lt->tm_sec == tm.tm_sec + && lt->tm_yday == tm.tm_yday + && lt->tm_wday == tm.tm_wday + && ((lt->tm_isdst < 0 ? -1 : 0 < lt->tm_isdst) + == (tm.tm_isdst < 0 ? -1 : 0 < tm.tm_isdst)))) + exit (1); + } +} + int main () { time_t t, delta; - int i; + int i, j; + spring_forward_gap (); for (time_t_max = 1; 0 < time_t_max; time_t_max *= 2) continue; time_t_max--; @@ -80,6 +146,10 @@ main () mktime_test (t); mktime_test ((time_t) 60 * 60); mktime_test ((time_t) 60 * 60 * 24); + + for (j = 1; 0 < j; j *= 2) + bigtime_test (j); + bigtime_test (j - 1); } irix_6_4_bug (); exit (0);