clean-temp: Fix memory leak.

* lib/clean-temp.c (cleanup_temp_dir): Free also the 'subdirs' and
'files' members of tmpdir.

diff --git a/ChangeLog b/ChangeLog
index 378c405..aa69418 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-07-28  John Darrington  <john@darrington.wattle.id.au>
+
+       clean-temp: Fix memory leak.
+       * lib/clean-temp.c (cleanup_temp_dir): Free also the 'subdirs' and
+       'files' members of tmpdir.
+
 2012-07-27  Jim Meyering  <meyering@redhat.com>
 
        maint.mk: new rule: refresh-gnulib-patches

diff --git a/lib/clean-temp.c b/lib/clean-temp.c
index ef926e5..55eeb01 100644 (file)
--- a/lib/clean-temp.c
+++ b/lib/clean-temp.c
@@ -556,7 +556,10 @@ cleanup_temp_dir (struct temp_dir *dir)
           }
         else
           cleanup_list.tempdir_list[i] = NULL;
-        /* Now only we can free the tmpdir->dirname and tmpdir itself.  */
+        /* Now only we can free the tmpdir->dirname, tmpdir->subdirs,
+           tmpdir->files, and tmpdir itself.  */
+        gl_list_free (tmpdir->files);
+        gl_list_free (tmpdir->subdirs);
         free (tmpdir->dirname);
         free (tmpdir);
         return err;