From 1ad225807ea68a44e04f0b081328caedda54f6c1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 31 Jan 2008 13:04:07 +0100 Subject: [PATCH] Prefer "sizeof v" over the equivalent "4". * lib/md4.c (set_uint32): Use "sizeof v" as memcpy length, not 4. * lib/md5.c (set_uint32): Likewise. * lib/sha1.c (set_uint32): Likewise. --- ChangeLog | 7 +++++++ lib/md4.c | 2 +- lib/md5.c | 2 +- lib/sha1.c | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index f7711d838..c7808c43a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2008-01-31 Jim Meyering + + Prefer "sizeof v" over the equivalent "4". + * lib/md4.c (set_uint32): Use "sizeof v" as memcpy length, not 4. + * lib/md5.c (set_uint32): Likewise. + * lib/sha1.c (set_uint32): Likewise. + 2008-01-31 Simon Josefsson * lib/sha1.c (set_uint32): Mark function as static. diff --git a/lib/md4.c b/lib/md4.c index daedaf520..dd1e2df40 100644 --- a/lib/md4.c +++ b/lib/md4.c @@ -70,7 +70,7 @@ md4_init_ctx (struct md4_ctx *ctx) static void set_uint32 (char *cp, uint32_t v) { - memcpy (cp, &v, 4); + memcpy (cp, &v, sizeof v); } /* Put result from CTX in first 16 bytes following RESBUF. The result diff --git a/lib/md5.c b/lib/md5.c index 50a264668..b6d307c40 100644 --- a/lib/md5.c +++ b/lib/md5.c @@ -86,7 +86,7 @@ md5_init_ctx (struct md5_ctx *ctx) static void set_uint32 (char *cp, uint32_t v) { - memcpy (cp, &v, 4); + memcpy (cp, &v, sizeof v); } /* Put result from CTX in first 16 bytes following RESBUF. The result diff --git a/lib/sha1.c b/lib/sha1.c index 22172a950..8869d43ff 100644 --- a/lib/sha1.c +++ b/lib/sha1.c @@ -73,7 +73,7 @@ sha1_init_ctx (struct sha1_ctx *ctx) static void set_uint32 (char *cp, uint32_t v) { - memcpy (cp, &v, 4); + memcpy (cp, &v, sizeof v); } /* Put result from CTX in first 20 bytes following RESBUF. The result -- 2.11.0