From 25452ca9972bbd8746eab0b09dfb74e51dbf60ff Mon Sep 17 00:00:00 2001 From: zapata Date: Wed, 9 Nov 2005 14:08:56 +0000 Subject: [PATCH 1/1] - icons in comment list - operations available in the ip log --- build.xml | 16 +++---- bundles/admin_en.properties | 13 +++--- etc/producer/article.template | 2 +- source/mircoders/global/Abuse.java | 19 ++++++++- .../mircoders/servlet/ServletModuleLocalizer.java | 49 ++++++++++++++++++++++ templates/admin/FUNCTIONS.template | 24 +++++++++++ templates/admin/abuse.log.template | 47 +++++++++++++++++---- templates/admin/commentlist.template | 8 +++- 8 files changed, 152 insertions(+), 26 deletions(-) diff --git a/build.xml b/build.xml index 326228c2..0cb5cf32 100755 --- a/build.xml +++ b/build.xml @@ -197,20 +197,20 @@ - + - - + + - + - + - - - + + + diff --git a/bundles/admin_en.properties b/bundles/admin_en.properties index 9cfba90f..bb55f119 100755 --- a/bundles/admin_en.properties +++ b/bundles/admin_en.properties @@ -1,6 +1,6 @@ ########## admin ########## # language: english -# $Id: admin_en.properties,v 1.48.2.25 2005/01/16 00:16:22 zapata Exp $ +# $Id: admin_en.properties,v 1.48.2.26 2005/11/09 14:08:56 zapata Exp $ languagename=English @@ -71,7 +71,7 @@ media.is_published=published media.icon=icon media.nr_of_media=Number of Media Items (max 20) media.nr_of_media.submit=define number -media.comments=Comments +media.comments=Comments media.articles=Articles medialist.search_text_in=Search text in @@ -120,7 +120,7 @@ comment.url=Url comment.creator=Author comment.article=Article comment.html=HTML -comment.status=Status +comment.status=Status comment.language=Language comment.allcomments=All comments comment.comment=Internal Comment @@ -487,8 +487,7 @@ abuse.log.time=Time abuse.log.address=IP number abuse.log.object=Object abuse.log.browser=Browser -abuse.log.filtertype=Filter type -abuse.log.filterexpression=Expression +abuse.log.filtertag = Filter tag abuse.filters = Filters filters.movedown = down @@ -498,8 +497,8 @@ filters.movetop = top filter.type = Type filter.expression = Expression -filter.articleaction = Article -filter.commentaction = Comment +filter.articleaction = Article +filter.commentaction = Comment filter.comment = Comments (internal usage) filter.last_hit = Last hit filter.htmltitle = Edit filter diff --git a/etc/producer/article.template b/etc/producer/article.template index cf4695a8..ebf644c8 100755 --- a/etc/producer/article.template +++ b/etc/producer/article.template @@ -109,7 +109,7 @@
  -
+

 ${lang("general.addtranslation")} >> diff --git a/source/mircoders/global/Abuse.java b/source/mircoders/global/Abuse.java index e7dc56fd..329aeffc 100755 --- a/source/mircoders/global/Abuse.java +++ b/source/mircoders/global/Abuse.java @@ -59,6 +59,8 @@ import mircoders.abuse.FilterEngine; import mircoders.entity.EntityComment; import mircoders.entity.EntityContent; import mircoders.localizer.MirAdminInterfaceLocalizer; +import mircoders.module.ModuleContent; +import mircoders.module.ModuleComment; import org.apache.commons.collections.ExtendedProperties; @@ -86,10 +88,12 @@ public class Abuse { private static String cookieName = MirGlobal.config().getString("Abuse.CookieName"); private static int cookieMaxAge = 60 * 60 * MirGlobal.config().getInt("Abuse.CookieMaxAge"); + private EntityAdapterModel model; public Abuse(EntityAdapterModel aModel) { logger = new LoggerWrapper("Global.Abuse"); filterEngine = new FilterEngine(aModel); + model = aModel; log = new ArrayList(); @@ -283,6 +287,9 @@ public class Abuse { } public List getLog() { + ModuleContent contentModule = new ModuleContent(); + ModuleComment commentModule = new ModuleComment(); + synchronized (log) { try { List result = new ArrayList(); @@ -295,10 +302,18 @@ public class Abuse { entry.put("ip", logEntry.getIpNumber()); entry.put("id", logEntry.getId()); entry.put("timestamp", new GeneratorFormatAdapters.DateFormatAdapter(logEntry.getTimeStamp(), MirPropertiesConfiguration.instance().getString("Mir.DefaultTimezone"))); - if (logEntry.getIsArticle()) + + if (logEntry.getIsArticle()) { entry.put("type", "content"); - else + entry.put("object", + model.makeEntityAdapter("content", contentModule.getById(logEntry.getId()))); + } + else { entry.put("type", "comment"); + entry.put("object", + model.makeEntityAdapter("comment", commentModule.getById(logEntry.getId()))); + } + entry.put("browser", logEntry.getBrowserString()); entry.put("filtertag", logEntry.getMatchingFilterTag()); diff --git a/source/mircoders/servlet/ServletModuleLocalizer.java b/source/mircoders/servlet/ServletModuleLocalizer.java index 3862daf0..4944f232 100755 --- a/source/mircoders/servlet/ServletModuleLocalizer.java +++ b/source/mircoders/servlet/ServletModuleLocalizer.java @@ -117,6 +117,23 @@ public class ServletModuleLocalizer extends AdminServletModule { ServletHelper.redirect(aResponse, returnUrlString); } + public void operation(HttpServletRequest aRequest, HttpServletResponse aResponse) throws ServletModuleExc { + String type = aRequest.getParameter("objecttype"); + String id = aRequest.getParameter("id"); + String operation = aRequest.getParameter("operation"); + String returnUrl = aRequest.getParameter("returnurl"); + + + if ("comment".equals(type)) { + performCommentOperation(aRequest, id, operation); + } + else { + performArticleOperation(aRequest, id, operation); + } + + ServletHelper.redirect(aResponse, returnUrl); + } + public void commentoperationbatch(HttpServletRequest aRequest, HttpServletResponse aResponse) throws ServletModuleExc { String returnUrlString = aRequest.getParameter("returnurl"); @@ -144,6 +161,38 @@ public class ServletModuleLocalizer extends AdminServletModule { ServletHelper.redirect(aResponse, returnUrlString); } + public void operationbatch(HttpServletRequest aRequest, HttpServletResponse aResponse) throws ServletModuleExc { + String returnUrlString = aRequest.getParameter("returnurl"); + + String[] operations = aRequest.getParameterValues("operation"); + + if (operations!=null) { + for (int i = 0; i < operations.length; i++) { + if (operations[i].length() > 0) { + List parts = StringRoutines.splitString(operations[i], ";"); + + if (parts.size() != 3) { + getLogger().error("commentoperationbatch: operation string invalid: " + + operations[i]); + } + else { + String type = (String) parts.get(0); + String id = (String) parts.get(1); + String operationString = (String) parts.get(2); + + if ("comment".equals(type)) { + performCommentOperation(aRequest, id, operationString); + } + else { + performArticleOperation(aRequest, id, operationString); + } + } + } + } + } + + ServletHelper.redirect(aResponse, returnUrlString); + } public void performArticleOperation(HttpServletRequest aRequest, String anId, String anOperation) { EntityContent entity; diff --git a/templates/admin/FUNCTIONS.template b/templates/admin/FUNCTIONS.template index 0a0e8823..759ad875 100755 --- a/templates/admin/FUNCTIONS.template +++ b/templates/admin/FUNCTIONS.template @@ -548,4 +548,28 @@
+ + + + + + + + + + edit + + + + edit + + + edit + + + edit + + + diff --git a/templates/admin/abuse.log.template b/templates/admin/abuse.log.template index 32da5c04..28d2ede0 100755 --- a/templates/admin/abuse.log.template +++ b/templates/admin/abuse.log.template @@ -6,23 +6,34 @@ - +

[ < ] ${lang("back")}   ${lang("abuse.showfilterconfiguration")}

+ +
+ + + +

+ +

+ + + + - - + - - + + @@ -34,15 +45,37 @@ Comment + - - +
${lang("abuse.log.time")} ${lang("abuse.log.address")} ${lang("abuse.log.object")} ${lang("abuse.log.browser")}${lang("abuse.log.filtertype")}${lang("abuse.log.filterexpression")}${lang("abuse.log.filtertag")}
${l.timestamp.format(config["Mir.DefaultDateTimeFormat"])} + + + [ ${lang(l.type+".operation."+op)} ] + + + + + ${lang(l.type+".operation."+op)} + + + + + + ${utility.encodeHTML(l.browser)}${lang("abuse.filtertype."+l.hitfiltertype)}${utility.encodeHTML(l.hitfilterexpression)}${l.filtertag}
 
+ + +

[ < ] ${lang("back")}   diff --git a/templates/admin/commentlist.template b/templates/admin/commentlist.template index 426dc01a..8edc36fe 100755 --- a/templates/admin/commentlist.template +++ b/templates/admin/commentlist.template @@ -143,6 +143,13 @@
${utility.prettyEncodeHTML(utility.subString(entry.description, 0, config["Mir.Admin.ListTextLengthLimit"]))} + +
+ + + + +

URL: ${utility.encodeHTML(entry.main_url)}

@@ -166,7 +173,6 @@  |  ${lang("edit")} - IMAGES -- 2.11.0