From f2baeec957662d9b146c8f8e81fca1be5637a7cc Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 16 Nov 2007 11:18:36 -0800 Subject: [PATCH] Port test-getaddrinfo to Solaris. Problem reported by Bruno Haible in . * tests/test-getaddrinfo.c (simple): Add a comment asking for an explanation of setting 'hints'. (SERV1, SERV2, SERV3): Don't use "http" and "https"; this doesn't work in Solaris 10 and earlier. --- ChangeLog | 10 ++++++++++ tests/test-getaddrinfo.c | 12 +++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index ecea8e207..1ea7dc91e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2007-11-16 Paul Eggert + + Port test-getaddrinfo to Solaris. + Problem reported by Bruno Haible in + . + * tests/test-getaddrinfo.c (simple): Add a comment asking for an + explanation of setting 'hints'. + (SERV1, SERV2, SERV3): Don't use "http" and "https"; this doesn't + work in Solaris 10 and earlier. + 2007-11-15 Paul Eggert The license of gnu-make and posix-shell is now "GPLed build tool". diff --git a/tests/test-getaddrinfo.c b/tests/test-getaddrinfo.c index 4148788ee..06245164f 100644 --- a/tests/test-getaddrinfo.c +++ b/tests/test-getaddrinfo.c @@ -37,10 +37,13 @@ int simple (char *host, char *service) printf ("Finding %s service %s...\n", host, service); + /* This initializes "hints" but does not use it. Is there a reason + for this? If so, please fix this comment. */ memset (&hints, 0, sizeof (hints)); hints.ai_flags = AI_CANONNAME; hints.ai_family = AF_UNSPEC; hints.ai_socktype = SOCK_STREAM; + res = getaddrinfo (host, service, 0, &ai0); printf ("res %d: %s\n", res, gai_strerror (res)); @@ -86,12 +89,15 @@ int simple (char *host, char *service) return 0; } +/* Use numbers for http and https services, rather than names, because + Solaris 8 /etc/services does not define these service names by + default. */ #define HOST1 "www.gnu.org" -#define SERV1 "http" +#define SERV1 "80" #define HOST2 "www.ibm.com" -#define SERV2 "https" +#define SERV2 "443" #define HOST3 "microsoft.com" -#define SERV3 "http" +#define SERV3 "80" #define HOST4 "google.org" #define SERV4 "ldap" -- 2.11.0