argp: make HAVE_DECL usage consistent
authorEric Blake <eblake@redhat.com>
Fri, 13 Jul 2012 17:50:59 +0000 (11:50 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 13 Jul 2012 19:38:06 +0000 (13:38 -0600)
commit70ab74b3b42a82654b16bc75242bf9b96daa9794
treef586cbce9c47ec03092374b5ba000a01cb0a8f02
parentf74aa2c36b8cf96b5c6de3c25f2e9aed72f3e1d2
argp: make HAVE_DECL usage consistent

Autoconf guarantees that AC_CHECK_DECLS always defines the
corresponding HAVE_DECL_*.  But our hand-coded use of AC_CHECK_DECL
did not define the macro to 0, leading to a false positive complaint:
https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html
By sticking to conventions, we avoid the false positive.

* lib/argp-parse.c (__argp_parse): Check contents of HAVE_DECL
macros, not whether they are defined.
* m4/argp.m4 (gl_ARGP): Always define HAVE_DECL_* macros, per
convention with other declaration checks.
Reported by Karel Zak, with suggestions from Paul Eggert.
ChangeLog
lib/argp-parse.c
m4/argp.m4