maint.mk: catch more abuse of HAVE_DECL in syntax-check
authorEric Blake <eblake@redhat.com>
Sat, 11 May 2013 02:24:21 +0000 (20:24 -0600)
committerEric Blake <eblake@redhat.com>
Sat, 11 May 2013 02:35:20 +0000 (20:35 -0600)
commita363f4ed4a0e69187c97686ac44502c49c7f4b3d
treecde4ca54fd2195c9289c2ad47b1878bc12e44add
parent97ddbcfa0bd12b45d00b74d298f6d14832981ee4
maint.mk: catch more abuse of HAVE_DECL in syntax-check

Libvirt had a patch that attempted to do:

+#elif defined(SIOCSIFLLADDR) && defined(HAVE_STRUCT_IFREQ) && \
+    defined(HAVE_DECL_LINK_ADDR)

but which was not flagged by the syntax checker as suspicious
(all HAVE_DECL_* symbols defined by autoconf are always defined
after including <config.h>, although they are sometimes defined
as the value 0).  Now that code is flagged until changed to:

+#elif defined(SIOCSIFLLADDR) && defined(HAVE_STRUCT_IFREQ) && \
+    HAVE_DECL_LINK_ADDR

* top/maint.mk (sc_prohibit_defined_have_decl_tests): Relax regex.

Signed-off-by: Eric Blake <eblake@redhat.com>
ChangeLog
top/maint.mk