dup2, dup3: work around another cygwin crasher
authorEric Blake <eblake@redhat.com>
Thu, 26 Sep 2013 13:07:07 +0000 (07:07 -0600)
committerEric Blake <eblake@redhat.com>
Thu, 26 Sep 2013 19:16:04 +0000 (13:16 -0600)
commitfdd1b511c5c12912aae79b58e0c5f6ffa0492d6e
tree0e969daf7b52ec17b51d962720a5ec66fc9387aa
parent3bd0d48db800994cc10c3340c41d3242390dc68f
dup2, dup3: work around another cygwin crasher

Cygwin 1.7.25 can crash due to an off-by-one bug on an attempt to
duplicate a file into the current RLIMIT_NOFILE soft limit, when
that limit is smaller than the hard limit.  The intent in the
cygwin code was to allow the dup and auto-increase the soft limit,
which is itself questionable (and which we work around in the
gnulib getdtablesize module); but avoiding the crash is worth
doing even if the soft limit semantics are wrong.

http://cygwin.com/ml/cygwin/2013-09/msg00397.html
http://cygwin.com/ml/cygwin-developers/2013-q3/msg00010.html

* m4/dup2.m4 (gl_FUNC_DUP2): Expose the bug.
* m4/dup3.m4 (gl_FUNC_DUP3): Likewise.
* tests/test-dup2.c (main): Likewise.
* lib/dup2.c (rpl_dup2): Use setdtablesize to avoid it.
* lib/dup3.c (dup3): Likewise.
* doc/posix-functions/dup2.texi (dup2): Document it.
* doc/glibc-functions/dup3.texi (dup3): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
ChangeLog
doc/glibc-functions/dup3.texi
doc/posix-functions/dup2.texi
lib/dup2.c
lib/dup3.c
m4/dup2.m4
m4/dup3.m4
tests/test-dup2.c
tests/test-dup3.c