From 44de969cd62abbfe3e7cc7641a8dea7673fd2d6d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 1 Mar 2012 23:20:22 +0100 Subject: [PATCH] maint.mk: avoid spurious failure of _sc_search_regexp-using tests * top/maint.mk: Initialize _sc_search_regexp parameters, so that envvar settings cannot interfere. Otherwise, setting envvars like prohibit=foo require=bar, etc. would cause spurious test failures. --- ChangeLog | 7 +++++++ top/maint.mk | 11 +++++++++++ 2 files changed, 18 insertions(+) diff --git a/ChangeLog b/ChangeLog index e072491ec..fc1514464 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-03-01 Jim Meyering + + maint.mk: avoid spurious failure of _sc_search_regexp-using tests + * top/maint.mk: Initialize _sc_search_regexp parameters, so that + envvar settings cannot interfere. Otherwise, setting envvars like + prohibit=foo require=bar, etc. would cause spurious test failures. + 2012-03-01 Eric Blake maint.mk: add per-line exclusions to prohibitions diff --git a/top/maint.mk b/top/maint.mk index 4b0f4b74d..839f7b2c3 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -219,6 +219,17 @@ syntax-check: $(local-check) # when filtering by name via in_files, we explicitly filter out matching # names here as well. +# Initialize each, so that envvar settings cannot interfere. +export require = +export prohibit = +export exclude = +export in_vc_files = +export in_files = +export containing = +export non_containing = +export halt = +export with_grep_options = + # By default, _sc_search_regexp does not ignore case. export ignore_case = _ignore_case = $$(test -n "$$ignore_case" && printf %s -i || :) -- 2.11.0