From 8f7425866463f994538584d1dd7211603b8b0550 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Mon, 28 Oct 2013 14:44:04 -0600 Subject: [PATCH] Revert "error: make the module depend on vfprintf-posix" This reverts commit 88e5b4d4641f294d8f824d770c9c55a1abe49768. The GPL 'error' module is used by some of the gnulib testsuites; and for some projects that use LGPL 'vasnprintf' in their lib/ directory, having 'error' depend on GPL 'vfprintf-posix' meant that compilation breaks for those projects: autoreconf: running: aclocal -I m4 --force -I m4 missing file gnulib/tests/vasnprintf.c configure.ac:135: error: expected source file, required through AC_LIBSOURCES, not found m4/gnulib-comp.m4:518: gl_INIT is expanded from... configure.ac:135: the top level autom4te: /usr/bin/m4 failed with exit status: 1 I suspect that the problem encountered on OS/x was a warning from gcc complaining about inconsistent use of __attribute__((__format__ __printf__)) vs. ((__format__ __gnu_printf__)); so perhaps the real fix is to teach error.h to copy the extra care taken by stdio.h with regards to whether merely system or full GNU printf specifiers are being handled. But without actually reproducing that situation myself, the easiest action for now is to just revert the dependency that violates the 'Comment' section of vfprintf-posix. --- ChangeLog | 6 ------ modules/error | 1 - 2 files changed, 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index ba3d83ada..cf868aeab 100644 --- a/ChangeLog +++ b/ChangeLog @@ -48,12 +48,6 @@ * lib/error.c (error_tail): Add the printf attribute, to placate gcc's -Werror=suggest-attribute=format option. -2013-10-12 Jim Meyering - - error: make the module depend on vfprintf-posix - * modules/error (Depends-on): Add vfprintf-posix, since error - calls vfprintf unconditionally, via error_tail. - 2013-09-30 Jim Meyering fpending, obstack, strerror-override: use pure+const function attrs diff --git a/modules/error b/modules/error index 303765c98..f8676176b 100644 --- a/modules/error +++ b/modules/error @@ -15,7 +15,6 @@ Depends-on: strerror [test $ac_cv_lib_error_at_line = no] unistd [test $ac_cv_lib_error_at_line = no] msvc-nothrow [test $ac_cv_lib_error_at_line = no] -vfprintf-posix configure.ac: gl_ERROR -- 2.11.0