From 9926b90d5159916a539b49359b3589fe89c2d987 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 31 Aug 2011 17:47:18 +0200 Subject: [PATCH] tests: avoid spurious assertion failure in test-float.c on ppc64 * tests/test-float.c (test_long_double): Comment out an assertion, LDBL_MIN_EXP <= DBL_MIN_EXP, that is failing at least on PowerPC-64 with gcc-4.4.4. --- ChangeLog | 5 +++++ tests/test-float.c | 9 ++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 004d610b6..2c6a3b2e2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2011-08-31 Jim Meyering + tests: avoid spurious assertion failure in test-float.c on ppc64 + * tests/test-float.c (test_long_double): Comment out an assertion, + LDBL_MIN_EXP <= DBL_MIN_EXP, that is failing at least on PowerPC-64 + with gcc-4.4.4. + maint: indent with spaces, not TABs I need to get in the habit of running gnulib's "make check". Both of these would have been caught. diff --git a/tests/test-float.c b/tests/test-float.c index 530181306..57a472fae 100644 --- a/tests/test-float.c +++ b/tests/test-float.c @@ -298,7 +298,14 @@ test_long_double (void) /* Check that 'long double' is at least as wide as 'double'. */ ASSERT (LDBL_MANT_DIG >= DBL_MANT_DIG); - ASSERT (LDBL_MIN_EXP <= DBL_MIN_EXP); + + /* Normally, we would also assert this: + ASSERT (LDBL_MIN_EXP <= DBL_MIN_EXP); + but at least on powerpc64 with gcc-4.4.4, it would fail: + $ :|gcc -dD -E -include stddef.h -|grep -E 'L?DBL_MIN_EXP' + #define __DBL_MIN_EXP__ (-1021) + #define __LDBL_MIN_EXP__ (-968) + */ ASSERT (LDBL_MAX_EXP >= DBL_MAX_EXP); /* Check the value of LDBL_DIG. */ -- 2.11.0