From db75e39b38fb197b956f6866ad167bdf7121a660 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 17 Sep 2012 11:25:00 +0200 Subject: [PATCH] maint.mk: relax sc_prohibit_strcmp, to avoid a false positive * top/maint.mk (sc_prohibit_strcmp): Relax regexp, so as to match all uses of #define, not just those that start in column 1. Richard W.M. Jones reported a false positive in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902 --- ChangeLog | 8 ++++++++ top/maint.mk | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 5425df45b..1279ad350 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2012-09-17 Jim Meyering + + maint.mk: relax sc_prohibit_strcmp, to avoid a false positive + * top/maint.mk (sc_prohibit_strcmp): Relax regexp, so as to match + all uses of #define, not just those that start in column 1. + Richard W.M. Jones reported a false positive in + http://thread.gmane.org/gmane.comp.emulators.guestfs/1902 + 2012-09-16 Paul Eggert localcharset: work around Mac OS X bug with UTF-8 and MB_CUR_MAX diff --git a/top/maint.mk b/top/maint.mk index 4627bc536..09f55c509 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -330,7 +330,7 @@ sc_prohibit_atoi_atof: sp_ = strcmp *\(.+\) sc_prohibit_strcmp: @prohibit='! *strcmp *\(|\<$(sp_) *[!=]=|[!=]= *$(sp_)' \ - exclude=':# *define STRN?EQ\(' \ + exclude='# *define STRN?EQ\(' \ halt='replace strcmp calls above with STREQ/STRNEQ' \ $(_sc_search_regexp) -- 2.11.0