From ed0ba878a26a653b4ab0547cd59a587ecbc6acb3 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Thu, 15 Aug 2013 13:45:55 -0600 Subject: [PATCH] warnings: minor optimization Paul Eggert suggested that expr is more efficient than echo|sed. * m4/warnings.m4 (gl_COMPILER_OPTION_IF): Use fewer processes. Signed-off-by: Eric Blake --- ChangeLog | 3 +++ m4/warnings.m4 | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index beb2c802b..9a3e2ff9b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2013-08-15 Eric Blake + warnings: minor optimization + * m4/warnings.m4 (gl_COMPILER_OPTION_IF): Use fewer processes. + warnings: check -Wfoo rather than -Wno-foo * m4/warnings.m4 (gl_COMPILER_OPTION_IF): If name begins with -Wno-, test if the compiler recognizes the positive form instead. diff --git a/m4/warnings.m4 b/m4/warnings.m4 index cbe08b539..5f5da5160 100644 --- a/m4/warnings.m4 +++ b/m4/warnings.m4 @@ -1,4 +1,4 @@ -# warnings.m4 serial 9 +# warnings.m4 serial 10 dnl Copyright (C) 2008-2013 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -29,7 +29,7 @@ AS_LITERAL_IF([$1], [m4_pushdef([gl_Positive], m4_bpatsubst([$1], [^-Wno-], [-W]))], [gl_positive="$1" case $gl_positive in - -Wno-*) gl_positive=`echo ".$gl_positive" | sed 's/^.//; s/^-Wno-/-W/'`;; + -Wno-*) gl_positive=-W`expr "X$gl_positive" : 'X-Wno-\(.*\)'` ;; esac m4_pushdef([gl_Positive], [$gl_positive])])dnl AC_CACHE_CHECK([whether _AC_LANG compiler handles $1], m4_defn([gl_Warn]), [ -- 2.11.0