define STREQ(a,b) consistently, removing useless parentheses
authorJim Meyering <meyering@redhat.com>
Sun, 24 Jan 2010 10:31:42 +0000 (11:31 +0100)
committerJim Meyering <meyering@redhat.com>
Sun, 24 Jan 2010 10:31:42 +0000 (11:31 +0100)
commitc0221df484c4a8a32e42a595b9f6caa446cc2226
tree4e919d4571c5ed850f1c6862ac9d3f836ff4630c
parent86a209c20f700b062b4ab161f586f40c94485c61
define STREQ(a,b) consistently, removing useless parentheses

#define STREQ(a, b) (strcmp ((a), (b)) == 0) is over-parenthesized,
since the only risk is that "a" or "b" contains an unparenthesized
comma, but if either did that, STREQ would have 3 or more arguments.
Hence, #define STREQ(a, b) (strcmp (a, b) == 0) is better.
* lib/fts.c (STREQ): Remove unnecessary parentheses.
* lib/hash-triple.c (STREQ): Likewise.
* tests/test-argv-iter.c (STREQ): Use a and b, not s1 and s2.
* lib/getugroups.c (STREQ): Likewise.
ChangeLog
lib/fts.c
lib/getugroups.c
lib/hash-triple.c
tests/test-argv-iter.c