login_tty: Stricter unit test.

* modules/login_tty-tests (Depends-on): Add tcgetsid.
* tests/test-login_tty.c (main): Also check the results of tcgetpgrp()
and tcgetsid() after login_tty.
Reported by Mats Erik Andersson <mats.andersson@gisladisker.se>.

diff --git a/ChangeLog b/ChangeLog
index d86265a..25c63a5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2010-09-16  Bruno Haible  <bruno@clisp.org>
 
+       login_tty: Stricter unit test.
+       * modules/login_tty-tests (Depends-on): Add tcgetsid.
+       * tests/test-login_tty.c (main): Also check the results of tcgetpgrp()
+       and tcgetsid() after login_tty.
+       Reported by Mats Erik Andersson <mats.andersson@gisladisker.se>.
+
+2010-09-16  Bruno Haible  <bruno@clisp.org>
+
        New module 'tcgetsid'.
        * lib/tcgetsid.c: New file.
        * m4/tcgetsid.m4: New file.

diff --git a/modules/login_tty-tests b/modules/login_tty-tests
index b9cbbd7..306b0eb 100644 (file)
--- a/modules/login_tty-tests
+++ b/modules/login_tty-tests
@@ -3,6 +3,7 @@ tests/test-login_tty.c
 
 Depends-on:
 openpty
+tcgetsid
 
 configure.ac:
 

diff --git a/tests/test-login_tty.c b/tests/test-login_tty.c
index cd08f54..8560c5a 100644 (file)
--- a/tests/test-login_tty.c
+++ b/tests/test-login_tty.c
@@ -19,8 +19,12 @@
 /* Specification.  */
 extern int login_tty (int);
 
+#include <errno.h>
 #include <pty.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <termios.h>
+#include <unistd.h>
 
 int
 main ()
@@ -48,5 +52,23 @@ main ()
       }
   }
 
+  /* From here on, we cannot use stderr for error messages any more.
+     If a test fails, just abort.  */
+
+  /* Check that fd = 0, 1, 2 are now open to the controlling terminal for the
+     current process and that it is a session of its own.  */
+  {
+    int fd;
+    for (fd = 0; fd < 3; fd++)
+      if (!(tcgetpgrp (fd) == getpid ()))
+        abort ();
+    for (fd = 0; fd < 3; fd++)
+      {
+        int sid = tcgetsid (fd);
+        if (!(sid == -1 ? errno == ENOSYS : sid == getpid ()))
+          abort ();
+      }
+  }
+
   return 0;
 }