maint.mk: sc_prohibit_magic_number_exit: avoid new false positives

* top/maint.mk (sc_prohibit_magic_number_exit): Also filter out matches
for /error ?([^,]*)/.  This avoids false-positives for strings like
"Unknown error (252)", introduced via commit v0.0-7538-g92875a6.

diff --git a/ChangeLog b/ChangeLog
index 1becccf..efa1179 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2012-08-05  Jim Meyering  <meyering@redhat.com>
+
+       maint.mk: sc_prohibit_magic_number_exit: avoid new false positives
+       * top/maint.mk (sc_prohibit_magic_number_exit): Also filter out matches
+       for /error ?([^,]*)/.  This avoids false-positives for strings like
+       "Unknown error (252)", introduced via commit v0.0-7538-g92875a6.
+
 2012-08-02  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
        gnumakefile: better interaction with Automake-NG

diff --git a/top/maint.mk b/top/maint.mk
index bdc4502..f42c199 100644 (file)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -354,7 +354,7 @@ sc_prohibit_strncpy:
 #      perl -pi -e 's/(^|[^.])\b(exit ?)\(0\)/$1$2(EXIT_SUCCESS)/'
 sc_prohibit_magic_number_exit:
        @prohibit='(^|[^.])\<(usage|exit|error) ?\(-?[0-9]+[,)]'        \
-       exclude='error ?\(0,'                                           \
+       exclude='error ?\((0,|[^,]*)'                                   \
        halt='use EXIT_* values rather than magic number'               \
          $(_sc_search_regexp)