maint.mk: add strncpy-prohibiting syntax-check rule

* top/maint.mk (sc_prohibit_strncpy): New rule, from coreutils.

diff --git a/ChangeLog b/ChangeLog
index 686228c..1252100 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-05-25  Jim Meyering  <meyering@redhat.com>
+
+       maint.mk: add strncpy-prohibiting syntax-check rule
+       * top/maint.mk (sc_prohibit_strncpy): New rule, from coreutils.
+
 2012-05-24  Jim Meyering  <meyering@redhat.com>
 
        maint.mk: compute $(gpg_key_ID) more portably

diff --git a/top/maint.mk b/top/maint.mk
index 9746410..11cb6a6 100644 (file)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -332,6 +332,14 @@ sc_prohibit_strcmp:
        halt='$(ME): replace strcmp calls above with STREQ/STRNEQ'      \
          $(_sc_search_regexp)
 
+# Really.  You don't want to use this function.
+# It may fail to NUL-terminate the destination,
+# and always NUL-pads out to the specified length.
+sc_prohibit_strncpy:
+       @prohibit='\<strncpy *\('                                       \
+       halt='do not use strncpy, period'                               \
+         $(_sc_search_regexp)
+
 # Pass EXIT_*, not number, to usage, exit, and error (when exiting)
 # Convert all uses automatically, via these two commands:
 # git grep -l '\<exit *(1)' \