* lib/userspec.c (parse_user_spec): If the GID param is NULL,
then avoid group processing and treat the full spec as a user.
(parse_with_separator): Allow the USERNAME and GROUPNAME to
be optional params (NULL), in which case they're ignored.
* tests/test-userspec.c (main): Ensure NULL params are ignored.
+2013-09-19 Pádraig Brady <P@draigBrady.com>
+
+ userspec: support optional parameters to parse_user_spec()
+ * lib/userspec.c (parse_user_spec): If the GID param is NULL,
+ then avoid group processing and treat the full spec as a user.
+ (parse_with_separator): Allow the USERNAME and GROUPNAME to
+ be optional params (NULL), in which case they're ignored.
+
2013-09-19 Paul Eggert <eggert@cs.ucla.edu>
timespec: new function make_timespec, and new constants
2013-09-19 Paul Eggert <eggert@cs.ucla.edu>
timespec: new function make_timespec, and new constants
char const *g;
char *gname = NULL;
uid_t unum = *uid;
char const *g;
char *gname = NULL;
uid_t unum = *uid;
+ gid_t gnum = gid ? *gid : -1;
- *username = *groupname = NULL;
+ if (username)
+ *username = NULL;
+ if (groupname)
+ *groupname = NULL;
/* Set U and G to nonzero length strings corresponding to user and
group specifiers or to NULL. If U is not NULL, it is a newly
/* Set U and G to nonzero length strings corresponding to user and
group specifiers or to NULL. If U is not NULL, it is a newly
if (error_msg == NULL)
{
*uid = unum;
if (error_msg == NULL)
{
*uid = unum;
- *gid = gnum;
- *username = u;
- *groupname = gname;
- u = NULL;
+ if (gid)
+ *gid = gnum;
+ if (username)
+ {
+ *username = u;
+ u = NULL;
+ }
+ if (groupname)
+ {
+ *groupname = gname;
+ gname = NULL;
+ }
return _(error_msg);
}
/* Extract from SPEC, which has the form "[user][:.][group]",
a USERNAME, UID U, GROUPNAME, and GID G.
return _(error_msg);
}
/* Extract from SPEC, which has the form "[user][:.][group]",
a USERNAME, UID U, GROUPNAME, and GID G.
+ If the GID parameter is NULL the entire SPEC is treated as a user.
+ If the USERNAME and GROUPNAME parameters are NULL they're ignored.
Either user or group, or both, must be present.
If the group is omitted but the separator is given,
use the given user's login group.
Either user or group, or both, must be present.
If the group is omitted but the separator is given,
use the given user's login group.
parse_user_spec (char const *spec, uid_t *uid, gid_t *gid,
char **username, char **groupname)
{
parse_user_spec (char const *spec, uid_t *uid, gid_t *gid,
char **username, char **groupname)
{
- char const *colon = strchr (spec, ':');
+ char const *colon = gid ? strchr (spec, ':') : NULL;
char const *error_msg =
parse_with_separator (spec, colon, uid, gid, username, groupname);
char const *error_msg =
parse_with_separator (spec, colon, uid, gid, username, groupname);
- if (!colon && error_msg)
+ if (gid && !colon && error_msg)
{
/* If there's no colon but there is a dot, and if looking up the
whole spec failed (i.e., the spec is not an owner name that
{
/* If there's no colon but there is a dot, and if looking up the
whole spec failed (i.e., the spec is not an owner name that
+ /* Ensure NULL parameters are ignored. */
+ {
+ uid_t uid = (uid_t) -1;
+ char const *diag = parse_user_spec ("", &uid, NULL, NULL, NULL);
+ if (diag)
+ {
+ printf ("unexpected error: %s\n", diag);
+ fail = 1;
+ }
+ }
+