maint.mk: avoid gratuitous failure
authorTheophile Ranquet <ranquet@lrde.epita.fr>
Tue, 20 Nov 2012 10:38:45 +0000 (10:38 +0000)
committerEric Blake <eblake@redhat.com>
Wed, 21 Nov 2012 13:31:21 +0000 (06:31 -0700)
Reported by Stefano Lattarini in
<http://lists.gnu.org/archive/html/bug-bison/2012-11/msg00022.html>
* top/maint.mk (public-submodule-commit): Quote more safely.

ChangeLog
top/maint.mk

index 9c2555e..64f57e7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2012-11-20  Theophile Ranquet <ranquet@lrde.epita.fr>
+
+       maint.mk: avoid gratuitous failure
+       Reported by Stefano Lattarini in
+       <http://lists.gnu.org/archive/html/bug-bison/2012-11/msg00022.html>
+       * top/maint.mk (public-submodule-commit): Quote more safely.
+
 2012-11-20  Eli Zaretskii  <eliz@gnu.org>
 
        canonicalize, canonicalize-lgpl: support MS-Windows file names
index ea44ece..cd365e7 100644 (file)
@@ -1390,8 +1390,9 @@ submodule-checks ?= no-submodule-changes public-submodule-commit
 public-submodule-commit:
        $(AM_V_GEN)if test -d $(srcdir)/.git; then                      \
          cd $(srcdir) &&                                               \
-         git submodule --quiet foreach test '$$(git rev-parse $$sha1)' \
-             = '$$(git merge-base origin $$sha1)'                      \
+         git submodule --quiet foreach                                 \
+             test '"$$(git rev-parse "$$sha1")"'                       \
+             = '"$$(git merge-base origin "$$sha1")"'                  \
            || { echo '$(ME): found non-public submodule commit' >&2;   \
                 exit 1; };                                             \
        else                                                            \