file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const

* lib/file-has-acl.c (file_has_acl): This function (for some #ifdefs)
would evoke a new gcc warning.  Given all of the #ifdefs, it is better
not even to try to add the attribute.  Instead, add a pragma to suppress
the suggestion/warning.

diff --git a/ChangeLog b/ChangeLog
index f80c7dd..9c5a3cd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-02-02  Jim Meyering  <meyering@redhat.com>
+
+       file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const
+       * lib/file-has-acl.c (file_has_acl): This function (for some #ifdefs)
+       would evoke a new gcc warning.  Given all of the #ifdefs, it is better
+       not even to try to add the attribute.  Instead, add a pragma to suppress
+       the suggestion/warning.
+
 2012-01-31  Karl Berry  <karl@gnu.org>
 
        setstate doc: typo.

diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c
index b7c1484..89a63a6 100644 (file)
--- a/lib/file-has-acl.c
+++ b/lib/file-has-acl.c
@@ -17,6 +17,12 @@
 
    Written by Paul Eggert, Andreas Grünbacher, and Bruno Haible.  */
 
+/* Without this pragma, gcc 4.7.0 20120126 may suggest that the
+   file_has_acl function might be candidate for attribute 'const'  */
+#if (__GNUC__ == 4 && 6 <= __GNUC_MINOR__) || 4 < __GNUC__
+# pragma GCC diagnostic ignored "-Wsuggest-attribute=const"
+#endif
+
 #include <config.h>
 
 #include "acl.h"