(template based) generation is now first done to a temp file which

is then moved to its proper place, to prevent the appearance of
incomplete files on the web server

diff --git a/source/mir/generator/WriterEngine.java b/source/mir/generator/WriterEngine.java
index 47ebf4d..d20788a 100755 (executable)
--- a/source/mir/generator/WriterEngine.java
+++ b/source/mir/generator/WriterEngine.java
@@ -30,15 +30,6 @@
 
 package mir.generator;
 
-/**
- * <p>Title: </p>
- * <p>Description: </p>
- * <p>Copyright: Copyright (c) 2002</p>
- * <p>Company: </p>
- * @author unascribed
- * @version 1.0
- */
-
 public interface WriterEngine {
   public Object openWriter(String anIdentifier, String aParameter) throws GeneratorExc, GeneratorFailure;
   public void closeWriter(Object aWriter) throws GeneratorExc, GeneratorFailure;

diff --git a/source/mircoders/localizer/basic/MirBasicWriterEngine.java b/source/mircoders/localizer/basic/MirBasicWriterEngine.java
index 218a50d..c277abf 100755 (executable)
--- a/source/mircoders/localizer/basic/MirBasicWriterEngine.java
+++ b/source/mircoders/localizer/basic/MirBasicWriterEngine.java
@@ -29,31 +29,44 @@
  */
 package mircoders.localizer.basic;
 
-import java.io.BufferedWriter;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.OutputStreamWriter;
-import java.io.PrintWriter;
+import java.io.*;
 
 import mir.generator.WriterEngine;
+import mir.log.LoggerWrapper;
+import mir.config.MirPropertiesConfiguration;
+import mir.util.FileFunctions;
 import mircoders.localizer.MirLocalizerFailure;
 
 public class MirBasicWriterEngine implements WriterEngine {
   private String defaultEncoding;
 
+  protected static LoggerWrapper logger = new LoggerWrapper("Localizer.AdminInterface");
+  protected MirPropertiesConfiguration configuration = MirPropertiesConfiguration.instance();
+
+  /**
+   * Directory to store temp files into
+   */
+  private File tempDirectory;
+
   public MirBasicWriterEngine(String aDefaultEncoding) {
     defaultEncoding = aDefaultEncoding;
+    tempDirectory = configuration.getFile("TempDir");
   }
 
+  /**
+   * {@inheritDoc}
+   */
   public Object openWriter(String anIdentifier, String anEncoding) throws MirLocalizerFailure {
     String encoding;
     File file;
     File dir;
 
-    if (anEncoding != null && !anEncoding.equals(""))
+    if (anEncoding != null && !anEncoding.equals("")) {
       encoding = anEncoding;
-    else
+    }
+    else {
       encoding = defaultEncoding;
+    }
 
     try {
       file = new File(anIdentifier);
@@ -65,18 +78,44 @@ public class MirBasicWriterEngine implements WriterEngine {
       }
 
       return new PrintWriter(
-          new BufferedWriter(
-              new OutputStreamWriter(
-                new FileOutputStream(file), encoding
-          ), 8192)
+          new TempWriter(file, encoding)
       );
     }
-    catch (Throwable t) {
-      throw new MirLocalizerFailure("Failure while opening a PrintWriter: " + t.getMessage(), t);
+    catch (IOException t) {
+      throw new MirLocalizerFailure("Failure while opening a writer", t);
     }
   }
 
   public void closeWriter(Object aWriter) {
     ((PrintWriter) aWriter).close();
   }
+
+  private class TempWriter extends Writer {
+    TempWriter(File aDestination, String anEncoding) throws IOException {
+      destinationFile = aDestination;
+      slaveFile = File.createTempFile("Mir", ".generated", tempDirectory);
+      slaveWriter = new BufferedWriter(
+          new OutputStreamWriter(
+            new FileOutputStream(slaveFile), anEncoding
+      ), 8192);
+    }
+
+    public void close() throws IOException {
+      slaveWriter.close();
+      FileFunctions.move(slaveFile, destinationFile);
+    }
+
+    public void flush() throws IOException {
+      slaveWriter.flush();
+    }
+
+    public void write(char cbuf[], int off, int len) throws IOException {
+      slaveWriter.write(cbuf, off, len);
+    }
+
+    private Writer slaveWriter;
+    private File slaveFile;
+    private File destinationFile;
+  }
+
 }
\ No newline at end of file