5 use ID3FS::PathElement::Artist;
6 use ID3FS::PathElement::Album;
7 use ID3FS::PathElement::Boolean;
8 use ID3FS::PathElement::File;
9 use ID3FS::PathElement::Tag;
10 use ID3FS::PathElement::Tagval;
11 use ID3FS::Path::Node;
13 our ($STATE_INVALID, $STATE_ROOT, $STATE_TAG, $STATE_TAGVAL,
14 $STATE_BOOLEAN, $STATE_ALBUMS, $STATE_TRACKLIST,
15 $STATE_FILE, $STATE_ALL)=(0..8);
17 our %priorities=( "OR" => 0, "AND" => 1, "NOT" => 2 );
19 our $PATH_ALLTRACKS="TRACKS";
20 our $PATH_NOARTIST="NOARTIST";
21 our $PATH_NOALBUM="NOALBUM";
26 my $class=ref($proto) || $proto;
33 $self->{verbose}=shift;
34 $self->{path} =~ s/\/\//\//g; # drop doubled slashes
37 # print "STATE: ", $self->state(), "\n";
44 if(($self->state() == $STATE_FILE) ||
45 ($self->state() == $STATE_INVALID))
55 return 1 if($self->state() == $STATE_FILE);
62 return($self->state() != $STATE_INVALID);
67 my($self, $mountpoint)=@_;
68 if($self->state() == $STATE_FILE)
70 return $self->filename($mountpoint, $self);
72 return "ERROR"; #should never happen?
80 my $state=$self->state();
81 # print "DIRENTS: STATE: $state\n";
82 # print "DIRENTS: FILE: $self->{path}\n";
83 if($state==$STATE_ALL)
85 @dents=($self->artists(), $PATH_ALLTRACKS, $PATH_NOARTIST);
87 elsif($state==$STATE_TAG || $state==$STATE_TAGVAL)
89 my $tag=$self->tail();
90 if($state==$STATE_TAG &&
92 ref($tag) eq "ID3FS::PathElement::Tag" &&
93 $self->{db}->tag_has_values($tag->{id}))
99 @dents=($self->artists(), qw(AND OR), $PATH_ALLTRACKS, $PATH_NOARTIST);
102 elsif($state==$STATE_BOOLEAN)
104 @dents=$self->tags();
105 my $parent=$self->tail();
106 unless(defined($parent) &&
107 ref($parent) eq "ID3FS::PathElement::Boolean" &&
108 $parent->{name} eq "NOT")
113 elsif($state==$STATE_ROOT)
115 @dents=($self->tags(), qw(ALL NOT));
117 elsif($state==$STATE_ALBUMS)
119 @dents=($self->albums(), $PATH_ALLTRACKS, $PATH_NOALBUM);
121 elsif($state==$STATE_TRACKLIST)
123 @fents=$self->tracks();
127 print "DIRENTS: UNHANDLED STATE: $state\n";
129 return(\@dents, \@fents);
135 @{$self->{components}}=split(/\//, $self->{path});
136 shift @{$self->{components}}; # drop empty field before leading /
137 # print "PATH: $self->{path}\n";
138 $self->state($STATE_ROOT);
139 return if($self->{path} eq "/");
140 my @parts=@{$self->{components}};
142 $self->{elements}=[];
147 while(defined(my $name=shift @parts))
149 # print "NAME: $name\n";
150 my $state=$self->state();
151 if($state==$STATE_INVALID)
153 # print "SM: INVALID: $name\n";
156 elsif($state==$STATE_ROOT)
158 # print "SM: ROOT: $name\n";
162 $self->state($STATE_ALL);
164 elsif($name eq "NOT")
167 push(@{$self->{elements}}, ID3FS::PathElement::Boolean->new($self->{db}, $name));
168 $self->state($STATE_BOOLEAN);
172 $tag=ID3FS::PathElement::Tag->new($self->{db}, $name);
175 push(@{$self->{elements}}, $tag);
177 $self->state($STATE_TAG);
181 $self->state($STATE_INVALID);
185 elsif($state==$STATE_TAG || $state==$STATE_TAGVAL)
187 # print "SM: TAG/TAGVAL($state): $name\n";
188 my $tag=$self->tail();
189 if($state==$STATE_TAG &&
191 ref($tag) eq "ID3FS::PathElement::Tag" &&
192 $self->{db}->tag_has_values($tag->{id}))
194 # print "Parsing: parent: $tag->{id}\n";
195 my $tagval=ID3FS::PathElement::Tag->new($self->{db}, $name, $tag->{id});
198 $self->state($STATE_TAGVAL);
200 push(@{$self->{elements}}, $tagval);
204 $self->state($STATE_INVALID);
207 elsif($name eq $PATH_ALLTRACKS)
209 $self->state($STATE_TRACKLIST);
211 elsif($name eq $PATH_NOARTIST)
213 $self->state($STATE_TRACKLIST);
215 elsif($name eq "AND")
217 $self->state($STATE_BOOLEAN);
218 push(@{$self->{elements}}, ID3FS::PathElement::Boolean->new($self->{db}, $name));
222 $self->state($STATE_BOOLEAN);
223 push(@{$self->{elements}}, ID3FS::PathElement::Boolean->new($self->{db}, $name));
227 my $artist=ID3FS::PathElement::Artist->new($self->{db}, $name);
230 push(@{$self->{elements}}, $artist);
231 $self->state($STATE_ALBUMS);
235 $self->state($STATE_INVALID);
239 elsif($state==$STATE_BOOLEAN)
241 # print "SM: BOOLEAN: $name\n";
242 my $parent=$self->tail();
244 if(defined($parent) &&
245 ref($parent) eq "ID3FS::PathElement::Boolean" &&
246 $parent->{name} eq "NOT")
250 if($allownot && $name eq "NOT")
252 $self->state($STATE_BOOLEAN);
253 push(@{$self->{elements}}, ID3FS::PathElement::Boolean->new($self->{db}, $name));
257 my $tag=ID3FS::PathElement::Tag->new($self->{db}, $name);
260 push(@{$self->{elements}}, $tag);
262 $self->state($STATE_TAG);
266 $self->state($STATE_INVALID);
270 elsif($state==$STATE_ALBUMS)
272 # print "SM: ALBUM: $name\n";
273 if($name eq $PATH_ALLTRACKS)
275 $self->state($STATE_TRACKLIST);
277 elsif($name eq $PATH_NOALBUM)
279 $self->state($STATE_TRACKLIST);
283 my $album=ID3FS::PathElement::Album->new($self->{db}, $name);
286 push(@{$self->{elements}}, $album);
287 $self->state($STATE_TRACKLIST);
291 $self->state($STATE_INVALID);
295 elsif($state==$STATE_TRACKLIST)
297 # print "SM: TRACKLIST: $name\n";
298 my $track=ID3FS::PathElement::File->new($self->{db}, $name);
301 push(@{$self->{elements}}, $track);
302 $self->state($STATE_FILE);
306 $self->state($STATE_INVALID);
309 elsif($state==$STATE_FILE)
311 # print "SM: FILE: $name\n";
312 # Can't have anything after a filename
313 $self->state($STATE_INVALID);
315 elsif($state==$STATE_ALL)
317 if($name eq $PATH_ALLTRACKS)
319 $self->state($STATE_TRACKLIST);
321 elsif($name eq $PATH_NOARTIST)
324 $self->state($STATE_TRACKLIST);
328 my $artist=ID3FS::PathElement::Artist->new($self->{db}, $name);
331 push(@{$self->{elements}}, $artist);
332 $self->state($STATE_ALBUMS);
336 $self->state($STATE_INVALID);
342 print "SM: ERROR: UNKNOWN STATE: $self->{state}\n";
343 $self->state($STATE_INVALID);
347 if($root_not && ($tags_seen < 2))
352 # remove trailing boolean
353 my @elements=@{$self->{elements}};
354 while(@elements && ref($elements[$#elements]) eq "ID3FS::PathElement::Boolean")
358 # sort elements by precedence
359 @elements=$self->sort_elements(@elements);
360 $self->{tagtree}=$self->elements_to_tree(\@elements);
363 ($self->{sqlconditions},
364 $self->{joins}) = $self->{tagtree}->to_sql();
365 # print "TREE: ", $self->{tagtree}->print(), "\n";
366 # print("SQL CONDITION(", scalar(@{$self->{joins}}), "): ",
367 # $self->{sqlconditions}, "\n");
369 # print Dumper $self->{tagtree};
375 my($self, $newstate)=@_;
376 $self->{state}=$newstate if(defined($newstate));
377 return $self->{state};
382 my($self, $elements)=@_;
383 return undef unless(@$elements);
384 my ($left, $right, $op)=(undef, undef, undef);
385 my $thing=pop @$elements;
386 if(ref($thing) eq "ID3FS::PathElement::Boolean")
389 $right=$self->elements_to_tree($elements);
390 if($op->{name} ne "NOT")
392 $left=$self->elements_to_tree($elements);
394 return ID3FS::Path::Node->new($left, $op, $right);
398 return ID3FS::Path::Node->new($thing);
402 # Dijkstra's shunting-yard algorithm
405 my ($self, @input)=@_;
408 # print "INPUT: ", join(', ', map { $_->{name}; } @input), "\n";
409 while(my $thing = shift @input)
411 if(ref($thing) eq "ID3FS::PathElement::Tag")
413 # Handle tag values by dropping parent
414 if(@input && ref($input[0]) eq "ID3FS::PathElement::Tag")
418 push(@output, $thing);
420 elsif(ref($thing) eq "ID3FS::PathElement::Boolean")
424 ($priorities{$thing->{name}} <= $priorities{$opstack[$#opstack]->{name}}))
426 push(@output, pop(@opstack));
428 push(@opstack, $thing);
433 push(@output, pop(@opstack));
435 # print "STACK: ", join(', ', map { $_->{name}; } @output), "\n";
442 return() unless(defined($self->{tagtree}));
443 return($self->{tagtree}->used_tags());
449 my $tail=$self->tail();
450 if($tail && ref($tail) eq "ID3FS::PathElement::Tag")
452 return($self->{db}->tag_has_values($tail->{id}));
459 my $tail=$self->tail();
460 if($tail && ref($tail) eq "ID3FS::PathElement::Tag")
467 sub trailing_tag_parent
470 my $tail=$self->tail();
471 if($tail && ref($tail) eq "ID3FS::PathElement::Tag")
473 return($tail->{parents_id});
481 return($self->{elements}->[$#{$self->{elements}}]);
484 # the one before last
488 return($self->{elements}->[($#{$self->{elements}}) - 1]);
491 ######################################################################
496 if(!$self->{tagtree}) # / or /NOT # FIXME: /ALL too?
498 my $sql="SELECT DISTINCT name FROM tags WHERE parents_id='';";
499 return($self->{db}->cmd_firstcol($sql));
501 my $hasvals=$self->tag_has_values();
502 my $parent=$self->trailing_tag_parent();
503 # print "THASVALS: $hasvals\n";
504 # print "TPARENT: ", (defined($parent)? $parent : "NO"), "\n";
506 my $sql=("SELECT tags.name FROM (\n" .
507 $self->tags_subselect() .
509 "INNER JOIN files_x_tags ON subselect.files_id=files_x_tags.files_id\n" .
510 "INNER JOIN tags ON files_x_tags.tags_id=tags.id\n");
511 my @allused=$self->used_tags();
512 my @used=grep { ref($_) ne "ARRAY"; } @allused;
513 my @used_with_vals=grep { ref($_) eq "ARRAY"; } @allused;
514 # print "tags(): USED: ", join(", ", @used), "\n";
515 # print "tags(): USED_WITH_VALS: ", join(", ", map { "[".$_->[0]. ", ".$_->[1]."]";} @used_with_vals), "\n";
518 my $id=$self->trailing_tag_id();
521 # print "HAS_VALUES\n";
522 my @values=map { "'".$_->[1]."'"; } grep { $_->[0] == $id; } @used_with_vals;
523 my $clause="(tags.parents_id='$id'";
526 $clause .= " AND tags.id NOT IN (" . join(', ', @values) . ")";
529 push(@andclauses, $clause);
533 # print "HASNT VALUES\n";;
536 push(@andclauses, "(NOT (tags.parents_id='' AND tags.id IN (" . join(', ', @used) . ")))");
538 for my $pair (@used_with_vals)
540 push(@andclauses, "(NOT (tags.parents_id='" . $pair->[0] . "' AND tags.id='" . $pair->[1] . "'))");
544 my $parentclause= "(tags.parents_id='";
547 $parentclause .= $id;
551 $parentclause .= $parent;
553 $parentclause .= "')";
554 push(@andclauses, $parentclause);
558 push(@andclauses, '( ' . join(' OR ', @orclauses) . ' )');
562 $sql .= "WHERE " . join(' AND ', @andclauses) . "\n";
564 $sql .= "GROUP BY tags.name;";
565 print "SQL(TAGS): $sql\n" if($self->{verbose});
566 my @tagnames=$self->{db}->cmd_firstcol($sql);
567 print("SUBNAMES: ", join(', ', @tagnames), "\n") if($self->{verbose});
573 my($self, $tagid)=@_;
574 my $sql=("SELECT DISTINCT name FROM tags\n" .
575 "WHERE parents_id=?");
576 my @tags=$self->{db}->cmd_firstcol($sql, $tagid);
577 @tags=map { length($_) ? $_ : "NOVALUE"; } @tags;
584 if(!@{$self->{elements}}) # /ALL
586 my $sql="SELECT DISTINCT name FROM artists WHERE name!='';";
587 return($self->{db}->cmd_firstcol($sql));
590 my $sql=("SELECT artists.name FROM (\n" .
591 $self->tags_subselect() .
593 "INNER JOIN files ON subselect.files_id=files.id\n" .
594 "INNER JOIN artists ON files.artists_id=artists.id\n" .
595 "WHERE artists.name != ''\n" .
596 "GROUP BY artists.name;");
597 print "SQL(ARTISTS): $sql\n" if($self->{verbose});
598 my @tagnames=$self->{db}->cmd_firstcol($sql);
599 print("ARTISTS: ", join(', ', @tagnames), "\n") if($self->{verbose});
607 my $tail=$self->tail();
608 # FIXME: rework PathElements
609 if(ref($tail) eq "ID3FS::PathElement::Artist")
611 return $self->artist_albums($tail->{id});
616 $sql="SELECT name FROM albums";
620 $sql=("SELECT albums.name\n" .
622 $self->tags_subselect() .
623 "\t) AS subselect\n" .
624 "INNER JOIN files ON subselect.files_id=files.id\n" .
625 "INNER JOIN albums ON files.albums_id=albums.id\n" .
626 "WHERE albums.name != ''\n" .
627 "GROUP BY albums.name;");
629 print "SQL(ALBUMS): \n$sql\n" if($self->{verbose});
630 my @names=$self->{db}->cmd_firstcol($sql);
631 print("ALBUMS: ", join(', ', @names), "\n") if($self->{verbose});
637 my($self, $artist_id)=@_;
638 my $sql="SELECT albums.name FROM ";
646 $self->tags_subselect() .
648 "INNER JOIN files ON subselect.files_id=files.id\n");
650 $sql .= ("INNER JOIN albums ON albums.id=files.albums_id\n" .
651 "INNER JOIN artists ON artists.id=files.artists_id\n" .
652 "WHERE artists.id=? and albums.name <> ''\n" .
653 "GROUP BY albums.name\n");
654 print "ARTIST_ALBUMS SQL: $sql\n" if($self->{verbose});
655 my @albums=$self->{db}->cmd_firstcol($sql, $artist_id);
656 print("ALBUMS: ", join(', ', @albums), "\n") if($self->{verbose});
662 my($self, $artist_id)=@_;
663 my $sql="SELECT files.name FROM ";
671 $self->tags_subselect() .
672 "\t) AS subselect\n" .
673 "INNER JOIN files ON subselect.files_id=files.id\n");
675 $sql .= ("INNER JOIN artists ON artists.id=files.artists_id\n" .
676 "INNER JOIN albums ON albums.id=files.albums_id\n" .
677 "WHERE artists.id=? AND albums.name=''\n" .
678 "GROUP BY files.name\n");
679 print "ARTIST_TRACKS SQL: $sql\n" if($self->{verbose});
680 my @names=$self->{db}->cmd_firstcol($sql, $artist_id);
681 print("ARTISTTRACKS: ", join(', ', @names), "\n") if($self->{verbose});
687 my($self, $artist_id, $album_id)=@_;
688 my $sql=("SELECT files.name FROM files\n" .
689 "INNER JOIN albums ON albums.id=files.albums_id\n" .
690 "INNER JOIN artists ON artists.id=files.artists_id\n" .
691 "WHERE artists.id=? AND albums.id=?\n" .
692 "GROUP BY files.name\n");
693 print "ALBUM_TRACKS SQL($artist_id, $album_id): $sql\n" if($self->{verbose});
694 my @names=$self->{db}->cmd_firstcol($sql, $artist_id, $album_id);
695 print("TRACKS: ", join(', ', @names), "\n") if($self->{verbose});
702 # FIXME: rework PathElements
703 my $tail=$self->tail();
704 if(ref($tail) eq "ID3FS::PathElement::Artist")
706 return $self->artist_tracks($tail->{id});
708 elsif(ref($tail) eq "ID3FS::PathElement::Album")
711 my $artist=$self->tail_parent();
712 if(defined($artist) && (ref($artist) eq "ID3FS::PathElement::Artist"))
714 # should always happen
715 $artist_id=$artist->{id};
717 return $self->album_tracks($artist_id, $tail->{id});
719 my $sql="SELECT files.name FROM ";
727 $self->tags_subselect() .
729 "INNER JOIN files ON files.id=subselect.files_id\n");
731 $sql .= "INNER JOIN artists ON files.artists_id=artists.id\n";
732 if($self->{components}->[$#{$self->{components}}] eq $PATH_NOARTIST)
734 $sql .= "WHERE artists.name =''\n";
736 $sql .= "GROUP BY files.name;";
737 print "TRACKS SQL($self->{path}): $sql\n" if($self->{verbose});
738 my @names=$self->{db}->cmd_firstcol($sql);
739 print("TRACKS: ", join(', ', @names), "\n") if($self->{verbose});
745 my($self, $mountpoint)=@_;
746 my $tail=$self->tail();
747 if(ref($tail) eq "ID3FS::PathElement::File")
750 my $sql=("SELECT paths.name, files.name FROM files\n" .
751 "INNER JOIN paths ON files.paths_id=paths.id\n" .
752 "WHERE files.id=?\n" .
753 "GROUP BY paths.name, files.name");
754 print "FILENAME SQL: $sql\n" if($self->{verbose});
755 my ($path, $name)=$self->{db}->cmd_onerow($sql, $id);
756 my $id3fs_path=join('/', map { $_->{name}; } @{$self->{elements}});
757 return($self->{db}->relativise($path, $name, $mountpoint, $id3fs_path));
759 die("DB::filename: unhandled case\n"); #FIXME
765 my $hasvals=$self->tag_has_values();
766 # we need to specially handle a bare /NOT/tag with no other clauses,
767 # using a simple WHERE id !='tagid' instead of a LEFT JOIN
768 if($self->{bare_not})
770 return $self->bare_not_subselect();
774 return "\tSELECT id FROM files AS files_id\n";
776 my $tree=$self->{tagtree};
777 my $parent=$self->trailing_tag_parent();
779 # print "ELEMENTS: ", join('/', map { $_->{name}; } @{$self->{elements}}), "\n";
780 # print "TREE: ", $tree->print(), "\n";
784 $tag=$self->trailing_tag_id();
785 # print "Trailing id: $tag\n";
787 my ($sqlclause, @joins)=(undef, ());
788 ($sqlclause, @joins) = $tree->to_sql($hasvals) if($tree);
789 # print "SQL(" . scalar(@joins) .": $sqlclause\n";
790 my $sql="\tSELECT fxt1.files_id FROM tags t1";
793 # $joinsneeded++ if($tag);
794 for(my $i=0; $i <= $#joins; $i++)
798 my $inner=("\t$join JOIN files_x_tags fxt$cnt ON " .
799 "t${cnt}.id=fxt${cnt}.tags_id");
802 push(@crosses, "CROSS JOIN tags t$cnt");
803 $inner .= " AND fxt1.files_id=fxt${cnt}.files_id";
805 push(@inners, $inner);
807 $sql .= ("\n\t" . join(" ", @crosses)) if(@crosses);
808 $sql .= ("\n" . join("\n", @inners)) if(@inners);
809 $sql .= "\n\tWHERE $sqlclause" if($sqlclause);
812 # $sql .= " AND t${joinsneeded}.parents_id='$tag'";
814 $sql .= "\n\tGROUP BY fxt1.files_id\n";
818 sub bare_not_subselect
821 my @tags=grep { ref($_) eq "ID3FS::PathElement::Tag"; } @{$self->{elements}};
822 my $sql=("\tSELECT f1.id AS files_id FROM files f1 WHERE f1.id NOT IN (\n" .
823 "\t\tSELECT fxt1.files_id FROM tags t1\n" .
824 "\t\tINNER JOIN files_x_tags fxt1 ON t1.id=fxt1.tags_id\n" .
826 if(scalar(@tags) > 1)
828 $sql .= ("(t1.parents_id='" . $tags[0]->{id} . "' AND t1.id='" .
829 $tags[1]->{id} . "')");
833 $sql .= ("(t1.parents_id='' AND t1.id='" . $tags[0]->{id} . "')");
835 $sql .= "\n\t\tGROUP BY fxt1.files_id\n\t)\n";
839 sub constraints_tag_list
841 my($self, @constraints)=@_;
845 for my $constraint (@constraints)
847 # print ref($constraint), ": ", $constraint->{name}, "\n";
848 if(ref($constraint) eq "ID3FS::PathElement::Tag")
850 if(defined($lasttag))
853 push(@tags_vals, [$lasttag, $constraint->{id}]) if defined($constraint->{id});
856 elsif($self->tag_has_values($constraint->{id}))
858 # print "HASVALUES\n";
859 $lasttag=$constraint->{id} if defined($constraint->{id});
863 # print "NOVALUES\n";
864 push(@tags, $constraint->{id}) if(defined($constraint->{id}));
868 unless($self->{db}->{postgres})
870 @tags=map{ "\"$_\""; } @tags;
871 @tags_vals=map( { [ map({ "\"$_\""; } @$_ ) ] } @tags_vals);
872 $lasttag="\"$lasttag\"" if defined($lasttag);
874 return(\@tags, \@tags_vals, $lasttag);
881 my $sql=("SELECT tags.name FROM tags\n" .
882 "WHERE tags.parents_id=''\n" .
883 "GROUP BY tags.name\n");
884 my @names=$self->{db}->cmd_firstcol($sql);
890 # FIXME: only shows one level of tag depth
892 my $sql=("SELECT p.name, t.name FROM tags t\n" .
893 "INNER JOIN tags p ON t.parents_id=p.id\n" .
894 "GROUP BY p.name, t.name\n");
895 # print "SQL: $sql\n";
896 my $result=$self->{db}->cmd_rows($sql);
898 for my $pair (@$result)
900 push(@{$tags->{$pair->[0]}}, $pair->[1]);
909 my $base=$self->{path};
911 # depth 4 to allow for tag/tagval/AND/NOT
915 # print "\nFILTER (",$self->state(), "): $base / $dir\n";
916 if($self->empty("$base/$dir", $maxdepth))
918 # print "empty: $base / $dir\n";
922 # print "non-empty, accepting: $base / $dir\n";
923 push(@outdirs, $dir);
931 my($self, $dir, $maxdepth)=@_;
932 return 0 unless($maxdepth);
933 # print "testing($maxdepth): $dir\n";
934 my $path=ID3FS::Path->new($self->{db}, $dir, $self->{verbose});
935 # print "PATH INVALID\n" unless($path->isvalid());
936 return 1 unless($path->isvalid());
937 my($subdirs,$subfiles)=$path->dirents();
938 # print "SUBDENTS: ", join(", ", @$subdirs, @$subfiles), "\n";
939 # print("SUBFILES: ", join(', ', @$subfiles), "\n") if(@$subfiles);
940 return 0 if(@$subfiles);
941 for my $subdir (@$subdirs)
943 # print "SUBSUB $dir/$subdir\n";
944 if(1) #$self->dir_is_special($subdir))
946 if($self->empty("$dir/$subdir", ($maxdepth-1)))
948 # print "EMPTY: $dir / $subdir\n";
952 # print "NONEMPTY: $dir / $subdir\n";
960 # return 0 if($self->nonempty("$dir/$subdir", ($maxdepth-1)));
965 sub tagname_has_values
968 my $id=$self->{db}->lookup_id("tags", $name);
969 return 0 unless($id);
970 return $self->{db}->tag_has_values($id);
977 if((grep { $_ eq $dir; }
978 qw(AND OR NOT), $PATH_ALLTRACKS, $PATH_NOARTIST, $PATH_NOALBUM) ||
979 ($self->tagname_has_values($dir)))